gerritbot added a comment.
Change 599345 **merged** by jenkins-bot:
[pywikibot/core@master] Do not exclude userscripts directory from pycodestyles
https://gerrit.wikimedia.org/r/599345
TASK DETAIL
https://phabricator.wikimedia.org/T253873
EMAIL PREFERENCES
https://phabricator.wikim
Dvorapa added a comment.
Anyway I guess you are right, we should not block users flake8, autopep and
pycodestyle linters where it is possible they would want to check.
TASK DETAIL
https://phabricator.wikimedia.org/T253873
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
Dvorapa added a comment.
I don't remember why I added those, I have got separate bot and development
repositories, so this patch was not for me. Someone must had requested this
somewhere, it's a shame I didn't mentioned in the commit message, who came up
with that.
TASK DETAIL
https://pha
gerritbot added a comment.
Change 599345 had a related patch set uploaded (by Huji; owner: Huji):
[pywikibot/core@master] Do not exclude userscripts directory from pycodestyles
https://gerrit.wikimedia.org/r/599345
TASK DETAIL
https://phabricator.wikimedia.org/T253873
EMAIL PREFERENC
Huji added a comment.
In other words, I can add a blank `tox.ini` file in `./scripts/userscripts`
and that fixes the issue above. However, I think the default should be the
other way around: those users who *don't* want this directory to be considered
by pycodestyles should add a `tox.ini` i
Huji added a comment.
Two questions:
1. How is it that tox.in (which is define in the root of the bot) is being
observed when I run pycodestyles in a subdirectory?
2. While we can decide which parts of bywikibot code should or should not be
excluded from pycodestyles, we cannot choose
Dvorapa added a comment.
I think it is disabled in tox.ini for purpose. I would not like to have my
userscripts analyzed and if I would do, I would update tox.ini for my fork.
TASK DETAIL
https://phabricator.wikimedia.org/T253873
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settin
