[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

gerritbot added a comment. Change 888791 **abandoned** by Xqt: [pywikibot/core@master] Add is_person_wd() method Reason: T328769 was declined https://gerrit.wikimedia.org/r/888791 TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

binbot added a comment. Yes, if we cannot agree in a good soulution, I will develop a huwiki-specific module. I just thought this feature would be useful throughout Wikipedia, but I don't insist on it. TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

RoySmith added a comment. As noted by others, I agree that it's too domain-specific to be part of the Page class. FWIW, I've implemented this (using logic specific to enwiki) as part of dyk-tools: Article.is_biography()

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

binbot added a comment. Should we create then a derived WikipediaPage class? I don't really like the idea, but later it could have other wikispecific methods. This would explicitely dedicated to this project, and whoever calls it in a bad project, can blaim him/herself. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

matej_suchanek added a comment. What I dislike about the proposal is that it introduces a domain-specific code to an almost completely generic interface. Indeed, I checked that almost every piece of code in `Page`/`BasePage` is site-agnostic and would work on whatever wiki you use it. Not

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

binbot added a comment. In T328769#8724653 , @matej_suchanek wrote: > This is too Wikimedia-specific (or even Wikipedia-specific). I'd prefer having this as a utility function or application logic rather than making it part of the

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

matej_suchanek added a comment. This is too Wikimedia-specific (or even Wikipedia-specific). I'd prefer having this as a utility function or application logic rather than making it part of the model. > project is other than Wikipedia Why? TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

Ayush_Anand3310 added a comment. @binbot I will! TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ayush_Anand3310 Cc: Ayush_Anand3310, Xqt, Aklapper, pywikibot-bugs-list, binbot, Themindcoder,

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

binbot added a comment. Thank you! Could you please add a docstring so that it appears in doc? TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: binbot Cc: Xqt, Aklapper, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Commented On] T328769: Enhance Pywikibot.Page with is_person method

gerritbot added a comment. Change 888791 had a related patch set uploaded (by Ayush Anand33; author: Ayush Anand33): [pywikibot/core@master] Add is_person_wd() method https://gerrit.wikimedia.org/r/888791 TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES