[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

gerritbot added a comment. Change 640171 **merged** by Xqt: [pywikibot/core@master] [doc] Improved doc string for logging.py function https://gerrit.wikimedia.org/r/640171 TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

gerritbot added a comment. Change 640171 had a related patch set uploaded (by Xqt; owner: Homeboy 445): [pywikibot/core@master] [doc] Improved doc string for logging.py function https://gerrit.wikimedia.org/r/640171 TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. @Xqt: Well, I have resolved the issue, fortunately. Please check if the made changes have met your expectations or not. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. @Xqt Thanks a lot for your help again! :D TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Homeboy_445 Cc: Xqt, Homeboy_445, gerritbot, Dvorapa, Urstrulykkr,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Xqt added a comment. In T85271#667 , @Homeboy_445 wrote: > @Xqt I'm done with the task but stuck with a problem. I accidentally pushed my changes to the last branch I created for the previous issue I've worked upon. So, What should

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. @Xqt I'm done with the task but stuck with a problem. I accidentally pushed my changes to the last branch I created for the previous issue I've worked upon. So, What should I do now? TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. Thanks a lot for your help I'll look forward to solving it! TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Homeboy_445 Cc: Xqt, Homeboy_445, gerritbot, Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Xqt added a comment. In T85271#6610448 , @Homeboy_445 wrote: > Please help me I'm a little confused with this task! I think expanding the doc strings in logging.stdout, error, log, critical, debug and exception will solve it. Use

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. Please help me I'm a little confused with this task! TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Homeboy_445 Cc: Xqt, Homeboy_445, gerritbot, Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. Should I take this task or not? TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Homeboy_445 Cc: Xqt, Homeboy_445, gerritbot, Dvorapa, Urstrulykkr, AbdealiJK,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. @Xqt So do I have to enhance the documentation of pywikibot.logging? If yes, what improvement I shall make? TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Xqt added a comment. @Homeboy_445: pywikibot.logging has several output methods: output(), stdout(), warning(), error(), log(), critical(), debug() and also exception(). The doc strings might be improved, particulary the difference of error() and exception(). All method are similar to the

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Homeboy_445 added a comment. I would like to work on this task. So, would somebody guide me on how to proceed with solving this? TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Homeboy_445 Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. Hi guys, That's so good to hear. I think I will close it. Thanks for the update :) Best, Kaushik. TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. @Aklapper error and exception still need better docs TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Urstrulykkr, Dvorapa Cc: gerritbot, Dvorapa, Urstrulykkr,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Aklapper added a comment. @Urstrulykkr: Thanks for your patch. All Gerrit patches merged, can this task be closed as resolved (you can do that via Add Action... > Change Status in the dropdown menu) or is there more work to do? TASK DETAIL https://phabricator.wikimedia.org/T85271 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. In T85271#4918410, @Urstrulykkr wrote: Hi @Dvorapa Thanks for your patience. Could you please look over my commit ? Your commit was briefly edited and merged, thank you for your struggle with Gerrit and maybe next time!TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

gerritbot added a comment. Change 486715 merged by jenkins-bot: [pywikibot/core@master] Re-added the warning() documentation https://gerrit.wikimedia.org/r/486715TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

gerritbot added a comment. Change 486715 had a related patch set uploaded (by Xqt; owner: Kaushik Reddy): [pywikibot/core@master] Re-added the warning() documentation https://gerrit.wikimedia.org/r/486715TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. There are multiple errors you should fix. I and @valhallasw gave you ideas what to fix there. Also there are errors reported by jenkins bot. We are waiting for your fixes :)TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. Hi @Dvorapa Thanks for your patience. Could you please look over my commit ?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. We reviewed your work there!TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urstrulykkr, DvorapaCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb, valhallasw, Aklapper, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. @valhallasw Sorry for the great delay, I have pushed the code . Would be great if you suggest any changes.TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. @Dvorapa Could you please have a look over my pushed change .TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb, valhallasw,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. I've pushed the changes here: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/486715TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. If any help needed, ask here, in the mailing list or on IRC chatTASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urstrulykkr, DvorapaCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. Thanks @Dvorapa will figure it out on my own.TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb, valhallasw, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. I tried the latter one, but not fruitful. Is there a way to contribute via GitHub?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. Start a new account? Or try the patch uploader I linked to?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urstrulykkr, DvorapaCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb, valhallasw,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. Is there anyway to contribute through GitHub ?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb, valhallasw, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. I'm unable to access /sign into my Gerrit account. Need some help.TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrstrulykkrCc: Dvorapa, Urstrulykkr, AbdealiJK, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Dvorapa added a comment. In T85271#4875696, @Urstrulykkr wrote: I am on it @valhallasw . I have documented the warning( ). Soon will take up the rest non-documented functions. Thanks for reporting. Hello, you made a pull request to GitHub repository mirror. Please see my comment there to make

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

Urstrulykkr added a comment. I am on it @valhallasw . I have documented the warning( ). Soon will take up the rest non-documented functions. Thanks for reporting.TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

valhallasw added a comment. I clearly should have written a better bug report, because I can't reproduce the exact point ;-) This is about the functions 'error' and 'exception' in https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/logging.py. def output documents the meaning of

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

AbdealiJK added a comment. By "document" what do you mean ? Where should this be documented ? What sort of information additionally should be added ?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: