Lokal_Profil added a comment.
@Dalba: You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters? (Note that there are two patches)
My personal opinion is that the separation makes it clearer, makes it easier to convert between the two
Dvorapa created this task.Dvorapa added projects: Pywikibot-Other-scripts, Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONSteps to reproduce:
run add_text.py on a pages from file and filter out some of them with -search
Expected behavior:
Add text.py
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T138765EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, Danny_B, Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89,
Dvorapa created this task.Dvorapa added projects: Pywikibot-core, Pywikibot-Other-scripts.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T155045EMAIL
Dvorapa added a project: Pywikibot-OAuth.
TASK DETAILhttps://phabricator.wikimedia.org/T137520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Tgr, matej_suchanek, Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89,
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T135339EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, valhallasw, Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89,
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T135304EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb,
Dvorapa added a project: Pywikibot-core.Herald added a subscriber: pywikibot-bugs-list.
TASK DETAILhttps://phabricator.wikimedia.org/T136114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: pywikibot-bugs-list, Framawiki, Tgr, matej_suchanek,
Dvorapa removed a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T136114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: pywikibot-bugs-list, Framawiki, Tgr, matej_suchanek, Urbanecm, yuvipanda, Dvorapa, Zppix, Jane023,
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T141024EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, matej_suchanek, Aklapper, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89,
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T139976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: jayvdb, Mpaa, Urbanecm, Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont,
Dvorapa edited the task description. (Show Details)
EDIT DETAILS...Add text.py starts to edit articles, which fullfill search atribute, after pages in file are done, even if they are not in the file.TASK DETAILhttps://phabricator.wikimedia.org/T155050EMAIL
Dvorapa added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T137520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Tgr, matej_suchanek, Aklapper, Zppix, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, MayS, Mdupont, JJMC89,
ReleaseTaggerBot added a project: WMF-deploy-2017-01-17_(1.29.0-wmf.8).
TASK DETAILhttps://phabricator.wikimedia.org/T114318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Dalba, Aschroet, Zdzislaw, AbdealiJK, Ankry, StudiesWorld, GOIII,
Dalba added a comment.
You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters?
Yes.
and keeps it more in line with how Coordinate is handled.
Maybe the entity parameter of Coordinate should also be changed to accept both a URL or
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1per, gerritbotCc: AbdealiJK, gerritbot, Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb,
gerritbot added a comment.
Change 331576 had a related patch set uploaded (by Phantom42):
Added tests for cherry_pick function of diff module
https://gerrit.wikimedia.org/r/331576TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL
gerritbot added a comment.
Change 301924 merged by jenkins-bot:
Adds Page: pages outputted by tag as dependencies of the current page
https://gerrit.wikimedia.org/r/301924TASK DETAILhttps://phabricator.wikimedia.org/T114318EMAIL
Dalba added a comment.
Would it be a bad idea to use unit for passing its URL, too? I find it more intuitive than entity, but it it could be just me not being familiar with wikibase terminology.TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL
gerritbot added a comment.
Change 331396 merged by jenkins-bot:
Replace assertRaises with assertRaisesRegex in ui_options_tests.py
https://gerrit.wikimedia.org/r/331396TASK DETAILhttps://phabricator.wikimedia.org/T154281EMAIL
matej_suchanek removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1per, matej_suchanekCc: AbdealiJK, gerritbot, Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list,
21 matches
Mail list logo