[Pywikipedia-bugs] [Maniphest] [Triaged] T208292: imagecopy fails for a given sample

2018-10-30 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo,

[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError

2018-10-30 Thread Xqt
Xqt added a comment. @Dvorapa: why shouldn't we disable thoses tests temporarily with that patch committed in https://gerrit.wikimedia.org/r/469049? The problem is noted here and it seems not easy to solve. All further travis and appveyor tests are failing now and there is no focus to other tests

[Pywikipedia-bugs] [Maniphest] [Created] T208292: imagecopy fails for a given sample

2018-10-30 Thread Xqt
Xqt created this task.Xqt added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONThere is a sample for this script given in the doc but it fails: C:\pwb\GIT\core>pwb.py imagecopy -newimages:100 Retrieving 49 pages from wikipedia:de.

[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError

2018-10-30 Thread Dvorapa
Dvorapa added a comment. @Xqt I thought Magnus will be faster (he was for the first problem), the test disabling patch would be useless for one day, but now I think we can disable the tests until Magnus will have the time to fix the tool properly.TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample

2018-10-30 Thread Xqt
Xqt added a comment. Hm, this script never worked. Do we need it ;)TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris,

[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError

2018-10-30 Thread gerritbot
gerritbot added a comment. Change 469049 merged by jenkins-bot: [pywikibot/core@master] [test] Temporary accept imagecopy_tests.py failing https://gerrit.wikimedia.org/r/469049TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T208292: imagecopy fails for a given sample

2018-10-30 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420,

[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample

2018-10-30 Thread gerritbot
gerritbot added a comment. Change 470550 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0] https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL

[Pywikipedia-bugs] [Maniphest] [Created] T208303: test_Coordinate_get_globe_item_different_repo is failing

2018-10-30 Thread Dalba
Dalba created this task.Dalba added projects: Pywikibot, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot/jobs/448209151 __ TestWikibaseCoordinateNonDry.test_Coordinate_get_globe_item_different_repo

[Pywikipedia-bugs] [Maniphest] [Updated] T208303: test_Coordinate_get_globe_item_different_repo is failing

2018-10-30 Thread Dalba
Dalba added a project: Pywikibot-Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Closed] T163661: site.messages() gives not the right state

2018-10-30 Thread Xqt
Xqt closed this task as "Resolved".Xqt claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420,

[Pywikipedia-bugs] [Maniphest] [Triaged] T208303: test_Coordinate_get_globe_item_different_repo is failing

2018-10-30 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: matej_suchanek, Lokal_Profil, Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Closed] T208303: test_Coordinate_get_globe_item_different_repo is failing

2018-10-30 Thread Dalba
Dalba closed this task as "Resolved".Dalba assigned this task to matej_suchanek.Dalba added a comment. Thanks, Matěj!TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, DalbaCc: matej_suchanek,

[Pywikipedia-bugs] [Maniphest] [Commented On] T208303: test_Coordinate_get_globe_item_different_repo is failing

2018-10-30 Thread matej_suchanek
matej_suchanek added a comment. There was an error on test.wikidata: https://test.wikidata.org/w/index.php?title=Q123=314870#P10. I restored the earliest revision of the item.TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample

2018-10-30 Thread Multichill
Multichill added a comment. In T208292#4705393, @Xqt wrote: Hm, this script never worked. Do we need it ;) It worked, but someone broke it. Tons of things have changed in the library part, but I don't think impact on the scripts that are using it is noticed enough.TASK

[Pywikipedia-bugs] [Maniphest] [Reassigned] T163661: site.messages() gives not the right state

2018-10-30 Thread Xqt
Xqt reassigned this task from Xqt to matej_suchanek. TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris,

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata

2018-10-30 Thread Framawiki
Framawiki added a subscriber: D3r1ck01.Framawiki added a comment. @D3r1ck01 @Xqt and others: Do you prefer a regex or an index approach here ? The second looks cleaner to me. What about implementing this as a param like withoutDisambiguation in page.title() method? That would allow to easily

[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata

2018-10-30 Thread D3r1ck01
D3r1ck01 added a comment. @Framawiki, if it's per this, https://gerrit.wikimedia.org/r/c/pywikibot/core/+/470627, then I'll say regex solutions become really confusing if they're trying to solve a complex problem hence making it difficult for one to understand a code base if we have many of them.

[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample

2018-10-30 Thread gerritbot
gerritbot added a comment. Change 470550 merged by jenkins-bot: [pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0] https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-10-30 Thread Framawiki
Framawiki added a comment. Will mentor too.TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral,

[Pywikipedia-bugs] [Maniphest] [Edited] T207836: Fix W504 issues across files in the Pywikibot repository

2018-10-30 Thread D3r1ck01
D3r1ck01 updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION/scripts/listpages.py:161:17: W504 line break after binary operator ./scripts/welcome.py:800:31: W504 line break after binary operator ./scripts/nowcommons.py:278:25: W504 line break after binary operator...TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-10-30 Thread D3r1ck01
D3r1ck01 added a comment. @Framawiki, will start creating corresponding GCI tasks for this and will tag us as mentors during the weekend. Thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata

2018-10-30 Thread Xqt
Xqt added a comment. @D3r1ck01 @Xqt and others: Do you prefer a regex or an index approach here ? The second looks cleaner to me. Sorry, I don’t have it. Could you show me the different approach? What about implementing this as a param like withoutDisambiguation in page.title() method? That

[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata

2018-10-30 Thread Shreyasminocha
Shreyasminocha added a comment. @Xyt To clarify, I haven't implemented the second approach. We have two options—the regex-based approach I illustrated or an index-based approach (looping over the characters in the string, looking for an open parenthesis and trimming everything after that or a more

[Pywikipedia-bugs] [Maniphest] [Commented On] T163661: site.messages() gives not the right state

2018-10-30 Thread gerritbot
gerritbot added a comment. Change 469930 merged by jenkins-bot: [pywikibot/core@master] [Bugfix] Check appropriate key in Site.messages https://gerrit.wikimedia.org/r/469930TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T207579: imagecopy_tests failing with IndexError

2018-10-30 Thread Xqt
Xqt removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Wenyi, AndyTan, Zylc,