[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

gerritbot added a comment. Change 599271 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] Rewrite Page.botMayEdit method https://gerrit.wikimedia.org/r/599271 TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Xqt, Dvorapa, JJMC89, Aklapper, russblau, pywikibot-bugs-list, JohnsonLee01,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233406: Refactor Wikibase entities

gerritbot added a comment. Change 599292 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [IMPR] Move latest revision id handling to WikibaseEntity https://gerrit.wikimedia.org/r/599292 TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T233406: Refactor Wikibase entities

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233406 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek, gerritbot Cc: Aklapper, matej_suchanek, pywikibot-bugs-list, JohnsonLee01, Blissjay007,

[Pywikipedia-bugs] [Maniphest] [Commented On] T248914: Information campaign and tech support needed to get Toolforge pywikibot use moved from py2 to py3

Xqt added a comment. In T248914#6168978 , @Xqt wrote: > I would say the next release will be on 1st June which is the last py3 but https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/594106/ should be merged first. The first py3-only

[Pywikipedia-bugs] [Maniphest] [Updated] T139143: Make a pywikibot entry point for scripts

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T139143 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Dvorapa, RhinosF1, Xqt, DrTrigon, jayvdb, pywikibot-bugs-list, Aklapper, Zppix,

[Pywikipedia-bugs] [Maniphest] [Edited] T233406: Refactor Wikibase entities

matej_suchanek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233406 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Aklapper, matej_suchanek, pywikibot-bugs-list, JohnsonLee01, Blissjay007, Dijkstra,

[Pywikipedia-bugs] [Maniphest] [Commented On] T139143: Make a pywikibot entry point for scripts

gerritbot added a comment. Change 560057 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [dist] Add pwb.py wrapper and generate*.py to pywkibot package https://gerrit.wikimedia.org/r/560057 TASK DETAIL https://phabricator.wikimedia.org/T139143 EMAIL

[Pywikipedia-bugs] [Maniphest] [Edited] T234147: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old"

Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T234147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Dvorapa, Xqt, Aklapper, Zoranzoki21, pywikibot-bugs-list, JohnsonLee01, Dijkstra, Zkhalido,

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Dvorapa added a comment. Okay, so I've tried your repo from https://github.com/mineo/pwbtest . I got the same error, but I noticed you use `setup.py develop` which is not a recommended practice afaik. So I've tried `pip install -e .` instead and everything worked like a charm. Using

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Dvorapa added a comment. I still don't know why exactly `pip install -e .` works while `setup.py develop` doesn't. To me those two should work the same, only `setup.py develop` should first determine package manager in use (we use pip & setuptools) and then call its install function.

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

gerritbot added a comment. Change 599345 had a related patch set uploaded (by Huji; owner: Huji): [pywikibot/core@master] Do not exclude userscripts directory from pycodestyles https://gerrit.wikimedia.org/r/599345 TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T253873: pycodestyles does not work inside scripts/userscripts

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Blissjay007, Dijkstra,

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

Dvorapa added a comment. I think it is disabled in tox.ini for purpose. I would not like to have my userscripts analyzed and if I would do, I would update tox.ini for my fork. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Mineo added a comment. Hmm, `pip install -e .` and `flit install -s` work, `python setup.py install` does not work. It ends with the same error ("error: The 'pywikibot==3.0.20200508' distribution was not found and is required by pwbtest"). TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Dvorapa added a comment. See also https://github.com/googleapis/python-api-core/issues/27 TASK DETAIL https://phabricator.wikimedia.org/T253719 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa, Xqt, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts

Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

Dvorapa added a comment. I don't remember why I added those, I have got separate bot and development repositories, so this patch was not for me. Someone must had requested this somewhere, it's a shame I didn't mentioned in the commit message, who came up with that. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

Huji added a comment. Two questions: 1. How is it that tox.in (which is define in the root of the bot) is being observed when I run pycodestyles in a subdirectory? 2. While we can decide which parts of bywikibot code should or should not be excluded from pycodestyles, we cannot choose

[Pywikipedia-bugs] [Maniphest] [Updated] T253873: pycodestyles does not work inside scripts/userscripts

Huji added a comment. @Dvorapa I think you added this back in c1eb7709af0b mainly to make it easier for pywikibot developers (like you and me) to run tests. If so, then the correct way was for you to add a

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Dvorapa added a comment. Yeah, that's expected, setup.py install/develop/build will all have the same problem I think. I honestly don't know, how to fix this as I'm currently outside my PC, unable to create the in-the-middle-of `setup.py develop` conditions to find out, what should setup.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T253719: Pinning pywikibot to 3.0.20200111 doesn't work with setuptools

Mineo added a comment. In T253719#6172489 , @Dvorapa wrote: > Okay, so I've tried your repo from https://github.com/mineo/pwbtest . I got the same error, but I noticed you use `setup.py develop` which is not a recommended practice

[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts

Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Created] T253873: pycodestyles does not work inside scripts/userscripts

Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION If you save a PEP8-uncompliant bot script in `./scripts/userscripts` and run `pycodestyles` on it, you will not get any warnings back. But if you

[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts

Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

Dvorapa added a comment. Anyway I guess you are right, we should not block users flake8, autopep and pycodestyle linters where it is possible they would want to check. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts

Huji added a comment. In other words, I can add a blank `tox.ini` file in `./scripts/userscripts` and that fixes the issue above. However, I think the default should be the other way around: those users who *don't* want this directory to be considered by pycodestyles should add a `tox.ini`

[Pywikipedia-bugs] [Maniphest] [Updated] T253236: Connection timeout errors generate massive traceback from underlying python libraries

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T253236 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: valhallasw, Xqt, Aklapper, pywikibot-bugs-list, Dominicbm, JohnsonLee01,

[Pywikipedia-bugs] [Maniphest] [Claimed] T253873: pycodestyles does not work inside scripts/userscripts

Huji triaged this task as "Medium" priority. Huji claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01,

[Pywikipedia-bugs] [Maniphest] [Commented On] T253591: page generators can truncate responses when there is excessive metadata (e.g. DjVu/PDF files)

Dominicbm added a comment. Update: using the default command, the generator takes a 2-3 hours to complete for this large category. Putting `step` at `1` and it was still unfinished 2 days later when I killed it, so that wasn't really feasible. I can experiment with other lower increments

[Pywikipedia-bugs] [Maniphest] [Commented On] T253236: Connection timeout errors generate massive traceback from underlying python libraries

gerritbot added a comment. Change 598510 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Check for request.status first https://gerrit.wikimedia.org/r/598510 TASK DETAIL https://phabricator.wikimedia.org/T253236 EMAIL PREFERENCES