[Pywikipedia-bugs] [Maniphest] [Commented On] T129186: Threads in intersect_generators() are not killed properly when used in scripts with Bot class

gerritbot added a comment. Change 275718 merged by jenkins-bot: [FIX] intersect_generators must use daemon threads https://gerrit.wikimedia.org/r/275718 TASK DETAIL https://phabricator.wikimedia.org/T129186 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Closed] T76211: pywikibot external pycolorname used by catimages.py

jayvdb closed this task as "Resolved". jayvdb added a comment. Pro-actively closing this as it has achieved the main objective. If there is future work to be done, I think it can happen on the github repo (https://github.com/AbdealiJK/pycolorname) and/or as new Phabricator tasks against

[Pywikipedia-bugs] [Maniphest] [Unblock] T66838: Port catimages.py to core

jayvdb closed blocking task T76211: pywikibot external pycolorname used by catimages.py as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T66838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Vlkyrie, Sumit, DrTrigon,

[Pywikipedia-bugs] [Maniphest] [Edited] T129049: Pywikibot support for Thanks

jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T129049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, darthbhyrava, jayvdb, pywikibot-bugs-list, Manrajsinghgrover, Catrope, Jay8g, Quiddity,

[Pywikipedia-bugs] [Maniphest] [Created] T129193: reimplement imageuncat's -recentchanges as a pagegenerators command line argument

jayvdb created this task. Herald added subscribers: pywikibot-bugs-list, Avicennasis, Aklapper. TASK DESCRIPTION Similar to https://phabricator.wikimedia.org/T67192, but for `-recentchanges` and its `recentChanges` generator. While this is not a one-liner, it is marked as

[Pywikipedia-bugs] [Maniphest] [Commented On] T129186: Threads in intersect_generators() are not killed properly when used in scripts with Bot class

gerritbot added a comment. Change 275718 had a related patch set uploaded (by Mpaa): [FIX] intersect_generators must use daemon threads https://gerrit.wikimedia.org/r/275718 TASK DETAIL https://phabricator.wikimedia.org/T129186 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T129186: Threads in intersect_generators() are not killed properly when used in scripts with Bot class

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T129186 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, pywikibot-bugs-list, Mpaa, Lewizho99

[Pywikipedia-bugs] [Maniphest] [Created] T129186: Threads in intersect_generators() are not killed properly when used in scripts with Bot class

Mpaa created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION With the quit mechanism implemented via QuitKeyboardInterrupt, KeyboardInterrupt is no longer caught in intersect_generators() and scripts based on Bot class hang when using pagegenerators with

[Pywikipedia-bugs] [Maniphest] [Block] T95384: errors in script tests

jayvdb reopened blocking task T128955: script test for featured.py fails as "Open". TASK DETAIL https://phabricator.wikimedia.org/T95384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: pywikibot-bugs-list, jayvdb, Aklapper

[Pywikipedia-bugs] [Maniphest] [Reopened] T128955: script test for featured.py fails

jayvdb reopened this task as "Open". jayvdb added a comment. The regression hasnt been fixed yet. TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, jayvdb Cc: gerritbot, Aklapper, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128955: script test for featured.py fails

gerritbot added a comment. Change 275717 had a related patch set uploaded (by John Vandenberg): Re-add featured script to the auto run list https://gerrit.wikimedia.org/r/275717 TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Closed] T128955: script test for featured.py fails

Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99

[Pywikipedia-bugs] [Maniphest] [Unblock] T95384: errors in script tests

Xqt closed blocking task T128955: script test for featured.py fails as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T95384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: pywikibot-bugs-list, jayvdb, Aklapper

[Pywikipedia-bugs] [Maniphest] [Commented On] T128955: script test for featured.py fails

gerritbot added a comment. Change 275391 merged by jenkins-bot: [bugfix] Enable script_tests for featured.py https://gerrit.wikimedia.org/r/275391 TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

gerritbot added a comment. Change 275511 merged by jenkins-bot: Expand wikistats datatype tests https://gerrit.wikimedia.org/r/275511 TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T128955: script test for featured.py fails

jayvdb added a comment. > featured.py was recently 'archived' in https://phabricator.wikimedia.org/T109210: [RFC] featured.py is outdated for wm projects, but I am not sure if that is the cause. yes, this bug was caused by that, specifically removing 'featured' from the auto run list

[Pywikipedia-bugs] [Maniphest] [Commented On] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

jayvdb added a comment. @valhallasw , isnt this https://github.com/jcgregorio/httplib2/issues/252 ? That is probably bad enough that we need to fix it using a custom version in `externals/` (I have zero faith in the httplilb2 maintainer fixing anything promptly) TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

jayvdb moved this task to Reported Upstream on the Upstream workboard. TASK DETAIL https://phabricator.wikimedia.org/T119855 WORKBOARD https://phabricator.wikimedia.org/project/board/153/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc:

[Pywikipedia-bugs] [Maniphest] [Created] T129170: MediaWiki.org documentation of pagegenerators.py command line arguments is very outdated

jayvdb created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. Herald added a project: Documentation. TASK DESCRIPTION https://www.mediawiki.org/wiki/Manual:Pywikibot/pagegenerators.py is so outdated that it needs to be fixed, somehow. See discussion page. Worst case

[Pywikipedia-bugs] [Maniphest] [Unblock] T68312: Update imageuncat.py to focus on categories

jayvdb closed blocking task T67192: move imageuncat's uploadedYesterday to pagegenerators as "Resolved". Herald added a subscriber: Avicennasis. TASK DETAIL https://phabricator.wikimedia.org/T68312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Closed] T67192: move imageuncat's uploadedYesterday to pagegenerators

jayvdb closed this task as "Resolved". jayvdb added a comment. https://www.mediawiki.org/wiki/Manual:Pywikibot/imageuncat.py needs to be updated TASK DETAIL https://phabricator.wikimedia.org/T67192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Unblock] T60942: Features to move from scripts to framework (tracking)

jayvdb closed blocking task T67192: move imageuncat's uploadedYesterday to pagegenerators as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T60942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: StudiesWorld, Xqt, Multichill,

[Pywikipedia-bugs] [Maniphest] [Unblock] T78452: Use pagegenerators consistently in scripts

jayvdb closed blocking task T67192: move imageuncat's uploadedYesterday to pagegenerators as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T78452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Ricordisamoa, jayvdb, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Edited] T89670: Implement Coordinate.precisionToDim

jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T89670 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, jayvdb Cc: jayvdb, gerritbot, darthbhyrava, Ricordisamoa, pywikibot-bugs-list, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

valhallasw added a comment. Yep, that file should be chmod 644, not 600. You can (probably) fix it by running sudo chmod 644 /Library/Python/2.7/site-packages/httplib2-0.9.2-py2.7.egg/httplib2/cacerts.txt Seems like an issue in httplib2, and I remember reporting it/finding it at

[Pywikipedia-bugs] [Maniphest] [Edited] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

RedWolf edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T119855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: RedWolf Cc: jayvdb, pywikibot-bugs-list, Aklapper, RedWolf, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Edited] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

RedWolf edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T119855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: RedWolf Cc: jayvdb, pywikibot-bugs-list, Aklapper, RedWolf, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Edited] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

RedWolf edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T119855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: RedWolf Cc: jayvdb, pywikibot-bugs-list, Aklapper, RedWolf, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Updated] T128318: No handlers could be found for logger "pywiki"

Lokal_Profil added a comment. Is this the same as https://phabricator.wikimedia.org/T113822 ? TASK DETAIL https://phabricator.wikimedia.org/T128318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. Maybe a hint: class ElementTree(object): def parse(self, source, parser=None): close_source = False if not hasattr(source, "read"): source = open(source, "rb") # <-- ??? close_source = True try: TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. I found the same error with ElementTree instead of cElementTree :( TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: gerritbot, Xqt, Aklapper, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. Additional information about xml.etree: 1. $Id: __init__.py 3375 2008-02-13 08:05:08Z fredrik $ 2. elementtree package TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. my first py version is: '2.7.9 (default, Dec 10 2014, 12:24:55) [MSC v.1500 32 bit (Intel)]' 2nd is: '2.7.10 (default, May 23 2015, 09:44:00) [MSC v.1500 64 bit (AMD64)]' TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. thx for testing this. so the problem is definitely in the xml implementation, but that is a standard module. Appveyor is testing using 2.6.6 (64bit only), 2.7.2 (64bit only) and 2.7.11 (32 and 64bit). If your Python version is different, I can add your

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. Another installation with py 2.7.10 fails too: C:\pwb\core>pwb.py tests/wikistats_tests -v tests: max_retries reduced from 25 to 1 WARNING: WikiStats: unicodecsv package required for using csv in Python 2; falling back to using the larger XML datasets.

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. I haven't unicodecsv installed and csv test is skipped therefore. TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: gerritbot, Xqt, Aklapper, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. C:\pwb\GIT\core>pwb.py tests/wikistats_tests -v tests: max_retries reduced from 25 to 1 WARNING: WikiStats: unicodecsv package required for using csv in Python 2; falling back to using the larger XML datasets. test_csv (__main__.WikiStatsTestCase) Test

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. maybe you have a version of `unicodecsv` that is broken? TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, Xqt, Aklapper, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. All Appveyor windows environments pass these additional `test_xml` asserts. So I dont understand why it is failing for you :/ TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

gerritbot added a comment. Change 275511 had a related patch set uploaded (by John Vandenberg): Expand wikistats datatype tests https://gerrit.wikimedia.org/r/275511 TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T67192: move imageuncat's uploadedYesterday to pagegenerators

gerritbot added a comment. Change 275204 merged by jenkins-bot: imageuncat: Deprecate -yesterday for -logevents https://gerrit.wikimedia.org/r/275204 TASK DETAIL https://phabricator.wikimedia.org/T67192 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Edited] T128981: -logevents command line argument syntax allows specifying limit, however -limit exists for that purpose

jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T128981 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, jayvdb, pywikibot-bugs-list ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. The instance-of bug is quite strange. I've added extra asserts (https://github.com/jayvdb/pywikibot-core/commit/03db2eedd2c60486ef066b94b24f314da1012123), and yet I cant reproduce it on linux (local machine or travis), and on Appveyor the first two builds (Python

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. Got an additional error when testing with current release: C:\pwb\GIT\core>pwb.py tests/wikistats_tests -v tests: max_retries reduced from 25 to 1 WARNING: WikiStats: unicodecsv package required for using csv in Python 2; falli ng back to using the

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. s23.org is outdated for years and wikistats 2.0 has "good" articles as sorting order too.[1] The problem is that statistic content may change and we cannot assume the order is always kept. Maybe we should remove that test expecting a language code on a specific line.

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. In https://phabricator.wikimedia.org/T128990#2093678, @Xqt wrote: > The sorting order of wikistat was always "good" articles as I remember. You may search through the languages_by_size history of wikisource_family. Well, WikiStats lists French Wikisource

[Pywikipedia-bugs] [Maniphest] [Updated] T128453: script_tests fails for editarticle in windows environment

Xqt added a blocked task: T95384: errors in script tests. TASK DETAIL https://phabricator.wikimedia.org/T128453 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Updated] T95384: errors in script tests

Xqt added a blocking task: T128453: script_tests fails for editarticle in windows environment. TASK DETAIL https://phabricator.wikimedia.org/T95384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: pywikibot-bugs-list, jayvdb, Aklapper

[Pywikipedia-bugs] [Maniphest] [Updated] T95384: errors in script tests

Xqt added a blocking task: T128955: script test for featured.py fails. TASK DETAIL https://phabricator.wikimedia.org/T95384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: pywikibot-bugs-list, jayvdb, Aklapper

[Pywikipedia-bugs] [Maniphest] [Claimed] T128955: script test for featured.py fails

Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99 ___

[Pywikipedia-bugs] [Maniphest] [Updated] T128955: script test for featured.py fails

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99

[Pywikipedia-bugs] [Maniphest] [Commented On] T128955: script test for featured.py fails

gerritbot added a comment. Change 275391 had a related patch set uploaded (by Xqt): [bugfix] Enable script_tests for featured.py https://gerrit.wikimedia.org/r/275391 TASK DETAIL https://phabricator.wikimedia.org/T128955 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T76211: pywikibot external pycolorname used by catimages.py

jayvdb added a comment. That is very nice! TASK DETAIL https://phabricator.wikimedia.org/T76211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK, jayvdb Cc: Vlkyrie, DrTrigon, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Anshoe

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. The main thing is the test works, regardless of whether the result is incorrect :P Anyway the related patch waits 5 weeks for reviewing it (and some others too). TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T129059: version.py result is wrongly OUTDATED

Xqt added a comment. Maybe it comes from branches which are on top of master in local repository? But checkout is master! TASK DETAIL https://phabricator.wikimedia.org/T129059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper,

[Pywikipedia-bugs] [Maniphest] [Triaged] T129059: version.py result is wrongly OUTDATED

Xqt triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T129059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Xqt ___

[Pywikipedia-bugs] [Maniphest] [Created] T129059: version.py result is wrongly OUTDATED

Xqt created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION version.py results OUTDATED: C:\pwb\GIT\core>pwb.py version Pywikibot: [ssh] pywikibot-core (9c8e5b4, g7060, 2016/03/06, 06:25:40, OUTDATED) Release version: 3.0-dev

[Pywikipedia-bugs] [Maniphest] [Commented On] T128989: TestLogeventsFactoryGenerator multi event tests failing: 500 not less than or equal to 10

jayvdb added a comment. Probably only occurs if the test account is not a sysop or bot account TASK DETAIL https://phabricator.wikimedia.org/T128989 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Xqt, Aklapper, jayvdb,

[Pywikipedia-bugs] [Maniphest] [Commented On] T128989: TestLogeventsFactoryGenerator multi event tests failing: 500 not less than or equal to 10

Xqt added a comment. Can't reproduce it: C:\pwb\GIT\core>pwb.py tests/pagegenerators_tests -v TestLogeventsFactoryGenerator.test_logevents_default_multi tests: max_retries reduced from 25 to 1 test_logevents_default_multi (__main__.TestLogeventsFactoryGenerator) Test old

[Pywikipedia-bugs] [Maniphest] [Updated] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

jayvdb added a comment. Ah, I see the test was broken by your patch https://phabricator.wikimedia.org/rPWBC9c4732f42f07cca0ed741d0757ffcdd1fdb94d58 , which you +2'd as a trivial change :P TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Xqt, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

gerritbot added a comment. Change 269730 had a related patch set uploaded (by Xqt): [bugfix] top['total'] item is basestring not unicode https://gerrit.wikimedia.org/r/269730 TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128990: WikiStats sorting algorithm causing unexpected largest wikisource

Xqt added a comment. The sorting order of wikistat was always "good" articles as I remember. You may search through the languages_by_size history of wikisource_family. TASK DETAIL https://phabricator.wikimedia.org/T128990 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T128991: test_pagegen_i18n_input failing: setlocale: LC_ALL: cannot change locale (arz): No such file or directory

jayvdb added a comment. Just noting that https://gerrit.wikimedia.org/r/#/c/203963/15 contains a dynamic algorithm for determining the lang & locale for this test. It isnt actually needed for this bug fix, so I am removing it to make the bug fix cleaner and easier to review. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T128991: test_pagegen_i18n_input failing: setlocale: LC_ALL: cannot change locale (arz): No such file or directory

gerritbot added a comment. Change 203963 had a related patch set uploaded (by John Vandenberg): Dynamically determine site for i18n.input test https://gerrit.wikimedia.org/r/203963 TASK DETAIL https://phabricator.wikimedia.org/T128991 EMAIL PREFERENCES