gerritbot added a comment.
Change 407717 merged by jenkins-bot:
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407717TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL
gerritbot added a comment.
Change 407716 merged by jenkins-bot:
[pywikibot/core@master] Add Bengali Authornamespace [100] in wikisource_family.py
https://gerrit.wikimedia.org/r/407716TASK DETAILhttps://phabricator.wikimedia.org/T186341EMAIL
MarcoAurelio added a subscriber: Urbanecm.MarcoAurelio added a comment.
The patch looks good to me now. @Urbanecm can you have a look at it as well? Thanks.TASK DETAILhttps://phabricator.wikimedia.org/T184981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Mpaa added a comment.
Only a workaround has been implemented.
It is good enough IMO to close the bug, even if the philosophical question of what is 'purge' still remains TASK DETAILhttps://phabricator.wikimedia.org/T128994EMAIL
Dalba added a comment.
In T186255#3939172, @Dvorapa wrote:
In these days of 16:9 monitors and 1920x1080 resolutions (usual notebook for everyday use) it is funny to restrict lines to a third of a monitor just to be able to make 3-way comparison? Or why?
The screen resolution of my desktop
Zoranzoki21 added a comment.
Patch is fixed now.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,
gerritbot added a comment.
Change 407716 had a related patch set (by Bodhisattwa) published:
[pywikibot/core@master] Add Bengali Authornamespace [100] in wikisource_family.py
https://gerrit.wikimedia.org/r/407716TASK DETAILhttps://phabricator.wikimedia.org/T186341EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bodhisattwa, gerritbotCc: gerritbot, Aklapper, Bodhisattwa, pywikibot-bugs-list, Adrian1985, Cpaulf30, Baloch007,
gerritbot added a comment.
Change 407717 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407717TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL
Bodhisattwa created this task.Bodhisattwa added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONadd Bengali Authornamespace [100] in wikisource_family.pyTASK DETAILhttps://phabricator.wikimedia.org/T186341EMAIL
Dvorapa added a parent task: T152961: Improve tests suite.
TASK DETAILhttps://phabricator.wikimedia.org/T186323EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dalba, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, rafidaslam, MayS,
Dvorapa added a subtask: T106070: Travis python package caching.
TASK DETAILhttps://phabricator.wikimedia.org/T186323EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dalba, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, Magul, Tbscho, rafidaslam,
Dvorapa added a subtask: T186323: Travis: Major improvement to test time.
TASK DETAILhttps://phabricator.wikimedia.org/T152961EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont,
Dvorapa added a parent task: T186323: Travis: Major improvement to test time.
TASK DETAILhttps://phabricator.wikimedia.org/T106070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, DvorapaCc: TerraCodes, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007,
gerritbot added a comment.
Change 407631 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407631TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL
Dvorapa added a comment.
:facepalm:TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis,
Dalba added a comment.
The first argument of pywikibot.Link should be text. The second argument is the source.TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dvorapa, Aklapper, pywikibot-bugs-list,
Dvorapa added a comment.
It seems to me as if unittest correctly handles family and code into correct Site object (line 25 is OK), but DisambiguationRobot or get_disambiguation_links breaks Site or redefine Site not correctly somehow.TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL
Dvorapa added a comment.
Well, it should be.. https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/scripts/solve_disambiguation.py;20f5463cd2fed1d99fab88fd391940a3e0695d00$674TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL
Dvorapa added a comment.
The site should be crated by the DisambiguationRobot initializer. Is it?TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Dalba,
Dvorapa added a comment.
Why self.site isn't a Site object? unittest library in Python is sometimes so unintuitive..TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper,
Dvorapa added a subtask: T186316: solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object.
TASK DETAILhttps://phabricator.wikimedia.org/T118719EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Dalba renamed this task from "Travis builds are failing with AssertionError: source parameter should be either a Site or Page object" to "solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object".
TASK
Dalba created this task.Dalba added projects: Pywikibot-core, Pywikibot-tests.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot/jobs/336514923#L4758
==
FAIL:
Dalba triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis,
Jayprakash12345 added a comment.
I am happy to mentor you at MediaWiki Traning 2018.TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bodhisattwa, Jayprakash12345Cc: Jayprakash12345, gerritbot, Aklapper,
Jayprakash12345 closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bodhisattwa, Jayprakash12345Cc: gerritbot, Aklapper, Bodhisattwa, pywikibot-bugs-list, Adrian1985, Cpaulf30,
gerritbot added a comment.
Change 407624 merged by jenkins-bot:
[pywikibot/core@master] Add Bengali Template:Category redirect in wikipedia_family.py
https://gerrit.wikimedia.org/r/407624TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL
gerritbot added a comment.
Change 372064 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Exclude links in disambiguation templates from possibilities
https://gerrit.wikimedia.org/r/372064TASK DETAILhttps://phabricator.wikimedia.org/T118719EMAIL
gerritbot added a comment.
Change 407624 had a related patch set (by Bodhisattwa) published:
[pywikibot/core@master] Add Bengali Template:Category redirect in wikipedia_family.py
https://gerrit.wikimedia.org/r/407624TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL
Bodhisattwa triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BodhisattwaCc: Aklapper, Bodhisattwa, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89,
Bodhisattwa created this task.Bodhisattwa added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONBengali template = টেমপ্লেট:বিষয়শ্রেণী পুনর্নির্দেশTASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bodhisattwa, gerritbotCc: gerritbot, Aklapper, Bodhisattwa, pywikibot-bugs-list, Adrian1985, Cpaulf30, Baloch007,
Xqt added a project: Toolforge.
TASK DETAILhttps://phabricator.wikimedia.org/T184713EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dalba, Petrb, gerritbot, Framawiki, zhuyifei1999, Ottomata, Aklapper, Xqt, pywikibot-bugs-list, Adrian1985, Cpaulf30,
Xqt added a comment.
Sure but urls are ignored by that rule for good reasons.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,
matej_suchanek added a project: Pywikibot-Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T168210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Multichill, matej_suchanek, Aklapper, valhallasw, pywikibot-bugs-list, Magul, Tbscho,
gerritbot added a comment.
Change 407590 merged by jenkins-bot:
[pywikibot/core@master] diff_checker.py: Decode tokenizer strings using 'utf-8' encoding on Python 2
https://gerrit.wikimedia.org/r/407590TASK DETAILhttps://phabricator.wikimedia.org/T186301EMAIL
Xqt added a comment.
@Dalba: It is required to use EventStreams after the last change on server side. I checked every release of requests and sseclient to find the right combination. Anyway it the requests < 2.9 the framework can be used except of EventStreams which either finds empty messages or
Xqt closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T186301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Adrian1985, Cpaulf30, Baloch007,
gerritbot added a comment.
Change 407590 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] diff_checker.py: Open files with 'utf-8' encoding
https://gerrit.wikimedia.org/r/407590TASK DETAILhttps://phabricator.wikimedia.org/T186301EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, gerritbotCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Adrian1985, Cpaulf30,
42 matches
Mail list logo