date:20210501

[Pywikipedia-bugs] [Maniphest] [Created] T281633: [dev] pre-commit for linting and code formatting

2021-05-01 Thread JJMC89

JJMC89 created this task.
JJMC89 added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  I suggest moving Pywikibot's linters/code formatters to pre-commit 
.
  
  https://gerrit.wikimedia.org/r/c/pywikibot/core/+/684050 is a proof of 
concept patch.
  
git-review -d 684050# checkout the POC patch

pip install pre-commit  # Install pre-commit
pre-commit install  # Install pre-commit's pre-commit hook
git commit ...  # pre-commit will run on the files changed
pre-commit uninstall# Unnstall pre-commit's pre-commit hook

pre-commit run --all-files  # Run pre-commit on all files
  
  Please take a look and share your thoughts about using pre-commit in 
Pywikibot development.

TASK DETAIL
  https://phabricator.wikimedia.org/T281633

WORKBOARD
  https://phabricator.wikimedia.org/project/board/87/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JJMC89
Cc: Aklapper, pywikibot-bugs-list, JJMC89, Shalomori123, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T166950: Reduce the number of stylistic checks

2021-05-01 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T166950

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dalba, Dvorapa, gerritbot, darthbhyrava, Lokal_Profil, Framawiki, jayvdb, 
zhuyifei1999, Multichill, Xqt, Aklapper, valhallasw, pywikibot-bugs-list, 
Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T166950: Reduce the number of stylistic checks

2021-05-01 Thread gerritbot

gerritbot added a comment.


  Change 684017 had a related patch set uploaded (by Xqt; author: Xqt):
  
  [pywikibot/core@master] [tests] remove isort from tests
  
  https://gerrit.wikimedia.org/r/684017

TASK DETAIL
  https://phabricator.wikimedia.org/T166950

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dalba, Dvorapa, gerritbot, darthbhyrava, Lokal_Profil, Framawiki, jayvdb, 
zhuyifei1999, Multichill, Xqt, Aklapper, valhallasw, pywikibot-bugs-list, 
Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, 
mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread Dvorapa

Dvorapa added a comment.


  Yeah, when I run `python pwb.py generate_user_files` locally, it breaks on 
the same issue:
  
$ python pwb.py generate_user_files
Traceback (most recent call last):
  File "/home/pavel/pywikibot5/pwb.py", line 199, in 
import pywikibot as pwb
  File "/home/pavel/pywikibot5/pywikibot/__init__.py", line 22, in 
from pywikibot import config as _config
  File "/home/pavel/pywikibot5/pywikibot/config.py", line 380, in 
base_dir = get_base_dir()
  File "/home/pavel/pywikibot5/pywikibot/config.py", line 371, in 
get_base_dir
raise RuntimeError(exc_text)
RuntimeError: No user-config.py found in directory '/home/pavel/pywikibot5'.
  Please check that user-config.py is stored in the correct location.
  Directory where user-config.py is searched is determined as follows:

Return the directory in which user-specific information is stored.

This is determined in the following order:
 1.  If the script was called with a -dir: argument, use the directory
 provided in this argument.
 2.  If the user has a PYWIKIBOT_DIR environment variable, use the value
 of it.
 3.  If user-config is present in current directory, use the current
 directory.
 4.  If user-config is present in pwb.py directory, use that directory
 5.  Use (and if necessary create) a 'pywikibot' folder under
 'Application Data' or 'AppData\Roaming' (Windows) or
 '.pywikibot' directory (Unix and similar) under the user's home
 directory.

Set PYWIKIBOT_NO_USER_CONFIG=1 to disable loading user-config.py or
install pywikibot as a site-package.

@param test_directory: Assume that a user config file exists in this
directory. Used to test whether placing a user config file in this
directory will cause it to be selected as the base directory.


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/pavel/pywikibot5/pwb.py", line 202, in 
import pywikibot as pwb
  File "/home/pavel/pywikibot5/pywikibot/__init__.py", line 36, in 
from pywikibot.bot import (
  File "/home/pavel/pywikibot5/pywikibot/bot.py", line 105, in 
from pywikibot import config, daemonize, i18n, version
  File "/home/pavel/pywikibot5/pywikibot/i18n.py", line 864, in 
TranslationError = pywikibot.exceptions.TranslationError
AttributeError: partially initialized module 'pywikibot' has no attribute 
'exceptions' (most likely due to a circular import)

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, Dvorapa
Cc: Dvorapa, JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread gerritbot

gerritbot added a comment.


  Change 684014 had a related patch set uploaded (by Xqt; author: Xqt):
  
  [pywikibot/core@master] [bugfix] Solve circular import if user-config.p is 
missing
  
  https://gerrit.wikimedia.org/r/684014

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread Xqt

Xqt claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread Xqt

Xqt added a comment.


  Ah, I see. The tests passes but the scripts itself fails. Thank you @JJMC89.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread JJMC89

JJMC89 added a comment.


  In T281551#7050517 , @Xqt 
wrote:
  
  > May be a reason to fail for that special test but why does the most test 
pass but Travis always return 1
  
  Since that (or any) command in script fails (returned 1), the build fails 
(returned 1).
  
  https://docs.travis-ci.com/user/job-lifecycle#breaking-the-build:
  If script returns a non-zero exit code, the build is failed, but continues to 
run before being marked as failed.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JJMC89
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread Xqt

Xqt added a comment.


  In T281551#7050454 , 
@JJMC89 wrote:
  
  > Since rPWBCcf630158c523: [cleanup] Suffix exceptions with 'Error' 

  >
  >   The command "python pwb.py generate_family_file 
'https://wiki.musicbrainz.org/' musicbrainz 'n'" exited with 1.
  
  May be a reason to fail for that special test but why does the most test pass 
but Travis always return 1

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281200: Clean up tools classes

2021-05-01 Thread gerritbot

gerritbot added a comment.


  Change 681194 **merged** by jenkins-bot:
  
  [pywikibot/core@master] [cleanup] Deprecate regex classes
  
  https://gerrit.wikimedia.org/r/681194

TASK DETAIL
  https://phabricator.wikimedia.org/T281200

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Lalamarie69, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, 
Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, 
JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread Xqt

Xqt added a comment.


  It is Travis which forces always to fail.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T281551: All Travis CI tests fails due to unknown reasons

2021-05-01 Thread JJMC89

JJMC89 added subscribers: atagar, JJMC89.
JJMC89 added a comment.


  Since rPWBCcf630158c523: [cleanup] Suffix exceptions with 'Error' 

  
The command "python pwb.py generate_family_file 
'https://wiki.musicbrainz.org/' musicbrainz 'n'" exited with 1.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JJMC89
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T281551: Travis CI tests failing due to missing user-config.py

2021-05-01 Thread JJMC89

JJMC89 renamed this task from "All Travis CI tests fails due to unknown 
reasons" to "Travis CI tests failing due to missing user-config.py".
JJMC89 updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JJMC89
Cc: JJMC89, atagar, Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, 
pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, 
Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: All Travis CI tests fails due to unknown reasons

2021-05-01 Thread Xqt

Xqt added a comment.


  https://docs.travis-ci.com/user/job-lifecycle#complex-build-commands:
  //The exit code of after_success, after_failure, after_script, after_deploy 
and subsequent stages do not affect the build result. However, if one of these 
stages times out, the build is marked as failed.//
  but it fails anyway in that section; strange.

TASK DETAIL
  https://phabricator.wikimedia.org/T281551

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Ladsgroup, Legoktm, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, 
Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T281633: [dev] pre-commit for linting and code formatting

[Pywikipedia-bugs] [Maniphest] [Updated] T166950: Reduce the number of stylistic checks

[Pywikipedia-bugs] [Maniphest] [Commented On] T166950: Reduce the number of stylistic checks

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Updated] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Claimed] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281200: Clean up tools classes

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Updated] T281551: All Travis CI tests fails due to unknown reasons

[Pywikipedia-bugs] [Maniphest] [Retitled] T281551: Travis CI tests failing due to missing user-config.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T281551: All Travis CI tests fails due to unknown reasons

15 matches

Site Navigation

Mail list logo

Footer information