zhuyifei1999 added a comment.
> I think the bottom line here is that the pywikibot system as a whole
depends too much on external resources (such as user-config.py) which makes the
test suite fragile. There really needs to be a way for the test framework to
supply a complete configurat
zhuyifei1999 added a comment.
(trying to reproduce it again)
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Count_Count, Dvorapa, zhuyifei1999, TheSandDoctor, Mpaa, Aklapper
zhuyifei1999 added a comment.
Sorry, I think I was working on it last year and then forgot about this
ticket. I'll check what I was doing back then.
Is this bug still reproducible?
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https
zhuyifei1999 added a comment.
How it finds whether you can delete:
https://github.com/wikimedia/pywikibot/blob/595b2497374e40a990303afc75672144ab18ae5f/pywikibot/page/__init__.py#L1746:
self.site.has_right('delete')
which expands to
https://github.com/wikimedia/pywikibot/blob
zhuyifei1999 added a comment.
In T283957#7123071 <https://phabricator.wikimedia.org/T283957#7123071>, @Xqt
wrote:
> @zhuyifei1999: what is your Python version running?
>
> See also https://bugs.python.org/issue19859
Python 3.5.3 on Toolforge (where it used 4G
zhuyifei1999 created this task.
zhuyifei1999 added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION
BasePage.botMayEdit is annotated with `@cache`
@cache
def botMayEdit(self) -> bool:
This is an unbounded strong
zhuyifei1999 removed zhuyifei1999 as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T133443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: gerritbot, zhuyifei1999, Aklapper, Avicennasis, pywikibot-bugs-list
zhuyifei1999 removed zhuyifei1999 as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T129216
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Dominicbm, Jeff_G, Fae, gerritbot, XZise, Aklapper, Steinsplitter
zhuyifei1999 added a comment.
We can
- cls.__new__ = staticmethod(lambda cls: cls.instance) # shortcut
+ cls.__new__ = lambda cls: cls.instance
- cls.__init__ = deprecated(cls.__dict__['__init__'])
+ cls.__init__ = deprecated(cls.__init__)
TASK DETAIL
https
zhuyifei1999 closed this task as "Invalid".
zhuyifei1999 added a comment.
Memory issues are environmental. They are not actionable unless a. there is a
memory leak or b. there is a significant memory use inefficiency.
TASK DETAIL
https://phabricator.wikimedia.org/T260831
EMAIL P
zhuyifei1999 closed this task as "Declined".
zhuyifei1999 added a comment.
This is an instance of cyclic reference. The frame refers to the entry, the
entry has _getexception, the exception refers to the frame. The exception would
also definitely reference the inner frame where the
zhuyifei1999 added a comment.
Using [[github.com/zhuyifei1999/guppy3|guppy]] to traverse the reference
graph:
import osmium, pywikibot
import guppy
en_wiki = pywikibot.Site("en", "wikipedia")
thisframe = []
class TestHandler(osmium.SimpleHandle
zhuyifei1999 added a comment.
Ah I see what is happening.
With diff:
diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index 7e01efe83..96cbc887c 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -783,6 +783,7 @@ def handle_args(args=None, do_help=True
zhuyifei1999 added a comment.
I remember debug log logs to a file. Do you have some steps to reproduce this?
TASK DETAIL
https://phabricator.wikimedia.org/T261063
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: zhuyifei1999
zhuyifei1999 added a comment.
Or just host such a server. ;)
TASK DETAIL
https://phabricator.wikimedia.org/T257559
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt, zhuyifei1999
Cc: zhuyifei1999, Dvorapa, Aklapper, pywikibot-bugs-list, Xqt
zhuyifei1999 added a comment.
In T228322#5344565 <https://phabricator.wikimedia.org/T228322#5344565>, @Xqt
wrote:
> lang property must be resolved from siteinfo whereas code property is
already given when instantiating the site object
zhuyifei1999 added a comment.
P11763 (An Untitled Masterwork) <https://phabricator.wikimedia.org/P11763>
TASK DETAIL
https://phabricator.wikimedia.org/T228322
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: zhuyifei1999, D
zhuyifei1999 added a comment.
In T171886#6284238 <https://phabricator.wikimedia.org/T171886#6284238>,
@Seppl2013 wrote:
> Please reopen this issue - marking it invalid since it's not reproducible
in the Wikimedia Universe is not helpful for those having the problem in t
zhuyifei1999 added a comment.
In T171886#6284149 <https://phabricator.wikimedia.org/T171886#6284149>, @Xqt
wrote:
> Installation was done as I said
That was responding to @JJMC89 quoting your message. Sorry if unclear.
TASK DETAIL
https://phabricator.wikimedia.org/T1718
zhuyifei1999 added a comment.
Also, see above,
In T171886#6279580 <https://phabricator.wikimedia.org/T171886#6279580>, @Xqt
wrote:
> I installed pywikibot with `-v` verbose and got the same fatal error but
pywikibot was installed anyway:
Are you sure in your outp
zhuyifei1999 added a comment.
In T171886#6283074 <https://phabricator.wikimedia.org/T171886#6283074>,
@JJMC89 wrote:
> The paste? If so, you should be able to access it now.
What is the repository and the travis.yml? Again, insufficient information
has been given to
zhuyifei1999 added a comment.
In T171886#6282167 <https://phabricator.wikimedia.org/T171886#6282167>,
@JJMC89 wrote:
> I've seen this fatal in multiple repositories installing pywikibot
3.0.20200703 via PyPI with Python 3.5-3.10a on xenial (Travis CI)
>
> {P11754}
zhuyifei1999 closed this task as "Invalid".
zhuyifei1999 added a comment.
Cannot reproduce on Ubuntu 18.04 LTS docker image.
P11743 (An Untitled Masterwork) <https://phabricator.wikimedia.org/P11743>
Closing. Reopen only if you are able to provide a steps
zhuyifei1999 added a comment.
You can refer them to this ticket if needed.
TASK DETAIL
https://phabricator.wikimedia.org/T249114
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: herron, aborrero, Ladsgroup, bd808, zhuyifei1999
zhuyifei1999 added a comment.
It seems normal for AWS server to have that sort of FQDN internally. This is
one of my AWS servers I sometimes test stuffs on:
[ec2-user@ip-172-31-3-[...] ~]$ hostname -f
ip-172-31-3-[...].us-east-2.compute.internal
Whoever maintains kernel wiki
zhuyifei1999 added a comment.
2020-05-10 08:22:46 H=ec2-34-211-101-61.us-west-2.compute.amazonaws.com
(ip-10-30-118-124.us-west-2.compute.internal) [34.211.101.61] Warning: Sender
address web...@ip-10-30-118-124.us-west-2.compute.internal has exceeded rate
limit of messages per 1h
zhuyifei1999 added a comment.
Same thing as T249114#6073998
<https://phabricator.wikimedia.org/T249114#6073998>:
09:09:37 0 ✓ zhuyifei1999@tools-mail-02: ~$ sudo less
/var/log/exim4/mainlog | grep pywikibot
2020-05-10 08:22:46 H=ec2-34-211-101-61.us-west-2.compute.amazona
zhuyifei1999 renamed this task from "Update Pywikibot to the most recent
version" to "Pywikibot on PAWS is not getting updates to latest stable".
TASK DETAIL
https://phabricator.wikimedia.org/T252290
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/pa
zhuyifei1999 closed this task as "Resolved".
zhuyifei1999 claimed this task.
zhuyifei1999 added a comment.
PR, https://github.com/toolforge/paws/pull/47 self-merged.
I tested and seems to work, resolving. Reopen if not.
TASK DETAIL
https://phabricator.wikimedia.org/T252
zhuyifei1999 added a comment.
In T252290#6121258 <https://phabricator.wikimedia.org/T252290#6121258>, @Xqt
wrote:
> See T217908 <https://phabricator.wikimedia.org/T217908> and I propose to
decline this request. The stable tag should be used by default. The
zhuyifei1999 added a comment.
https://github.com/toolforge/paws/blob/9f524591cf7cc72ff9e10212f07023ee28618347/paws/values.yaml#L133
This needs fixing
This is so convoluted.
TASK DETAIL
https://phabricator.wikimedia.org/T252290
EMAIL PREFERENCES
https://phabricator.wikimedia.org
zhuyifei1999 added a comment.
It's pinned to the stable tag.
https://github.com/toolforge/paws/blob/f0362dfe2899ab00d0e8870b8967f942368a6874/images/singleuser/Dockerfile#L125
I need to figure out how to update the docker image.
TASK DETAIL
https://phabricator.wikimedia.org/T252290
zhuyifei1999 closed this task as "Invalid".
TASK DETAIL
https://phabricator.wikimedia.org/T250939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: AntiCompositeNumber, Bugreporter, Xqt, Dvorapa, Aklapper, Bdijkstra,
pywi
zhuyifei1999 added a comment.
01:37:33 0 ✓ zhuyifei1999@tools-mail-02: ~$ sudo less
/var/log/exim4/mainlog | grep pywikibot
2020-04-20 15:24:48 H=ec2-34-211-101-61.us-west-2.compute.amazonaws.com
(ip-10-30-118-118.us-west-2.compute.internal) [34.211.101.61]
X=TLS1.2
zhuyifei1999 added a comment.
In T249114#6073828 <https://phabricator.wikimedia.org/T249114#6073828>,
@Dvorapa wrote:
> @zhuyifei1999 Could you once more look for any message(s) from kernel.org?
(T245350#6043128 <https://phabricator.wikimedia.org/T245350#6043128>)
zhuyifei1999 added a comment.
Forwarded
TASK DETAIL
https://phabricator.wikimedia.org/T249114
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Ladsgroup, bd808, zhuyifei1999, Xqt, pywikibot-bugs-list, Aklapper,
Dvorapa, Zkhalido
zhuyifei1999 added a comment.
I can forward them when I wake up.
TASK DETAIL
https://phabricator.wikimedia.org/T249114
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Ladsgroup, bd808, zhuyifei1999, Xqt, pywikibot-bugs-list
zhuyifei1999 added a comment.
@Dvorapa I got the verify mail, I can PM you the link on IRC if you want.
TASK DETAIL
https://phabricator.wikimedia.org/T249114
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: bd808, zhuyifei1999
zhuyifei1999 renamed this task from "E-mails from nore...@pypi.org are not
delivered to tools.pywiki...@tools.wmflabs.org for more than a year" to
"E-mails from nore...@pypi.org to tools.pywiki...@tools.wmflabs.org are not
forwarded to certain recipients due to SPF".
zhuyifei1999 added a comment.
`sudo less /var/log/exim4/mainlog | grep pywikibot`:
2020-04-01 12:02:28 1jJc4g-0002aF-7I ** [xqt email]
R=dnslookup T=remote_smtp H=[REDACTED]
X=TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256 CV=no: SMTP error from remote mail
server after pipelined MAIL
zhuyifei1999 reopened this task as "Open".
zhuyifei1999 claimed this task.
zhuyifei1999 added a comment.
Sorry, was extremely busy last two weeks. I think if it's a bug it should
stay open. I'll work on it next week.
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL P
zhuyifei1999 added a comment.
Whichever is simplest.
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dvorapa, zhuyifei1999
Cc: Count_Count, Dvorapa, zhuyifei1999, TheSandDoctor, Mpaa, Aklapper
zhuyifei1999 added a project: Upstream.
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dvorapa, zhuyifei1999
Cc: Count_Count, Dvorapa, zhuyifei1999, TheSandDoctor, Mpaa, Aklapper,
pywikibot-bugs
zhuyifei1999 added a comment.
I will be running the script with pdb + save all sseclient trace over the
weekend.
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dvorapa, zhuyifei1999
Cc
zhuyifei1999 added a comment.
Yes, what I was saying was, the first and the third and two separate
consumers, so events on first should also be received on the third. If there
were something fundamentally wrong with the event data, then both would crash.
Since this is not the case
zhuyifei1999 added a comment.
In T181443#5916753 <https://phabricator.wikimedia.org/T181443#5916753>,
@TheSandDoctor wrote:
> @zhuyifei1999 the first and second traceback are from "production" worker
instances and pop items off of the same redis queue (all fed by
zhuyifei1999 added a subscriber: Count_Count.
zhuyifei1999 added a comment.
So while the event data are loaded from json
<https://github.com/wikimedia/pywikibot/blob/34bf10f585ba8ca8e24c8d317686c3694c17d6e6/pywikibot/comms/eventstreams.py#L312>,
hex escaping non-acsii are op
zhuyifei1999 added a comment.
In T181443#5916068 <https://phabricator.wikimedia.org/T181443#5916068>,
@TheSandDoctor wrote:
> The first traceback above
> 2020-02-22 20:02:09 <- start
> 2020-02-24 08:42:16 <- crash
> The second traceback I posted above
zhuyifei1999 added a comment.
Would you mind posting the code of the 'minimal test case' somewhere?
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dvorapa, zhuyifei1999
Cc: Dvorapa
zhuyifei1999 added a comment.
> rcworker.py would just be reduced to a few lines
Is redis queue critical to reproducing the issue? If not, that is an extra
layer of complexity and a minimal reproducible test case does not need that.
TASK DETAIL
https://phabricator.wikimedia.
zhuyifei1999 added a comment.
What is the traceback?
Any minimal reproducible test case (even if it takes a long time to reproduce
that's still something)?
TASK DETAIL
https://phabricator.wikimedia.org/T181443
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
zhuyifei1999 added a comment.
(idc)
TASK DETAIL
https://phabricator.wikimedia.org/T245209
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Xqt, Dvorapa, Aklapper, zhuyifei1999, pywikibot-bugs-list, Framawiki,
Zkhalido, Viztor
zhuyifei1999 added a comment.
Yeah thanks. I 'fixed' it by deleting apicache directory
TASK DETAIL
https://phabricator.wikimedia.org/T245487
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Zoranzoki21, Aklapper, pywikibot-bugs
zhuyifei1999 closed this task as "Invalid".
zhuyifei1999 added a comment.
Restricted Application removed a subscriber: Liuxinyu970226.
Looks like API cache have the namespace dict.
TASK DETAIL
https://phabricator.wikimedia.org/T245487
EMAIL PREFERENCES
https://phabricator.wik
zhuyifei1999 added a comment.
Looks like the localization of namepace names is broken:
>>> pywikibot.Page(pywikibot.Site('mk', 'wikipedia'),
'Предлошка:ABCD').namespace()
Namespace(id=0, custom_name='', canonical_name='', aliases=[],
case='first-letter', con
zhuyifei1999 created this task.
zhuyifei1999 added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Liuxinyu970226,
Aklapper.
TASK DESCRIPTION
$ /data/project/shared/pywikipedia/core/pwb.py shell
Welcome to the Pywikibot interactive shell
zhuyifei1999 added a comment.
https://github.com/pywikibot/Pywikibot-nightly-creator/commit/f97f3901fb79a13967b04896005b344ffc8a36a5
?
TASK DETAIL
https://phabricator.wikimedia.org/T245209
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
zhuyifei1999 added a comment.
I think too long is fine because it will soon be unsupported. Annoyance is
sometimes a good thing :)
In any case, you have write access to that directory right?
TASK DETAIL
https://phabricator.wikimedia.org/T245209
EMAIL PREFERENCES
https
zhuyifei1999 closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T235768
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gbenson, zhuyifei1999
Cc: A2093064, zhuyifei1999, Dvorapa, Aklapper, gbenson, pywikibot
zhuyifei1999 closed this task as "Resolved".
zhuyifei1999 added a comment.
https://travis-ci.org/wikimedia/pywikibot/jobs/597288441
TASK DETAIL
https://phabricator.wikimedia.org/T235320
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
zhuyifei1999 added a comment.
This is assuming the default family/lang is Commons. The same applies to any
other site if the parameters passed to the Site constructor matches any case
given to the `usernames` dict.
`del usernames['commons']`:
>>> pywikibot.Site()
zhuyifei1999 added a comment.
In T71283#5446694 <https://phabricator.wikimedia.org/T71283#5446694>,
@Urbanecm wrote:
> True that, it can be just one username per site, the preferred one? But
listing that usernames can be actually useful as a safeguard, to not allow an
userna
zhuyifei1999 added a comment.
In T71283#5446611 <https://phabricator.wikimedia.org/T71283#5446611>,
@Dvorapa wrote:
> BTW Pywikibot tests miss the way to simply switch between several accounts
(OAuth, BotPasswords, regular password) as well.
The login manager is too stat
zhuyifei1999 added a comment.
In T71283#5446608 <https://phabricator.wikimedia.org/T71283#5446608>,
@Urbanecm wrote:
> name=user-config.py
> accounts = {
> "oznamovatel": {
> "username": "Oznamovatel",
>
zhuyifei1999 added a comment.
In T71283#5446512 <https://phabricator.wikimedia.org/T71283#5446512>,
@Dvorapa wrote:
> This is quite common situation on Czech Wikipedia, one bot account and one
sysop account for every sysop bot operator, edits by Pywikibot are made from
eac
zhuyifei1999 added a comment.
In T71283#5443879 <https://phabricator.wikimedia.org/T71283#5443879>,
@Dvorapa wrote:
> The only thing needed is to support specifying two accounts, one bot, one
sysop and allow to switch between them easily (by a parameter?)
This violates
zhuyifei1999 added a comment.
In T71283#5441831 <https://phabricator.wikimedia.org/T71283#5441831>, @Huji
wrote:
> At this point, all that would be left to be done is to devise a strategy
for those who need to use different accounts on different wikis (or different
zhuyifei1999 added a comment.
config2.py needs to emit a warning that sysopnames don't work anymore (if we
decide to just break it)
TASK DETAIL
https://phabricator.wikimedia.org/T71283
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
zhuyifei1999 added a comment.
I don't remember what was the proposed solution at the meetup (maybe branch
or tags, but no memory of creating a new repo at all), but the problem was
discussed AFAICR. You also have to account for that at the meetup there are
many of those who are just 'using
zhuyifei1999 added a comment.
pwbc... pywikibot core; pwbd... pywikibot... daemon?
TASK DETAIL
https://phabricator.wikimedia.org/T226507
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: matej_suchanek, Frettie, Geertivp
zhuyifei1999 added a comment.
k. I'll be there
TASK DETAIL
https://phabricator.wikimedia.org/T221801
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Andrawaag, Geertivp, Frettie, Jayprakash12345, valhallasw, Ladsgroup
zhuyifei1999 added a comment.
You mean 3PM? Sure. Where though?
TASK DETAIL
https://phabricator.wikimedia.org/T221801
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Andrawaag, Geertivp, Frettie, Jayprakash12345, valhallasw
zhuyifei1999 added a comment.
No, the title was 'fixed', but is reopened for a (partial) revert afaict.
TASK DETAIL
https://phabricator.wikimedia.org/T184712
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: zhuyifei1999, Dvorapa
zhuyifei1999 added a comment.
Anyone at the bar?
TASK DETAIL
https://phabricator.wikimedia.org/T221801
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: Geertivp, Frettie, Jayprakash12345, valhallasw, Ladsgroup, Chicocvenancio
zhuyifei1999 added a comment.
In T192733#5174491 <https://phabricator.wikimedia.org/T192733#5174491>,
@Dvorapa wrote:
> Some people perhaps add it to PATH in their .profile etc.
Depending on how people did this, there are
- .profile
- .bash_profile
zhuyifei1999 added a comment.
If we really want to move forward with this task, how about this?
- Send a mail to lists pywikibot, cloud, cloud-announce (somehow get approved
for this). With an explicit date that the symlinks will be removed.
- A week before the date of removal
zhuyifei1999 added a comment.
> solve sysop dualism
I will also be there
TASK DETAIL
https://phabricator.wikimedia.org/T221801
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: zhuyifei1999, Xqt, Aklapper, pywikibot-bugs-l
zhuyifei1999 added a comment.
> $(git tag | tail -1)
Need repo cloned. Seperate into two commands?
TASK DETAIL
https://phabricator.wikimedia.org/T217908
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt, zhuyifei1999
Cc: zhuyifei1
zhuyifei1999 added a comment.
Historically, CI was insecure. The ability to run full tests means that you
can run arbitrary code on it, and historically CI test runners were not as
'isolated' as they currently are, so you had all sorts of opportunities to
hijack the CI servers
zhuyifei1999 added a comment.
In T134495#4986303 <https://phabricator.wikimedia.org/T134495#4986303>,
@Dvorapa wrote:
> both pretty good
both interior to the other in some aspects.
> https://wikitech.wikimedia.org/wiki/Help:Toolforge/Pywikibot
zhuyifei1999 added a comment.
In T216741#4973335 <https://phabricator.wikimedia.org/T216741#4973335>,
@bd808 wrote:
> Is
https://wikitech.wikimedia.org/wiki/Help:Toolforge/My_first_Flask_OAuth_tool a
bad tutorial in your opinion, or just not relevant to your particula
zhuyifei1999 added a comment.
The fix was
https://github.com/PyMySQL/PyMySQL/commit/0e01158fb8a204144c5ae983bea2b3e4ff93,
part of v0.7.11 release.
TASK DETAIL
https://phabricator.wikimedia.org/T216741
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
zhuyifei1999 added a comment.
In T216741#4973067 <https://phabricator.wikimedia.org/T216741#4973067>,
@zhuyifei1999 wrote:
> If close happened due to 'MySQL server has gone away', we should have
received a `OperationalError`.
This was nullified by `except Exceptio
zhuyifei1999 added a comment.
If close happened due to 'MySQL server has gone away', we should have
received a `OperationalError`.
TASK DETAIL
https://phabricator.wikimedia.org/T216741
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
zhuyifei1999 added a comment.
def _write_bytes(self, data):
self._sock.settimeout(self._write_timeout)
try:
self._sock.sendall(data)
except IOError as e:
self._force_close()
raise err.OperationalError
zhuyifei1999 added a comment.
def close(self):
"""Send the quit message and close the socket"""
if self._closed:
raise err.Error("Already closed")
self._closed = True
if self._sock is None:
retur
zhuyifei1999 added a comment.
Which host (or via what means; bastion/grid/k8s; trusty/jessie/stretch) is
the script executed on?
TASK DETAIL
https://phabricator.wikimedia.org/T216741
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
zhuyifei1999 renamed this task from "Bot problems" to "Pywikibot failing with non-jSON response errors due to FANDOM url change".zhuyifei1999 removed a subscriber: pywikibot-bugs-list.
TASK DETAILhttps://phabricator.wikimedia.org/T215038EMAIL PREFERENCEShttps://phabricator.wi
zhuyifei1999 added a comment.
Yeah, I also suspected Windows, as the only possible permission for files coming from Windows is 777.
Ummm.. not really?
We are triggering warning, maybe we should try to change permissions before we throw the warning?
From a stricter security standpoint
zhuyifei1999 added a comment.
https://bugs.python.org/issue29214 sigh...TASK DETAILhttps://phabricator.wikimedia.org/T212723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999Cc: Framawiki, zhuyifei1999, Dvorapa, Xqt, Zoranzoki21, Aklapper, Wesalius
zhuyifei1999 renamed this task from "user-config.py with mode 777 is not readable" to "generate_user_files creates user-config.py with mode 777 on WSL, and then pywikibot refuse to load the config for security".
TASK DETAILhttps://phabricator.wikimedia.org/T212723EM
zhuyifei1999 added a comment.
oh, os.open default mode is 777. Why doesn't WSL have a sane umask?TASK DETAILhttps://phabricator.wikimedia.org/T212723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999Cc: Framawiki, zhuyifei1999, Dvorapa, Xqt
zhuyifei1999 added a comment.
Could it be https://github.com/wikimedia/pywikibot/blob/e57dbff2bf6d4dd719a6f576d96a3b285acbc4ea/pywikibot/config2.py#L1054:
if OSWIN32 or _filemode & 0o02 == 0:
with open(_filename, 'rb') as f:
exec(compile(f.read(), _filename, 'exec'), _uc)
zhuyifei1999 added a comment.
Though, POSIX ACLs might be able to prevent reading 777 files; I have not looked into that. However, POSIX ACLs should not be 'enabled' for a clean install, and even if it's 'enabled' ls should show clearly that the file has ACLs.TASK DETAILhttps
zhuyifei1999 added a comment.
mode 777 being un-readable is not POSIX-conformant and is not Linux bahavior. filesystem default to 777 is also not Linux bahavior (which is mode to open(2) - umask).
The paths in the traceback (/mnt/c/) looks like Windows Subsystem for Linux, and I suspect NTFS ACLs
zhuyifei1999 added a comment.
I think it's loading a wrong user-config.py or something...TASK DETAILhttps://phabricator.wikimedia.org/T212723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999Cc: zhuyifei1999, Dvorapa, Xqt, Zoranzoki21, Aklapper
zhuyifei1999 added a comment.
In T212046#4826224, @Dvorapa wrote:
Pywikibot was warned multiple times about this issue.
Pywikibot 4.0 needed to deprecate all non-standard behavior :) and then there's dd from GNU coreutils that's not really conformant either
Why didn't we use argparse when we
zhuyifei1999 added subscribers: Fae, Dvorapa, Steinsplitter, zhuyifei1999, pywikibot-bugs-list.zhuyifei1999 merged a task: T211882: New uploads receiving apparently false empty-file API errors.
TASK DETAILhttps://phabricator.wikimedia.org/T211886EMAIL PREFERENCEShttps://phabricator.wikimedia.org
zhuyifei1999 closed this task as a duplicate of T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .
TASK DETAILhttps://phabricator.wikimedia.org/T211882EMAIL PREFERENCEShttps://phabricator.wikimedia.org
zhuyifei1999 added a comment.
Likely same as T211900 -> T211886TASK DETAILhttps://phabricator.wikimedia.org/T211882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999Cc: Dvorapa, Steinsplitter, zhuyifei1999, Aklapper, Fae, pywikibot-bugs-list, We
1 - 100 of 505 matches
Mail list logo
