[Pywikipedia-bugs] [Maniphest] [Commented On] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread gerritbot
gerritbot added a comment.

Change 264935 had a related patch set uploaded (by Lokal Profil):
Add edit tests for WbMonolingualText

https://gerrit.wikimedia.org/r/264935


TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T123856: Add tests for Wikibase Monolingual text

2016-01-19 Thread gerritbot
gerritbot added a comment.

Change 264935 merged by jenkins-bot:
Add edit tests for WbMonolingualText

https://gerrit.wikimedia.org/r/264935


TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T123856: Add tests for Wikibase Monolingual text

2016-01-17 Thread Lokal_Profil
Lokal_Profil added a comment.

I can take this one.

What I thought of so far was:

- basic creation from a string
- creation from a unicode string
- equality
- `fromWikibase`-`toWikibase` roundtrip

I would also add raising errors if either parameter is an empty string or not a 
`basestring`, then test that these are raised.

Anything else of the top of anyone's mind?


TASK DETAIL
  https://phabricator.wikimedia.org/T123856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lydia_Pintscher, Liuxinyu970226, Multichill, Aklapper, jayvdb, 
Ricordisamoa, Smalyshev, gerritbot, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs