[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
gerritbot added a comment. Change 407517 abandoned by Zoranzoki21: Allow 100 characters per line Reason: Nothing. We have to live with limit. https://gerrit.wikimedia.org/r/407517TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. In T186255#4062984, @Zoranzoki21 wrote: Status of this? Declined for meTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Zoranzoki21 added a comment. Status of this?TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Versusxo, Majesticalreaper22, Ahmed123, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. In T186255#4047743, @Zoranzoki21 wrote: Example: T189615 If we disable this, problems like my will not happen. I don't believe it. Could you figure out the problem.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Dalba added a comment. In T186255#3939172, @Dvorapa wrote: In these days of 16:9 monitors and 1920x1080 resolutions (usual notebook for everyday use) it is funny to restrict lines to a third of a monitor just to be able to make 3-way comparison? Or why? The screen resolution of my desktop computer is 1280 * 1024. F12955749: r.png It's an old monitor, but it's been working fine for me. According to statcounter statistics for Jan 2018, 2.92% of desktop have a screen resolution of 1280*720 and 4.44% of them 1280*1024. However I don't mind if the limit is changed if I'm the only one here who feels more comfortable with 80 character limit.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Zoranzoki21 added a comment. Patch is fixed now.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. Sure but urls are ignored by that rule for good reasons.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. Sure but urls are ignored by that rule for good reasons.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Dvorapa added a comment. Well, for example Gerrit, on my current machine, 7 years old laptop, 15.6'' 1366x768, can almost handle 100 chars side-by-side (I think 96 or so, but I have got a dock on the left side of the screen. Otherwise it would be over 100. See screenshot). But I am going to buy a new one and I think this is really too narrow for modern ones. And as for reading: It is really too narrow to even keep track of what the code is doing when reading the code. I don't say: Let's remove the limit at all. I don't say let's break PEP8. I just simply say this is not really helpful in anything. Gerrit, 82 chars on marked line: F12944838: Snímek z 2018-02-01 22-54-38.pngTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. @Dvorava: let’s have a Monitor with 1920 dots resolution so see patch diffs side by side in a normal char size of 12 points. Gives 80 chars. Ok say 10 points is enough. But you need some frames an line numbers. I think this is a good reason for 80 chars limit. Or take python‘s IDLE. The default wide is 80 chars. Good enough to pin to windows side by side without needing a slider so show the lines. You may use brackets zu continue lines too, divide code in smaller parts to avoid indenting, shorten expressions by assigning it to identifiers etc.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
gerritbot added a comment. Change 407517 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21): [pywikibot/core@master] Allow 100 characters per line https://gerrit.wikimedia.org/r/407517TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
gerritbot added a comment. Change 407507 abandoned by Zoranzoki21: Revert "tox.ini: Configure Jenkins to fail when lines are longer than 79 characters" Reason: I have problem with cannot merge. I will upload new change https://gerrit.wikimedia.org/r/407507TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Dvorapa added a comment. In T186255#3939126, @Xqt wrote: Don‘t see any reason to ignore PEP8 especially for new lines. Well, PEP8 allows 80–100 if a community is decided to allow more And btw it is very easy to keep the changed lines below 80 chars. In these days of 16:9 monitors and 1920x1080 resolutions (usual notebook for everyday use) it is funny to restrict lines to a third of a monitor just to be able to make 3-way comparison? Or why? In addition it sometimes requires to add some crazy hacks like ...\ ... (I personally hate this in code)TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
gerritbot added a comment. Change 407507 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21): [pywikibot/core@master] Revert "tox.ini: Configure Jenkins to fail when lines are longer than 79 characters" https://gerrit.wikimedia.org/r/407507TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Zoranzoki21 added a comment. In T186255#3939126, @Xqt wrote: Dont Why?TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Xqt added a comment. DontTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line also for new code
Dvorapa added a comment. @demon Yeah, it wasTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Magul, Tbscho, rafidaslam, MayS, Framawiki, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line
Dvorapa added a comment. I was a little bit confused in https://gerrit.wikimedia.org/r/#/c/372064. Jenkins added +1. After a few months I uploaded a new file, but the old left unchanged and Jenkins complained about the unchanged file! It looks like there is a hidden limit for diff to make line under 80 characters, but old lines still can pass with 100. I can not find this somewhere in config (tox.ini still contains 100). But this limit seems too restrictive to me. I would leave 100 for old and 100 for diff. Therefore we started this RFC if 100 characters per line would be acceptable for the community.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Magul, Tbscho, rafidaslam, MayS, Framawiki, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
