| whym added a subscriber: Xqt. whym added a comment. |
@Xqt said that:
I am a bit unsure about this patch because it is a breaking change and conf parameter to the affected classes is mandatory even it is a names parameter. Without the setting parameter the script wouldn't work. Otherwise it's only a script and it shouldn't derived anywhere.
Although I mentioned the possible incompatibility, I believe the number of the scripts dependent to interwik.py is really small. It is a script, not a library, after all.
As I mentioned, I'm introducing in the belief that it would make writing tests easier. interwiki.py could use more extensive unit tests - there are so many corner cases with Wiktionary interwiki links. Crashes with Wiktionaries are so common that I have to restart it.
TASK DETAIL
EMAIL PREFERENCES
To: whym
Cc: Xqt, gerritbot, Aklapper, Zppix, pywikibot-bugs-list, whym, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb
Cc: Xqt, gerritbot, Aklapper, Zppix, pywikibot-bugs-list, whym, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb
_______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
