gerritbot added a comment.
Change 281301 merged by jenkins-bot:
[pywikibot/core@master] Make WbTime from Timestamp and vice versa
https://gerrit.wikimedia.org/r/281301TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL
Lokal_Profil added a comment.
Thanks for the feedback @jayvdb I've implemented the suggestions in a new patch-set.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, jayvdb, Xqt,
Lokal_Profil added a comment.
Found the open patchset related to this. There is still a need for it and the patch should still be mergeable (I just rebased it).
If someone would be willing to review or argue for why it isn't needed.TASK DETAILhttps://phabricator.wikimedia.org/T131624EMAIL
gerritbot added a comment.
Change 281301 had a related patch set uploaded (by Lokal Profil):
Make WbTime from Timestamp and vice versa
https://gerrit.wikimedia.org/r/281301
TASK DETAIL
https://phabricator.wikimedia.org/T131624
EMAIL PREFERENCES
jayvdb added a comment.
Where do we need to use this `today` value in wikidata? i.e. What is an
example use for this, in a statement for which property?
TASK DETAIL
https://phabricator.wikimedia.org/T131624
EMAIL PREFERENCES
Lokal_Profil added a comment.
True if we introduce a `fromTimestamp()` to `__-init.py__.WbTime` which goes
from (possibly both ways) `pywikibot.Timestamp` to `WbTime`
then:
`today = pywikibot.WbTime.fromTimestamp(pywikibot.Timestamp.today())` should
do it.
techically this can be
Xqt added a comment.
Couldn't Timestamp be used for that?
TASK DETAIL
https://phabricator.wikimedia.org/T131624
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt
Cc: Xqt, Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb, Ricordisamoa
Lokal_Profil added a comment.
Alternatively instead of sticking this in `__-init.py__.WbTime` it could go
inte some helper class... if someone can recommedn a good place.
TASK DETAIL
https://phabricator.wikimedia.org/T131624
EMAIL PREFERENCES