[Pywikipedia-bugs] [Maniphest] [Commented On] T135359: User.isAnonymous() gives wrong result for IP ranges

2024-04-12 Thread binbot
binbot added a comment. My 2 cents: Pywikibot does not have the mission to correct ambigiousness of MediaWiki. u.isAnonymous() should first examine isinstance(u, pywikibot.User). If it is instantiated as Page, it should act as Page. If it is instantiated as User, we should check the

[Pywikipedia-bugs] [Maniphest] [Commented On] T135359: User.isAnonymous() gives wrong result for IP ranges

2020-11-26 Thread gerritbot
gerritbot added a comment. Change 288915 **abandoned** by Xqt: [pywikibot/core@master] [bugfix] fix isAnonymous result for ip ranges Reason: Not an appropriate patch https://gerrit.wikimedia.org/r/288915 TASK DETAIL https://phabricator.wikimedia.org/T135359 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T135359: User.isAnonymous() gives wrong result for IP ranges

2016-05-24 Thread Xqt
Xqt added a comment. Yes I agree it is a problem because "user:212.65.1.102/16" may be a valid subpage of "user:212.65.1.102" and is not a range. On the other hand we need some sort of tools to handle IP ranges coming from log entries which acts like a user for some methods. No idea yet.

[Pywikipedia-bugs] [Maniphest] [Commented On] T135359: User.isAnonymous() gives wrong result for IP ranges

2016-05-24 Thread jayvdb
jayvdb added a comment. I suspect that you're calling this a bug because some log entries types have IP ranges, but the bug is that logentries.py creates a User class for them. A `page.User` object is a subclass of `page.Page` (with an implicit User: namespace), so it only reasonable if it

[Pywikipedia-bugs] [Maniphest] [Commented On] T135359: User.isAnonymous() gives wrong result for IP ranges

2016-05-16 Thread gerritbot
gerritbot added a comment. Change 288915 had a related patch set uploaded (by Xqt): [bugfix] fix isAnonymous result for ip ranges https://gerrit.wikimedia.org/r/288915 TASK DETAIL https://phabricator.wikimedia.org/T135359 EMAIL PREFERENCES