Lokal_Profil added a comment.
Can be resolved once announced (or if we decide not to announce)TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Octahedron80, gerritbot, Aklapper, Zppix,
Lokal_Profil added a comment.
Don't think it is due to this patch since the code is only triggered when you have password_file in your user-config.py.
When I try python pwb.py login I get a normal login prompt so most likely it is something local on your machine which has changed. If not then I'd
Octahedron80 added a comment.
No error message appears. Just looks like normal. When it asks for password, it does not take (hidden) input; it just print out what I press (that is my password) and it does not continue. (I tried many times and same behavior). I do not use password_file.TASK
Lokal_Profil added a comment.
In T139749#2569985, @Octahedron80 wrote:
Now "python pwb.py login" is unable to login. Please check. (I am not sure if it is caused by this patch)
Which error message do you get? Are you using a password_file? The should be backwards compatible in all but a few
gerritbot added a comment.
Change 305665 merged by jenkins-bot:
Make password_file respect -dir flag
https://gerrit.wikimedia.org/r/305665TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc:
Lokal_Profil added a comment.
If we go for this solution we should not forget to #pywikibot-announce it afterwards since there are rare situations where the fix (despite backwards compatibility) might break existing set-ups.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL
gerritbot added a comment.
Change 305665 had a related patch set uploaded (by Lokal Profil):
Make password_file respect -dir flag
https://gerrit.wikimedia.org/r/305665TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL
Lokal_Profil added a comment.
A quick and dirty solution would be to have readPassword() do a os.cwd to config.base_dir before trying to open the file and then os.cwd back before exiting.TASK DETAILhttps://phabricator.wikimedia.org/T139749EMAIL
