gerritbot added a comment.
Change #1022503 **merged** by jenkins-bot:
[pywikibot/core@master] [IMPR] Respect 'text-contains' from fixes dictionaries
https://gerrit.wikimedia.org/r/1022503
TASK DETAIL
https://phabricator.wikimedia.org/T142324
EMAIL PREFERENCES
gerritbot added a comment.
Change #1022503 had a related patch set uploaded (by Matěj Suchánek; author:
Matěj Suchánek):
[pywikibot/core@master] [IMPR] Respect 'text-contains' from fixes dictionaries
https://gerrit.wikimedia.org/r/1022503
TASK DETAIL
Zoranzoki21 added a comment.
In T142324#3630236, @Basilicofresco wrote:
Hi! I tested it again with the latest version and it still doesn't work as expected. The problem now is slightly different: the text-contains exceptions within the user-fixes.py are always treated as non-regex. Other
Zoranzoki21 added a comment.
I will subscribe me because I have not problem.. Per command python pwb.py version I have:
Pywikibot: [ssh] pywikibot-core.git (9060d67, g8565, 2017/09/01, 18:04:14, n/a)
Release version: 3.0-dev
requests version: 2.13.0
cacerts: C:\Program
Basilicofresco added a comment.Herald added a subscriber: jeblad.
Hi! I tested it again with the latest version and it still doesn't work as expected. The problem now is slightly different: the text-contains exceptions within the user-fixes.py are always treated as non-regex. Other exceptions like
gerritbot added a comment.
Change 361306 merged by jenkins-bot:
[pywikibot/core@master] replace.py: do not overwrite exceptions given via CLI
https://gerrit.wikimedia.org/r/361306TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL
gerritbot added a comment.
Change 361306 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] replace.py: do not overwrite exceptions given via CLI
https://gerrit.wikimedia.org/r/361306TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL
Mpaa added a comment.
After the patch, exceptions entered via CLI are erased.
And if fix contains no 'exceptions' key:
fixes['example'] = {
'regex': True,
'msg': {
'_default':u'no summary specified',
},
'replacements': [
(r'\bword\b', u'two words'),
]
}
gerritbot added a comment.
Change 353714 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Enable exceptions from fixes file
https://gerrit.wikimedia.org/r/353714TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL
Nemo_bis added a comment.
I've looked into the code more yesterday, but I don't understand if the "inside" exceptions are ever actually passed to textlib.TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt,
Xqt added a comment.
a print statement inside isTextEcepted() shows this:TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Nemo_bis, Xqt, Dalba, jayvdb, gerritbot, Aklapper, pywikibot-bugs-list,
Xqt added a comment.
The problem is that ReplaceRobot.exceptions is empty. It does not contain the exceptions declared in the fixes file.TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Nemo_bis, Xqt,
Xqt added a comment.
@Nemo_bis: Could you explain a little bit more. This Tasks is for the 'text-contains' tag but you issue is about 'inside'and 'inside-tags' and the corresponding options -exceptinside and -exceptinsidetagTASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL
gerritbot added a comment.
Change 304596 had a related patch set uploaded (by Dalba):
replace.py: check 'text-contains' exceptions for each user-defined fix
https://gerrit.wikimedia.org/r/304596TASK DETAILhttps://phabricator.wikimedia.org/T142324EMAIL
14 matches
Mail list logo
