[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-25 Thread gerritbot
gerritbot added a comment. Change 305664 merged by jenkins-bot: Add support for BotPasswords https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, gerritbotCc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. If we go for this solution we should not forget to #pywikibot-announce it afterwards.TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, valhallasw,

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread gerritbot
gerritbot added a comment. Change 305664 had a related patch set uploaded (by Lokal Profil): Add support for BotPasswords https://gerrit.wikimedia.org/r/305664TASK DETAILhttps://phabricator.wikimedia.org/T143417EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T143417#2567648, @Lokal_Profil wrote: In T143417#2567601, @Lokal_Profil wrote: My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread valhallasw
valhallasw added a comment. I think the main thing is to separate the user name and the login name. I'm inclined to say that the '@suffix' API wasn't a great design -- the suffix should have been part of the password rather than the user name. As far as pywikibot is concerned, I would actually

[Pywikipedia-bugs] [Maniphest] [Commented On] T143417: assert self.site.user() fails when using BotPasswords

2016-08-19 Thread Lokal_Profil
Lokal_Profil added a comment. In T143417#2567601, @Lokal_Profil wrote: My guess is that this needs to be fixed over in pywikibot/tools/__init__.py:DeprecatedRegex.normalize_username() in order to be handled correctly everywhere (several other functions make the same assumption). But