Sovmogil added a comment.
Thank you @Lokal_Profil . The solution worked.TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, SovmogilCc: Sovmogil, Mike_Peel, Holger, daniel, Magul, ChongDae,
Lokal_Profil added a comment.
@Sovmogil you need to use the newest version on pip 3.0.xxxTASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Sovmogil, Mike_Peel, Holger, daniel, Magul, ChongDae,
Sovmogil added a comment.
Hi!
I am sorry, but
with this version:
Pywikibot: pywikibot/__init__.py (c4ccfae, -1 (unknown), 2017/05/05, 01:02:04, n/a)
Release version: 2.0rc5
httplib2 version: 0.9.1
cacerts: D:\SNMs\refinery\pywikibot\core_stable\externals\httplib2\python3\httplib2\cacerts.txt
Lokal_Profil added a comment.
Per T150210#2954454 you will need to raise this on the tasks for making a new release. At this point 2.0r5 is so far behind master that it might not be possible to reliably backport individual patches.TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
Mike_Peel added a comment.
Please consider fixing this in 2.0rc5/the pip install version. I just came across this, and spent the time to debug my code to make sure that wasn't the problem, tracked down the problematic value on a Wikidata entry, wrote a test script that demonstrates the issue,
Holger added a comment.
Is this fix already in 2.0rc5?
Getting this error in lots of places.
Thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, HolgerCc: Holger, daniel, Magul, ChongDae,
gerritbot added a comment.
Change 322672 merged by jenkins-bot:
Require site object only for older MediaWiki installations
https://gerrit.wikimedia.org/r/322672TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
Lokal_Profil added a comment.
@Strainu No reply on the list. I would suggest merging the patch as I've already seen a couple of questions from people running on Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
Lokal_Profil added a comment.
In T150210#2810877, @Strainu wrote:
Since backwards compatibility will be broken anyway, the question is if we should keep the extra code that handles older versions of Wikibase. Is there any data on the number of Wikibase installations out there?
I pinged the
Strainu added a comment.
Since backwards compatibility will be broken anyway, the question is if we should keep the extra code that handles older versions of Wikibase. Is there any data on the number of Wikibase installations out there?TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
gerritbot added a comment.
Change 322672 had a related patch set uploaded (by Lokal Profil):
Require site object only for older MediaWiki installations
https://gerrit.wikimedia.org/r/322672TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
Lokal_Profil added a comment.
OK. So the current patch was merged which allows pywikibot to go on dealing with Wikidata.
To avoid the scenario which @daniel mentions a follow-up patch can be submitted which changes _require_errors() to False instead if no site object is provided. I we put
daniel added a comment.
@Strainu defaulting to +/-0 was nearly always definitely wrong. +/-0 means ABSOLUTE precision. That does not exist for any measured quantity, only for definitions and exact counts.
Omitted bounds does not have the same semantics as +/-0 at all. A bot is going to change
gerritbot added a comment.
Change 320649 merged by jenkins-bot:
[Breaking]Make uncertainties in WbQuantity optional
https://gerrit.wikimedia.org/r/320649TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Strainu added a comment.
In T150210#2785021, @Lokal_Profil wrote:
My worry is that the current solution would require everyone who wants their bot to correctly handle Quantities on Wikidata to update their code (adding the site object). Whereas if they ignore the warning they can happily go on
Strainu added a comment.
Great job keeping the backwards compatibility! I say submit the code with the current logic and remove the extra logic later if the code becomes unmaintainable (this will eventually happen after a few more breaking changes to wikibase).TASK
Lokal_Profil added a comment.
In T150210#2783476, @gerritbot wrote:
Change 320649 had a related patch set uploaded (by Lokal Profil):
Make uncertainties in WbQuantity optional
https://gerrit.wikimedia.org/r/320649
There is a lot of extra code in here just to ensure this is compatible with
gerritbot added a comment.
Change 320649 had a related patch set uploaded (by Lokal Profil):
Make uncertainties in WbQuantity optional
https://gerrit.wikimedia.org/r/320649TASK DETAILhttps://phabricator.wikimedia.org/T150210EMAIL
18 matches
Mail list logo
