gerritbot added a comment.
Change 806554 **merged** by jenkins-bot:
[pywikibot/core@master] Revert: [bugfix] weblinkchecker.py: Use https for
web.archive.org
https://gerrit.wikimedia.org/r/806554
TASK DETAIL
https://phabricator.wikimedia.org/T167463
EMAIL PREFERENCES
gerritbot added a comment.
Change 806554 had a related patch set uploaded (by Xqt; author: Xqt):
[pywikibot/core@master] Revert: [bugfix] weblinkchecker.py: Use https for
web.archive.org
https://gerrit.wikimedia.org/r/806554
TASK DETAIL
https://phabricator.wikimedia.org/T167463
Zoranzoki21 added a comment.
In T167463#393, @Dvorapa wrote:
As the issue with memento is solved, is this issue solved too? Is the hacky patch reverted? Can this be marked as resolved?
This is not fixed.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Dvorapa added a comment.
As the issue with memento is solved, is this issue solved too? Is the hacky patch reverted? Can this be marked as resolved?TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc:
gerritbot added a comment.
Change 380923 abandoned by Zoranzoki21:
[bugfix] weblinkchecker.py: Use https for web.archive.org
Reason:
All checks on github failed.. And I do not know how to make permanent fix for https
https://gerrit.wikimedia.org/r/380923TASK
gerritbot added a comment.
Change 380923 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[pywikibot/core@master] [bugfix] weblinkchecker.py: Use https for web.archive.org
https://gerrit.wikimedia.org/r/380923TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Zoranzoki21 added a comment.
In T167463#3337415, @Framawiki wrote:
@Zoranzoki21 To get the last version of pywikibot, you have ti use Git: https://www.mediawiki.org/wiki/Manual:Pywikibot/Gerrit. Don't hesitate to tell me if I can help you to use it.
NOTE: This task is not solved, we currently
Zoranzoki21 added a comment.
I updated, but I not see efects. See: https://sr.wikipedia.org/wiki/%D0%A0%D0%B0%D0%B7%D0%B3%D0%BE%D0%B2%D0%BE%D1%80:.sjTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Zoranzoki21 added a comment.
I will test to see.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: valhallasw, gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho,
Zoranzoki21 added a comment.
OK. Super :)TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: valhallasw, gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho, MayS,
Framawiki added a comment.
Good new: The issue is fixed with the library, so I'll look if we can revert my hacky patch.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: valhallasw, gerritbot,
Framawiki added a comment.
In T167463#3345720, @valhallasw wrote:
Aha. It seems getInternetArchiveURL uses https://archive.org/wayback/available?url="">, which also still returns an http link. So the search-and-replace should be moved to setLinkDead.
Oh, ok, I'll look at it too.TASK
Zoranzoki21 added a comment.
In T167463#3346142, @Framawiki wrote:
Thé tool use also other service providers than archive.org
OkTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: valhallasw,
Framawiki added a comment.
Thé tool use also other service providers than archive.orgTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: valhallasw, gerritbot, Aklapper, Framawiki, Zoranzoki21,
Zoranzoki21 added a comment.
Ok.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: valhallasw, gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont,
valhallasw added a comment.
Aha. It seems getInternetArchiveURL uses https://archive.org/wayback/available?url="">, which also still returns an http link. So the search-and-replace should be moved to setLinkDead.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Zoranzoki21 added a comment.
Hmmm. Now I downloaded script weblinkchecker from http://tools.wmflabs.org/pywikibot/ and.. There have not https. See here.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Zoranzoki21 added a comment.
It should be https://web.archive.orgTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: valhallasw, gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list,
Zoranzoki21 added a comment.
I think on selected in green color.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho,
Zoranzoki21 added a comment.
What is that? F8454157: ScreenShot_20170613200721.pngTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: gerritbot, Aklapper, Framawiki, Zoranzoki21,
Zoranzoki21 added a comment.
Thank you very much!TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont,
Zoranzoki21 added a comment.
If is that resolved, can I now test to see effect?TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list,
gerritbot added a comment.
Change 358053 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] weblinkchecker.py: Use https for web.archive.org
https://gerrit.wikimedia.org/r/358053TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Zoranzoki21 added a comment.
Tnx @FramawikiTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: gerritbot, Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe,
Framawiki added a comment.
» https://github.com/mementoweb/py-memento-client/issues/10TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, Aklapper, Framawiki, Zoranzoki21,
gerritbot added a comment.
Change 358053 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] [bugfix] weblinkchecker.py: Use https for web.archive.org
https://gerrit.wikimedia.org/r/358053TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Zoranzoki21 added a comment.
Thank you @FramawikiTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89,
Framawiki added a comment.
>>> import datetime
>>> import memento_client
>>> mc = memento_client.MementoClient()
>>> when = datetime.datetime.now()
>>> url = ""
>>> memento_info = mc.get_memento_info(url, when)
>>> memento_info
{'mementos': {'last': {'uri':
Framawiki added a comment.
As I can see the problem comes from the _get_closest_memento_url function that uses memento_client.MementoClient(), that is an extern library : https://github.com/mementoweb/py-memento-clientTASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL
Zoranzoki21 added a comment.
I modifided code in Saturday, and I tested, but it do not work. Only work translate on Serbian which I add and my modification to not adding 3 blank lines per report, to add one blank line per report. F8414608: weblinkchecker.py
See my comment on geritTASK
Zoranzoki21 added a comment.
OK. Thank you very much!TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: Aklapper, Framawiki, Zoranzoki21, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont,
31 matches
Mail list logo
