[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 327580 abandoned by Dalba: Rerun site links methods tests on failure Reason: I guess this change can be abandoned now that 377047 has been merged. https://gerrit.wikimedia.org/r/327580TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 357195 abandoned by Dalba: Disable request caching on Travis Reason: I guess this change can be abandoned now that 377047 has been merged. https://gerrit.wikimedia.org/r/357195TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 356835 abandoned by Dalba: site_tests.py: Handle random errors caused by page content change Reason: Change 377047 was merged as an alternative. https://gerrit.wikimedia.org/r/356835TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 377047 merged by jenkins-bot: [pywikibot/core@master] site_tests.py: Avoid race conditions in test_pagetemplates and test_pagelinks https://gerrit.wikimedia.org/r/377047TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 376898 abandoned by Dalba: site_tests.py: Use a freezed API response to avoid race conditions Reason: In favour of https://gerrit.wikimedia.org/r/#/c/377047 https://gerrit.wikimedia.org/r/376898TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 377047 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] site_tests.py: Avoid race conditions in test_pagetemplates and test_pagelinks https://gerrit.wikimedia.org/r/377047TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 376898 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] site_tests.py: Used a freezed API response to avoid race conditions https://gerrit.wikimedia.org/r/376898TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Lordiis, Cinemantique, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 357195 had a related patch set uploaded (by Merlijn van Deen; owner: Merlijn van Deen): [pywikibot/core@master] Disable request caching on Travis https://gerrit.wikimedia.org/r/357195TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 356835 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] site_tests.testLinkMethods: Ignore errors caused by page content change https://gerrit.wikimedia.org/r/356835TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, gerritbotCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
Dalba added a comment.
This happened again in the most recent build:
https://travis-ci.org/wikimedia/pywikibot-core/jobs/237516255
self.assertCountEqual(
> set(mysite.pagelinks(mainpage, namespaces=[0, 1])) - links, [])
E AssertionError: Element counts were not equal:
E First has 1, Second has 0: Page('Manuel Noriega')
Apparently, the link has been added while the test has been running.
I have another solution that is simple to implement and may even be considered more trustworthy and efficient than just retrying the test suite:
We can re-fetch the set of linked pages and compare it with the original set, if the set has changed we may conclude that the page content has changed and the AssertionError is safe to be ignored.
I'll send a patch for review soon ...TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, DalbaCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, GPHemsley, Nemo_bis, Darkdadaah, Masti, Alchimista, Rxy, Krenair___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
Lokal_Profil added a comment. @Magul One minor comment on the patch. Otherwise it looks good to go.TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, Lokal_ProfilCc: Lokal_Profil, valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, MarcAbonce, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, GPHemsley, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
gerritbot added a comment. Change 327580 had a related patch set uploaded (by Magul): Rerun site links methods tests on failure https://gerrit.wikimedia.org/r/327580TASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, gerritbotCc: valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, Tbscho, MayS, Mdupont, JJMC89, GPHemsley, Darkdadaah, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
Magul added a comment. Working on: https://travis-ci.org/wikimedia/pywikibot-core/jobs/177817110#L6394-L6467 Symmetric diff: Template:@POTD/2016-11-19", :@1986", :@Star Trek: The Original Series", :@Rosetta (spacecraft)", :@Jean-Patrick Lescarboura", :@Gettysburg Address", Template talk:@Did you know", :@Professional wrestling", :@Paramount Pictures", :@Streitraum", Template:@POTD protected/2016-11-22", :@1386", :@La Máscara (wrestler)", :@List of Star Trek Starfleet starships ordered by class", :@New York", :@University of Oxford", :@Colin Mawby", :@Carolin Emcke", :@List of Six Nations Championship hat-tricks", :@George Naea", :@First Sino-Japanese War", :@Star Trek: The Next Generation", :@Reform Act 1832", :@Scotland national rugby union team", :@Congress of Manastir", Project:@News", Portal:@Society", :@Resist", :@Union Army", :@Abraham Lincoln", :@William S. Hart", :@1996", :@1928", :@Humberto Vidal explosion", :@Prime Minister of the United Kingdom", :@Gilberto Gil", :@Lüshunkou District", :@Saturn Awards", :@1830", :@Ronald D. Moore", Portal:@Technology", :@Eugen Eckert", :@Marc Bassingthwaighte", :@Proceratium petrosum", :@European Space Agency", :@Lebanon", :@Star Trek: First Contact", :@George Campbell Lindsay", :@Resist (semiconductor fabrication)", :@Svetlana Gerasimenko", :@John Hay", :@Abraham Lincoln's second inaugural address", :@Olearia ramulosa", :@November 23", Project:@Today's featured article/November 2016", Portal:@Biography", :@Powderfinger discography", :@Industrial Light & Magic", :@Robert W. Jones", :@Ireland national rugby union team", :@Palais Garnier", :@Spanish language", Project:@Today's featured list/November 2016", Project:@Introduction", :@Borg (Star Trek)", :@Battle of Lushunkou", :@Timur", Project:@Featured articles", :@Cyborg", :@Bagrat V of Georgia", :@Jin Chae-seon", :@Kennedy St-Pierre", :@Queen Emma of Hawaii", :@Olearia viscidula", :@Taiwanese aborigines", :@Namibian National Road Race Championships", :@1908", Portal:@Mathematics", :@Dutch Formosa", :@Pansori", :@The Vine (bus rapid transit)", Portal:@Arts", :@Jdeideh", :@Vaile Mansion", :@Confederate States of America", :@American Civil War", :@Academy Award for Best Makeup", :@Wales national rugby union team", Project:@Community portal", Project:@Reference desk", :@Cybergeddon (film)", :@Star Trek Generations", :@Maurice Ravel", :@Star Trek (film series)", :@Try", Portal:@Current events", :@World Hello Day", :@Dutch pacification campaign on Formosa", :@San Juan, Puerto Rico", :@Brazilian battleship São Paulo", :@Olearia tomentosa", :@John Diefenbaker", :@Science fiction film", :@Ángel de Oro", :@African Games", :@Brazilian cruiser Bahia", :@Valemount, British Columbia", :@The class the stars fell on", :@Mike Tyson", Template:@POTD/2016-11-20", :@Professional wrestling weight classes", :@Port Arthur massacre (China)", Project:@Your first article", :@White House", Portal:@Science", Project:@Featured lists", :@Computer-generated imagery", :@Revolt of the Lash", :@67P/Churyumov–Gerasimenko", :@Wild Bill Hickok (film)", :@England national rugby union team", Project:@Help desk", :@Wyatt Earp", :@Río Piedras, Puerto Rico", :@Jean-Luc Picard", :@Neues Geistliches Lied", :@South American dreadnought race", :@Professional wrestling championship", :@Massachusetts", :@List of heavyweight boxing champions", :@Orbital period", :@Klim Churyumov", Project:@Recent additions", :@Hat-trick", :@President of the United States", Project:@Village pump", Portal:@History", :@Ahab (Moby-Dick)", :@Mauritius", :@Portland metropolitan area", :@Drop goal", :@Black American Sign Language", :@1894", Project:@Featured pictures", :@Brazilian Navy", :@Herman Zimmerman", :@Pierre Albaladejo", :@Grammy Award", :@Consejo Mundial de Lucha Libre", Project:@Today's featured list/November 21, 2016", :@Resist dyeing", :@Quanta Live", :@Rachel Freier", :@Boston", :@Professional wrestling promotion", :@Neil Jenkins", :@Pierre Amine Gemayel", :@Dr. J. Butz", :@Comet", :@Olearia", :@Rugby union", Project:@Picture of the day/November 2016", :@Jupiter-family comet", Portal:@Geography", :@Turco-Mongol", :@Commerzbank-Arena", :@France national rugby union team", :@Tbilisi", :@1910", :@Naming of comets", :@Diego Domínguez (rugby union)", :@Independence, Missouri", :@2006", Project:@Selected anniversaries/November", :@Canoe River train crash", Template:@POTD/2016-11-18", :@Timur's invasions of Georgia", :@Trevor Berbick", :@Kuiper belt", :@Herman Melville", :File:@LaMascaraLuchador.jpg", :@1635", :@Olearia decurrens", :@1950", :@Ian Smith (Scottish rugby player born 1903)", :@Boléro", :@Earl Grey tea", :@1943", Template:@POTD protected/2016-11-21", :@Brannon Braga", :@Charles Grey, 2nd Earl Grey", :@Six Nations Championship", Portal:@Contents/Portals", :@Christopher Tambling", :@Jonathan Frakes", Project:@Local Embassy", :@List of lakes in Minneapolis", :@World Boxing Council", :@Web series", :@Brazilian battleship Minas Geraes", :@Bus rapid transit",
[Pywikipedia-bugs] [Maniphest] [Commented On] T92856: Assertion failure testing namespace restriction
jayvdb added a comment. It seems to only occur when the site tests are run under SITE_ONLY. fr.wikt has not re-appeared since it was moved to be a full test build. TASK DETAIL https://phabricator.wikimedia.org/T92856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, GPHemsley, Darkdadaah, Krenair, Malyacko, P.Copp ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
