[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

darthbhyrava added a comment. I've added reviewers from my end, but would be glad is someone could +2 both this and T129017 ? Thanks! TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

darthbhyrava added a comment. @jayvdb sure, I'll take a look into that, too. :) TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc: Xqt, gerritbot, darthbhyrava, Avicennasis,

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

jayvdb added a comment. @darthbhyrava , the script `panoramiopicker.py` is nearly a copy of `flickrripper.py`, and has the same problem. If you like, you can fix this problem in `panoramiopicker.py` also. TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

gerritbot added a comment. Change 273842 merged by jenkins-bot: Change flickrripper:remove default values for parameters wherever necessary https://gerrit.wikimedia.org/r/273842 TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

gerritbot added a comment. Change 273842 had a related patch set uploaded (by Darthbhyrava): Change flickrripper:remove default values for parameters wherever necessary https://gerrit.wikimedia.org/r/273842 TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

gerritbot added a comment. Change 273866 abandoned by Darthbhyrava: Change flickrripper:remove default values for all parameters Reason: Should be an amend commit, not a duplicate one. https://gerrit.wikimedia.org/r/273866 TASK DETAIL https://phabricator.wikimedia.org/T93098

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

darthbhyrava added a comment. Changes I'm making in my patch: def getPhoto(flickr=None, photo_id='') --> def getPhoto(flickr, photo_id) def isAllowedLicense(photoInfo=None) --> def isAllowedLicense(photoInfo) def getPhotoUrl(photoSizes=None) --> def getPhotoUrl(photoSizes) .