Lokal_Profil created this task. Lokal_Profil added a subscriber: Lokal_Profil. Lokal_Profil added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION Currently qualifiers are misidentified as references when `fromJSON()` is called on the parent claim. To test: ``` import pywikibot;repo = pywikibot.Site().data_repository();item = pywikibot.ItemPage(repo, 'Q4115189') item.exists() c = item.claims['P800'][0];sc = c.sources[1]['P813'][0];qc = c.qualifiers['P580'][0] qc.isReference qc.isQualifier sc.isReference sc.isQualifier ``` I have a quick patch which simply moves the `isQualifier`/`isReference` assignment to the `qualifierFromJSON()`/`referenceFromJSON()` methods. However since I'm unsure if `fromJSON()` is ever called directly on a qualifer/reference I'm not sure whether this is enough. TASK DETAIL https://phabricator.wikimedia.org/T113212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb _______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
