[Pywikipedia-bugs] [Maniphest] [Created] T173289: test_merriam_webster failed with Server504Error

[Dalba]

Dalba created this task. Dalba added projects: Pywikibot-tests, Pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

https://travis-ci.org/wikimedia/pywikibot-core/jobs/264173677#L4616
https://travis-ci.org/wikimedia/pywikibot-core/jobs/264173676#L3524
https://travis-ci.org/wikimedia/pywikibot-core/jobs/264173674#L3655

======================================================================

ERROR: test_merriam_webster (tests.site_detect_tests.NoSiteTestCase)

Test detection of MediaWiki sites for www.merriam-webster.com.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/wikimedia/pywikibot-core/tests/site_detect_tests.py", line 245, in test_merriam_webster

    'http://www.merriam-webster.com/'

  File "/home/travis/build/wikimedia/pywikibot-core/tests/site_detect_tests.py", line 47, in assertNoSite

    ServerError, Timeout), MWSite, url)

  File "/opt/python/3.5.3/lib/python3.5/unittest/case.py", line 728, in assertRaises

    return context.handle('assertRaises', args, kwargs)

  File "/opt/python/3.5.3/lib/python3.5/unittest/case.py", line 177, in handle

    callable_obj(*args, **kwargs)

  File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/site_detect.py", line 60, in __init__

    r = fetch(fromurl)

  File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/comms/http.py", line 509, in fetch

    error_handling_callback(request)

  File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/comms/http.py", line 399, in error_handling_callback

    raise Server504Error("Server %s timed out" % request.hostname)

pywikibot.exceptions.Server504Error: Server www.merriam-webster.com timed out

----------------------------------------------------------------------

The error was temporary, but should not break our test. We already ignore ConnectionError, RuntimeError, ServerError, and Timeout in assertNoSite.

We may want to add Server504Error and Server414Error to that list or maybe let these exceptions inherit from ServerError.

TASK DETAIL

https://phabricator.wikimedia.org/T173289

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs