D3r1ck01 added a comment.
From my little experience, I mostly think the smaller number of changes the better and easier for review. Also, it should not be too easy for GCI too so the proposition of 2 - 3 files for smaller occurrences or 1 file for many occurrences makes sense in this case. For
Dvorapa added a comment.
@D3r1ck01 Feel free to update the description to GCI needs.TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi,
Dvorapa created this task.Dvorapa added projects: Pywikibot, Google-Code-in-2018.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION./docs/conf.py:287:17: W504 line break after binary operator
./scripts/imagetransfer.py:203:41: W504 line break after binary
D3r1ck01 added a comment.
Wow, a huge list. So @Dvorapa, how many of this fix can make a GCI task? I think a fix in 2 - 3 files with less occurrences or 1 file with many occurrences? What are your thoughts?TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL
D3r1ck01 added a comment.
In T207836#4691278, @Dvorapa wrote:
@D3r1ck01 Feel free to update the description to GCI needs.
Sure, once we discuss and result to a very nice conclusion, we can GCI the task :)TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL
Dvorapa added a comment.
In T207836#4691279, @D3r1ck01 wrote:
From my little experience, I mostly think the smaller number of changes the better and easier for review. Also, it should not be too easy for GCI too so the proposition of 2 - 3 files for smaller occurrences or 1 file for many
D3r1ck01 renamed this task from "Fix W504 issues across files" to "Fix W504 issues across files in the Pywikibot repository".D3r1ck01 updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION[Pywikibot](https://www.mediawiki.org/wiki/Manual:Pywikibot) is a Python library and
gerritbot added a comment.
Change 469405 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[pywikibot/core@master] [cleanup] Fix W504 error in scripts/welcome.py
https://gerrit.wikimedia.org/r/469405TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, CucyNoiD, NebulousIris, Wenyi,
Dvorapa added a project: goodfirstbug.
TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi,
D3r1ck01 added a comment.
@Dvorapa, cool! So let me quickly do an example patch so our GCI participants can reference from there! Also, once the example patch is up and running, I'll begin reworking the task description then importing the task to GCI website :)TASK
Dvorapa added a comment.
In T207836#4691269, @D3r1ck01 wrote:
Wow, a huge list. So @Dvorapa, how many of these fixes can make a GCI task? I think fixes in 2 - 3 files with less occurrences or 1 file with many occurrences? What are your thoughts?
This is similar to fixing u'' or %s, so you
Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2018 board.Aklapper added a comment.
@Dvorapa: Do you plan to mentor this task for #GCI-2018? If so, please see https://www.mediawiki.org/wiki/Google_Code-in/Mentors - thanks!TASK
D3r1ck01 added a comment.
I will be mentoring this for #google-code-in-2018 :)TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa,
Xqt triaged this task as "Lowest" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T203395EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Liuxinyu970226, D3r1ck01, Wesalius, Xqt, Framawiki, Aklapper, pywikibot-bugs-list,
gerritbot added a comment.
Change 469433 had a related patch set uploaded (by Nathan fraignt; owner: Nathan fraignt):
[pywikibot/core@master] Removed unused vars/parameters from daemonize.py and data/api.py
https://gerrit.wikimedia.org/r/469433TASK
Dalba added a comment.
The test is looking for in the returned value of pageTextPost which does not have it. I've created a paste of the actual retrieved data at P7716. This might be a UI change and in which case we might need to update some parts of the imagecopy.py accordingly.TASK
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T192429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, gerritbotCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, CucyNoiD, NebulousIris, Gaboe420,
Xqt claimed this task.Xqt closed this task as "Resolved".Xqt added a comment.
CR+2 granted.TASK DETAILhttps://phabricator.wikimedia.org/T207769EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, Aklapper, pywikibot-bugs-list, Dalba, Dvorapa,
D3r1ck01 added a comment.
Thank you very much @Xqt. Much appreciated. @zhuyifei1999, example GCI task for Pywikibot this year is this: https://phabricator.wikimedia.org/T203395.TASK DETAILhttps://phabricator.wikimedia.org/T207769EMAIL
Dvorapa added a comment.
In T207579#4690879, @Dalba wrote:
The test is looking for in the returned value of pageTextPost which does not have it. I've created a paste of the actual retrieved data at P7716. This might be a UI change and in which case we might need to update some parts of the
Dvorapa added a comment.
Also we will need to change the file in our tests, because the current file has been transferred to Commons lately.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa,
Dalba changed the task status from "Stalled" to "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T192429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, CucyNoiD, NebulousIris, Gaboe420,
Dalba added a comment.
I believe we can remove rstcheck and let Sphinx raise error upon warnings. But before configuring Sphinx to do that, we need to resolve the remaining warnings (T187009).TASK DETAILhttps://phabricator.wikimedia.org/T204189EMAIL
25 matches
Mail list logo
