[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2020-04-19 Thread Dvorapa 
Dvorapa added a comment.


  In case of user-config.py the are not detected (as part of strings)

TASK DETAIL
  https://phabricator.wikimedia.org/T165911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, Dalba, valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, 
pywikibot-bugs-list, Multichill, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2020-04-19 Thread Xqt 
Xqt added a comment.


  In T165911#6068211 , 
@Dvorapa wrote:
  
  > I can still see a lot of places in code where u'' or u"" is used
  
  They are only in comments otherwise it would have been detected by 
`flake8-no-u-prefixed-strings`. Anyway I made a patch.

TASK DETAIL
  https://phabricator.wikimedia.org/T165911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Dvorapa, Dalba, valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, 
pywikibot-bugs-list, Multichill, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2020-04-19 Thread gerritbot 
gerritbot added a comment.


  Change 590281 had a related patch set uploaded (by Xqt; owner: Xqt):
  [pywikibot/core@master] [cleanup] remove remaining unicode literals specifiers
  
  https://gerrit.wikimedia.org/r/590281

TASK DETAIL
  https://phabricator.wikimedia.org/T165911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dvorapa, Dalba, valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, 
pywikibot-bugs-list, Multichill, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2020-04-18 Thread Dvorapa 
Dvorapa added a comment.


  
https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/?grep=%5B%5Ea-zA-Z%22%27%5Du%5B%22%27%5D

TASK DETAIL
  https://phabricator.wikimedia.org/T165911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, Dalba, valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, 
pywikibot-bugs-list, Multichill, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-09-06 Thread Dalba 
Dalba added a comment.
+1. I personally don't care about blame history much. Making the code more visually appealing, more newcomer-friendly, and one less thing to argue about during code reviews is more important for me.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dalba, valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, pywikibot-bugs-list, Multichill, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-05-28 Thread binbot 
binbot added a comment.

In T165911#3296955, @valhallasw wrote:





Not, they don't. The u'' prefix has been allowed since Python 3.3, which was released in 2012. Official support for Python 3.2 was dropped in Feb 2016. There is absolutely no reason to remove them, apart from 'it looks nicer'.

OK, I didn't know that.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: binbotCc: valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, pywikibot-bugs-list, Multichill, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-05-28 Thread valhallasw 
valhallasw added a comment.

In T165911#3296939, @binbot wrote:
Us will always cause problem in Python 3000.


Not, they don't. The u'' prefix has been allowed since Python 3.3, which was released in 2012. Official support for Python 3.2 was dropped in Feb 2016. There is absolutely no reason to remove them, apart from 'it looks nicer'.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, binbot, Framawiki, Xqt, Aklapper, Mpaa, pywikibot-bugs-list, Multichill, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-05-28 Thread binbot 
binbot added a comment.
Then a better piece of advice would be "Remove u only from scripts with no pending changes", wouldn't it? I think a patch only removing us can be revised on express lane.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: binbotCc: binbot, Framawiki, Xqt, Aklapper, Mpaa, pywikibot-bugs-list, Multichill, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-05-28 Thread Multichill 
Multichill added a comment.

In T165911#3296939, @binbot wrote:
@Xqt wrote at the mentioned page: "Anyway we shouldn't change old code for it". Why? Us will always cause problem in Python 3000.


One of the problems we have is 300+ open changesets. If we change u'' to '' now, a lot of these sets will need a manual rebase. That's a pain to do. So we should probably do this in small chunks for parts we don't have a lot of conflicting changes.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: binbot, Framawiki, Xqt, Aklapper, Mpaa, pywikibot-bugs-list, Multichill, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs