[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
gerritbot added a comment. Change 409321 merged by jenkins-bot: [pywikibot/core@master] archivebot: count removed characters when excluding comments etc https://gerrit.wikimedia.org/r/409321TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, gerritbotCc: binbot, Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
gerritbot added a comment. Change 409321 had a related patch set uploaded (by Whym; owner: Whym): [pywikibot/core@master] archivebot: count removed characters when excluding comments etc https://gerrit.wikimedia.org/r/409321TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, gerritbotCc: binbot, Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Tacsipacsi added a comment.
I used the current master code (with some lines added for printing section titles) for testing (so I didn’t have to port anything), with the -simulate option to not archive whole page if it shouldn’t be. The production bot uses a customized (old) version, in which {{függőben}} is hardcoded to prevent archiving (I can’t just submit a patch because of the hardcoding).TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, TacsipacsiCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Dvorapa added a comment. Please provide an example of an unexpected behavior I could test on clean updated pywikibot installation. If there is something wrong I still miss, please file a new task and include: version of python and pwb steps to reproduce code to test (if different from the original) page where wrong behavior occurs command you used TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Dvorapa added a comment. In T182496#3862525, @Tacsipacsi wrote: If you’re speaking about lines 471–474 You should test the whole part (from line 456)TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Tacsipacsi added a comment. The first section of Wikipédia:Járőrök üzenőfala is also not recognized.TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, TacsipacsiCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Dvorapa added a comment. BTW the code you checked is only a half of the code responsible for the thread header recognition...TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Dvorapa added a comment. For me the page hu:User talk:Wegyor works as expected. You can see its history. Have you got updated pywikibot and installed dependencies?TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Tacsipacsi added a comment. The first section doesn’t have a timestamp, so it won’t be archived, but it is a section. The above code (which is the upstream code with three additional lines for debugging) doesn’t check whether the section has a timestamp or not. And the other two sections do have timestamps. It’s a regression of this patch, so it looked obvious for me to reopen this task for it.TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, TacsipacsiCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
gerritbot added a comment. Change 397803 merged by jenkins-bot: [pywikibot/core@master] [bugfix] Make archivebot ignore headers in nowiki, pre, etc. https://gerrit.wikimedia.org/r/397803TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, gerritbotCc: Xqt, gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list, Cpaulf30, Baloch007, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
gerritbot added a comment. Change 397803 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Make archivebot ignore headers in nowiki, pre, etc. https://gerrit.wikimedia.org/r/397803TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Dvorapa added a comment. @Tacsipacsi Sure, the fix should contain all possible exceptions. I looked into the code and I think this fix is not as easy as expected (shame :/ )TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Ato_01, Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T182496: archivebot should ignore section headers within 'nowiki' segments (and commented out segments)
Tacsipacsi added a comment. It should ignore blocks as well (and probably any extension block, though it’s not likely that they contain section header codes).TASK DETAILhttps://phabricator.wikimedia.org/T182496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TacsipacsiCc: Tacsipacsi, revi, Dvorapa, Aklapper, jeblad, Ghouston, whym, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
