[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-03-27 Thread gerritbot
gerritbot added a comment. Change 407517 abandoned by Zoranzoki21: Allow 100 characters per line Reason: Nothing. We have to live with limit. https://gerrit.wikimedia.org/r/407517TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-03-20 Thread Xqt
Xqt added a comment. In T186255#4062984, @Zoranzoki21 wrote: Status of this? Declined for meTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-03-19 Thread Zoranzoki21
Zoranzoki21 added a comment. Status of this?TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-03-13 Thread Xqt
Xqt added a comment. In T186255#4047743, @Zoranzoki21 wrote: Example: T189615 If we disable this, problems like my will not happen. I don't believe it. Could you figure out the problem.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-02 Thread Dalba
Dalba added a comment. In T186255#3939172, @Dvorapa wrote: In these days of 16:9 monitors and 1920x1080 resolutions (usual notebook for everyday use) it is funny to restrict lines to a third of a monitor just to be able to make 3-way comparison? Or why? The screen resolution of my desktop

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-02 Thread Zoranzoki21
Zoranzoki21 added a comment. Patch is fixed now.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: zhuyifei1999, XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-02 Thread Xqt
Xqt added a comment. Sure but urls are ignored by that rule for good reasons.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: XZise, Mpaa, gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Xqt
Xqt added a comment. Sure but urls are ignored by that rule for good reasons.TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Dvorapa
Dvorapa added a comment. Well, for example Gerrit, on my current machine, 7 years old laptop, 15.6'' 1366x768, can almost handle 100 chars side-by-side (I think 96 or so, but I have got a dock on the left side of the screen. Otherwise it would be over 100. See screenshot). But I am going to buy a

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Xqt
Xqt added a comment. @Dvorava: let’s have a Monitor with 1920 dots resolution so see patch diffs side by side in a normal char size of 12 points. Gives 80 chars. Ok say 10 points is enough. But you need some frames an line numbers. I think this is a good reason for 80 chars limit. Or take python‘s

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407517 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21): [pywikibot/core@master] Allow 100 characters per line https://gerrit.wikimedia.org/r/407517TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407507 abandoned by Zoranzoki21: Revert "tox.ini: Configure Jenkins to fail when lines are longer than 79 characters" Reason: I have problem with cannot merge. I will upload new change https://gerrit.wikimedia.org/r/407507TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Dvorapa
Dvorapa added a comment. In T186255#3939126, @Xqt wrote: Don‘t see any reason to ignore PEP8 especially for new lines. Well, PEP8 allows 80–100 if a community is decided to allow more And btw it is very easy to keep the changed lines below 80 chars. In these days of 16:9 monitors and

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407507 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21): [pywikibot/core@master] Revert "tox.ini: Configure Jenkins to fail when lines are longer than 79 characters" https://gerrit.wikimedia.org/r/407507TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Zoranzoki21
Zoranzoki21 added a comment. In T186255#3939126, @Xqt wrote: Dont Why?TASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Xqt
Xqt added a comment. DontTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: jayvdb, Framawiki, Dalba, Magul, valhallasw, Xqt, pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line also for new code

2018-02-01 Thread Dvorapa
Dvorapa added a comment. @demon Yeah, it wasTASK DETAILhttps://phabricator.wikimedia.org/T186255EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: pywikibot-bugs-list, demon, Dvorapa, Zoranzoki21, Aklapper, Magul, Tbscho, rafidaslam, MayS, Framawiki,

[Pywikipedia-bugs] [Maniphest] [Commented On] T186255: [RFC] Allow 100 characters per line

2018-02-01 Thread Dvorapa
Dvorapa added a comment. I was a little bit confused in https://gerrit.wikimedia.org/r/#/c/372064. Jenkins added +1. After a few months I uploaded a new file, but the old left unchanged and Jenkins complained about the unchanged file! It looks like there is a hidden limit for diff to make line