gerritbot added a comment.
Change 407717 merged by jenkins-bot:
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407717TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/
gerritbot added a comment.
Change 407717 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407717TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://p
gerritbot added a comment.
Change 407631 merged by jenkins-bot:
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407631TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/
gerritbot added a comment.
Change 407631 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test
https://gerrit.wikimedia.org/r/407631TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://p
Dvorapa added a comment.
:facepalm:TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayv
Dalba added a comment.
The first argument of pywikibot.Link should be text. The second argument is the source.TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dvorapa, Aklapper, pywikibot-bugs-list, D
Dvorapa added a comment.
It seems to me as if unittest correctly handles family and code into correct Site object (line 25 is OK), but DisambiguationRobot or get_disambiguation_links breaks Site or redefine Site not correctly somehow.TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERE
Dvorapa added a comment.
Well, it should be.. https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/scripts/solve_disambiguation.py;20f5463cd2fed1d99fab88fd391940a3e0695d00$674TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa
Dvorapa added a comment.
The site should be crated by the DisambiguationRobot initializer. Is it?TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Magul
Dvorapa added a comment.
Why self.site isn't a Site object? unittest library in Python is sometimes so unintuitive..TASK DETAILhttps://phabricator.wikimedia.org/T186316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs
10 matches
Mail list logo