[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-08-19 Thread gerritbot
gerritbot added a comment. Change 445956 abandoned by Xqt: In return statement of RecentChangesPageGenerator if rcstart > rcend then reverse = True and when rcstart < rcend then reverse = False Reason: https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /445392/ https://gerrit.wikimedia.org/r/4459

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-08-19 Thread gerritbot
gerritbot added a comment. Change 445392 merged by jenkins-bot: [pywikibot/core@master] pagegenerators._handle_recentchanges: Do not request for reversed results https://gerrit.wikimedia.org/r/445392TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia.

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-29 Thread gerritbot
gerritbot added a comment. Change 445994 abandoned by Xqt: In function def RecentChangesPageGenerator swap the values of start and end if reverse = True Reason: https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /445956/ https://gerrit.wikimedia.org/r/445994TASK DETAILhttps://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-16 Thread gerritbot
gerritbot added a comment. Change 445994 had a related patch set uploaded (by AdityaJ; owner: AdityaJ): [pywikibot/core@master] In function def RecentChangesPageGenerator swap the values of start and end if reverse = True https://gerrit.wikimedia.org/r/445994TASK DETAILhttps://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-16 Thread gerritbot
gerritbot added a comment. Change 445956 had a related patch set uploaded (by AdityaJ; owner: AdityaJ): [pywikibot/core@master] In return statement of RecentChangesPageGenerator if rcstart > rcend then reverse = True and when rcstart < rcend then reverse = False https://gerrit.wikimedia.org/r/4459

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445392 had a related patch set uploaded (by Zhuyifei1999; owner: AdityaJ): [pywikibot/core@master] Changed "reverse" argument of RecentChangesPageGenerator function to False https://gerrit.wikimedia.org/r/445392TASK DETAILhttps://phabricator.wikimedia.org/T199199E

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445388 merged by jenkins-bot: [pywikibot/core@master] Revert "Changed "reverse" argument of RecentChangesPageGenerator function to False" https://gerrit.wikimedia.org/r/445388TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-12 Thread zhuyifei1999
zhuyifei1999 added a comment. @Dalba I think jenkins hates me, and I gtg in a few minutes. Could you get the revert merged and cherry pick the original patch to master so we can build upon the original patch?TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wi

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445388 had a related patch set uploaded (by Zhuyifei1999; owner: Zhuyifei1999): [pywikibot/core@master] Revert "Changed "reverse" argument of RecentChangesPageGenerator function to False" https://gerrit.wikimedia.org/r/445388TASK DETAILhttps://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445338 merged by jenkins-bot: [pywikibot/core@master] Changed "reverse" argument of RecentChangesPageGenerator function to False https://gerrit.wikimedia.org/r/445338TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-11 Thread gerritbot
gerritbot added a comment. Change 445338 had a related patch set uploaded (by AdityaJ; owner: AdityaJ): [pywikibot/core@master] Change from reverse=True to reverse=False https://gerrit.wikimedia.org/r/445338TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wi

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-11 Thread gerritbot
gerritbot added a comment. Change 445338 had a related patch set uploaded (by AdityaJ; owner: AdityaJ): [pywikibot/core@master] Fix Bug: T199199 Change-Id: I82368306a55f83def475ec9941a472542feba3a4 https://gerrit.wikimedia.org/r/445338TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFE

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-11 Thread Dvorapa
Dvorapa added a comment. In T199199#4415245, @AdityaJ wrote: I am interesting in taking this up. Should I go ahead and make reverse = False ? Let's do it! :)TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T199199: Documentation of -recentchanges is misleading

2018-07-11 Thread AdityaJ
AdityaJ added a comment. I am interesting in taking this up. Should I go ahead and make reverse = False ?TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AdityaJCc: AdityaJ, Xqt, darthbhyrava, Dalba, Aklapper,