[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-08-06 Thread gerritbot
gerritbot added a comment. Change 364475 merged by jenkins-bot: [pywikibot/core@master] [IMPR] Enhance argument management in harvest_template.py https://gerrit.wikimedia.org/r/364475TASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pane

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-11 Thread gerritbot
gerritbot added a comment. Change 364475 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [IMPR] Enhance argument management in harvest_template.py https://gerrit.wikimedia.org/r/364475TASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PREF

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-10 Thread XXN
XXN added a comment. To be clearer, there are templates which are concatenating variable values from articles with some predefined prefixes/sufixes from template to form a page title. For example: https://en.wikipedia.org/w/index.php?title=Template:Infobox_French_commune https://en.wikipedia.org/w/

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-10 Thread XXN
XXN added a comment. In T64014#3418906, @matej_suchanek wrote: If this is to be an optional feature, an overhaul needs to be done to the script. IMO this feature should be implemented ONLY as optional, because it is not always safe to import blindly any unliked value, and they could be imported

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-09 Thread gerritbot
gerritbot added a comment. Change 364117 merged by jenkins-bot: [pywikibot/core@master] [DNM] Add support for item without link to harvest_template https://gerrit.wikimedia.org/r/364117TASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-09 Thread matej_suchanek
matej_suchanek added a comment. https://gerrit.wikimedia.org/r/364117 Uploaded a refactored version of T64014#2121595. I think Pasleim's harvest_template analogue already has such a feature enabled. Yes, it does. Unlike PWB, HarvestTemplates allows only a single parameter to be parsed. If this i

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-09 Thread gerritbot
gerritbot added a comment. Change 364117 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [DNM] Add support for item without link to harvest_template https://gerrit.wikimedia.org/r/364117TASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PR

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-08 Thread XXN
XXN added a comment. Regarding the proposed patch(es) above. Since we don't want *always* to treat any plain text in template parameters as a unlinked wikilink and to try to find their item, more code is needed here to define the new option as an optional feature. While for individual tasks for per

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-07 Thread JAnD
JAnD added a comment. In T64014#3415342, @Xqt wrote: I checked your code subitted above and I found out that your local repository is 3 years behind the current framework release. Please update your bot first and verify whether this bug still exists. Yes, bug still exists, harvest_template.py ca

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-07 Thread Xqt
Xqt added a comment. patch failed: git.exe am --ignore-space-change "C:\pwb\GIT\core\ht_patch.patch" Patch format detection failed. FailTASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: matej_suchanek,

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2017-07-07 Thread JAnD
JAnD added a comment. is there anybody who is able to merge this patch?TASK DETAILhttps://phabricator.wikimedia.org/T64014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JAnDCc: valhallasw, Xqt, Ricordisamoa, Aklapper, JAnD, pywikibot-bugs-list, Magul, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2016-03-15 Thread JAnD
JAnD added a comment. In https://phabricator.wikimedia.org/T64014#2122183, @Xqt wrote: > See : > https://www.mediawiki.org/wiki/Gerrit_patch_uploader > https://tools.wmflabs.org/gerrit-patch-uploader/ Result from uploading patch: /data/project/gerrit-patch-upload

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2016-03-15 Thread Xqt
Xqt added a comment. > I tried to upload it via uploader, but I don't know, where is it now. See : https://www.mediawiki.org/wiki/Gerrit_patch_uploader https://tools.wmflabs.org/gerrit-patch-uploader/ TASK DETAIL https://phabricator.wikimedia.org/T64014 EMAIL PREFERENCES https://

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2016-03-15 Thread JAnD
JAnD added a comment. I tried to upload it via uploader, but I don't know, where is it now. I tried to run git on windows, but it was too difficult for me There is some ugly patch including commnted old part of code + already merged patch for external-id originally form https://www.w

[Pywikipedia-bugs] [Maniphest] [Commented On] T64014: Add support for item without link to harvest_template

2016-03-15 Thread Ricordisamoa
Ricordisamoa added a comment. @JAnD see https://www.mediawiki.org/wiki/Gerrit/Tutorial or https://tools.wmflabs.org/gerrit-patch-uploader/ TASK DETAIL https://phabricator.wikimedia.org/T64014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JAnD,