[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[Xqt]

Xqt changed the subtype of this task from "Task" to "Bug Report".

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[Xqt]

Xqt removed a project: TestMe.

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[gerritbot]

gerritbot added a project: Patch-For-Review.
Restricted Application removed a project: Patch-Needs-Improvement.

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[Pppery]

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pppery
Cc: matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, gerritbot, Xqt, 
Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, PotsdamLamb, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Framawiki, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
Ricordisamoa, Masti, Alchimista, Themindcoder, Adamm71, Jersione, Hellket777, 
LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan, Neuronton
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[Xqt]

Xqt added a comment.


  See also T107537  for Flow

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, gerritbot, Xqt, 
Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, 
Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, 
WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[matej_suchanek]

matej_suchanek removed a project: Easy.matej_suchanek moved this task from Backlog to Data loading problems on the Pywikibot-Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T145971WORKBOARDhttps://phabricator.wikimedia.org/project/board/110/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, matej_suchanekCc: matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Ricordisamoa, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[Multichill]

Multichill added a comment.
FYI, on my not yet updated 6b8c01d, g7574, 2016/11/10, 09:32:07, n/a :

mdammers@bingo:~/pywikibot$ python
Python 2.7.6 (default, Jun 22 2015, 17:58:13) 
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pywikibot
>>> s = pywikibot.Site('en', 'wikipedia')
>>> r = s.data_repository()
>>> p = pywikibot.PropertyPage(r, 'P38')
>>> p.exists()
True
>>>

Maybe go back to my plan A?:

if not hasattr(self, '_content'):
try:
self.get()
return True
 except pywikibot.IsRedirectPage
 return True
except pywikibot.NoPage:
return False
return 'lastrevid' in self._content

Yes, this will also return True if the redirect is to a deleted page, but that's quite an extreme edge case and if you follow a redirect you should do your checks again anyway for the target.

We should probably add tests to " TestPropertyPage" to test exists().TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MultichillCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

[gerritbot]

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Esc3300, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs