jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/433602 )
Change subject: [bugfix] re-enable WikibaseKnownTypesTests
......................................................................
[bugfix] re-enable WikibaseKnownTypesTests
test wiki uses unsupported 'wikibase-form' and 'wikibase-lexeme
Bug: T194890
Change-Id: Ia8d7de5cdf59375945f4601ab8f1662b07f5cf6b
---
M tests/paraminfo_tests.py
1 file changed, 14 insertions(+), 3 deletions(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/paraminfo_tests.py b/tests/paraminfo_tests.py
index 6a0fc60..121e0ff 100644
--- a/tests/paraminfo_tests.py
+++ b/tests/paraminfo_tests.py
@@ -220,13 +220,24 @@
def test_entities(self):
"""Test known entities."""
- known = ['item', 'property']
- self._check_param_values(self.repo, 'wbsearchentities', 'type', known)
+ unsupported = []
+
+ if self.site.sitename in ('test:test', 'wikidata:test'):
+ unsupported = ['form', 'lexeme'] # T194890
+
+ supported = ['item', 'property']
+ known = supported + unsupported
+ if unsupported:
+ self._check_param_superset(
+ self.repo, 'wbsearchentities', 'type', known)
+ else:
+ self._check_param_values(
+ self.repo, 'wbsearchentities', 'type', known)
# Missing datatypes won't crash pywikibot but should be noted
def test_datatypes(self):
"""Test that all encountered datatypes are known."""
- unsupported = set()
+ unsupported = {'wikibase-form', 'wikibase-lexeme'} # T194890
known = set(Property.types) | unsupported
self._check_param_superset(
self.repo, 'wbformatvalue', 'datatype', known)
--
To view, visit https://gerrit.wikimedia.org/r/433602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8d7de5cdf59375945f4601ab8f1662b07f5cf6b
Gerrit-Change-Number: 433602
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Dalba <dalba.w...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
Pywikibot-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
