Re: Coding Style

2014-06-03 Thread Nick Coghlan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/2014 02:01 PM, Tim Flink wrote: > Of the concerns you raised, I'm not terribly opposed to most of > them other than E128 and E122. I'm not crazy about dropping E265, > though. One thing to watch with pep8 is it has the notion of "ignored by d

Re: Coding Style

2014-06-03 Thread Tim Flink
On Tue, 3 Jun 2014 09:29:49 -0400 (EDT) Kamil Paral wrote: > > Outside any header requirements or directive documentation > > requirements, are there any changes to PEP8 that folks want to > > make? If so, please list the exceptions and why you think they > > should be adopted. > > E251 ===

Re: Coding Style

2014-06-03 Thread Tim Flink
On Tue, 3 Jun 2014 09:44:42 -0400 (EDT) Kamil Paral wrote: > > How about: > > > > [FORMAT] > > # Maximum number of characters on a single line. > > max-line-length=100 > > > > /me has no problem with 80 chars, but most of my monitors can > > easily handle two 100-char on one vertically sp

Re: Coding Style

2014-06-03 Thread Josef Skladanka
> But if there's a strong desire for more columns, I'll manage. Can't hinder > the team, can I? :) Also, we should mention that by default the maximal line length is set to 79, not 80. Let's just set it to 80 (as we already use it in the code), and forget about the heretic 100 idea :) _

Re: Coding Style

2014-06-03 Thread Josef Skladanka
First of all - forget the max-line-length comment from earlier... I went through the pep8's configuration options, and there is basically next to none, so the overall decision will mostly need to be "keep it or drop it". > E251 = > Josef is used to add spaces between keyword name and it

Re: Coding Style

2014-06-03 Thread Kamil Paral
> How about: > > [FORMAT] > # Maximum number of characters on a single line. > max-line-length=100 > > /me has no problem with 80 chars, but most of my monitors can easily handle > two 100-char on one vertically split-view in vim (and 80 chars is sometimes > quite a pain) Traitor! I can't

Re: Coding Style

2014-06-03 Thread Kamil Paral
> Outside any header requirements or directive documentation requirements, > are there any changes to PEP8 that folks want to make? If so, please > list the exceptions and why you think they should be adopted. E251 = libtaskotron/directives/bodhi_comment_directive.py:247:67: E251 unexpec

Re: Coding Style

2014-06-03 Thread Josef Skladanka
> Outside any header requirements or directive documentation requirements, > are there any changes to PEP8 that folks want to make? If so, please > list the exceptions and why you think they should be adopted. How about: [FORMAT] # Maximum number of characters on a single line. max-line-len