Re: making test suites work the same way

2017-02-08 Thread Tim Flink
On Fri, 3 Feb 2017 17:05:04 -0500 (EST) Kamil Paral wrote: > I spent a bit of time fixing minor issues in our test suite and > makefiles and would like to do the following further changes across > all our taskotron projects: > > 1. run the test suite while inside virtualenv with simple `pytest`

Re: making test suites work the same way

2017-02-06 Thread Josef Skladanka
+1 I'm glad that our usual flame-war yielded a common ground that we can agree upon :) Hope that it was not as painfull as usual. J. On Mon, Feb 6, 2017 at 6:04 PM, Kamil Paral wrote: > Well, after more discussions with kparal, we are still unsure about the > "right" way to tackle this. > Our c

Re: making test suites work the same way

2017-02-06 Thread Kamil Paral
> Well, after more discussions with kparal, we are still unsure about the > "right" way to tackle this. > Our current call would be: > 1) sync requirements.txt versions with fedora (mostly done) > 2) allow --system-site-packages in the test_env > 3) do `pip install -r requirements.txt` (with possib

Re: making test suites work the same way

2017-02-06 Thread Josef Skladanka
Well, after more discussions with kparal, we are still unsure about the "right" way to tackle this. Our current call would be: 1) sync requirements.txt versions with fedora (mostly done) 2) allow --system-site-packages in the test_env 3) do `pip install -r requirements.txt` (with possible flags to

Re: making test suites work the same way

2017-02-06 Thread Kamil Paral
> > 3. use a separate virtualenv when running under `make test`, without > > --system-site-packages if possible, and ensure up-to-date deps are always > > installed, to eliminate any differences that can occur on different setups > > > The only problem I see here, is that some of the packages tha

Re: making test suites work the same way

2017-02-06 Thread Josef Skladanka
On Mon, Feb 6, 2017 at 1:35 PM, Kamil Paral wrote: > > That's a good point. But do we have a good alternative here? If we depend > on packages like that, I see only two options: > > a) ask the person to install pyfoo as an RPM (in readme) > b) ask the person to install gcc and libfoo-devel as an

Re: making test suites work the same way

2017-02-06 Thread Kamil Paral
> On Fri, Feb 3, 2017 at 11:05 PM, Kamil Paral < kpa...@redhat.com > wrote: > > I spent a bit of time fixing minor issues in our test suite and makefiles > > and > > would like to do the following further changes across all our taskotron > > projects: > > > 1. run the test suite while inside vir

Re: making test suites work the same way

2017-02-04 Thread Josef Skladanka
On Fri, Feb 3, 2017 at 11:05 PM, Kamil Paral wrote: > I spent a bit of time fixing minor issues in our test suite and makefiles > and would like to do the following further changes across all our taskotron > projects: > > 1. run the test suite while inside virtualenv with simple `pytest` command