Re: New ExecDB

2016-10-11 Thread Kamil Paral
> Proposal looks good to me, I don't have any strong objections. > 1. If you don't like blame: UNIVERSE, why not use blame: TESTBENCH? > 2. I think that having enum values in details in crash structure would be > better, but I don't have strong opinion either way. For consistency checking, yes.

Re: New ExecDB

2016-10-11 Thread Kamil Paral
> With ResultsDB and Trigger rewrite done, I'd like to get started on ExecDB. > The current ExecDB is more of a tech-preview, that was to show that it's > possible to consume the push notifications from Buildbot. The thing is, that > the code doing it is quite a mess (mostly because the

Re: New ExecDB

2016-10-11 Thread Jan Sedlak
Proposal looks good to me, I don't have any strong objections. 1. If you don't like blame: UNIVERSE, why not use blame: TESTBENCH? 2. I think that having enum values in details in crash structure would be better, but I don't have strong opinion either way. Jan