Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Epting, Thomas
> I didn’t do any measurements, but quick search for QList in Qbs > source code shows a lot of places where it’s used incorrectly – > it stores «big» structures, std::shared_pointers, even all > QSharedDataPointer classes are not marked as Q_MOVABLE_TYPE > and thus result in extra allocations

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Christian Gagneraud
On Thu, 16 May 2019 at 11:24, Иван Комиссаров wrote: > > In many cases, you don’t need to copy them. For trivial getters, you can > return const-ref/span to the internal vector instead of a copy because in > many places all we do is iterate over that vector. > > The only argument for copies is

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Иван Комиссаров
In many cases, you don’t need to copy them. For trivial getters, you can return const-ref/span to the internal vector instead of a copy because in many places all we do is iterate over that vector. The only argument for copies is that it’s impossible to change the implementation from returning

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Christian Gagneraud
On Thu, 16 May 2019 at 09:32, Иван Комиссаров wrote: > > 15 мая 2019 г., в 19:50, André Pönitz написал(а): > > > > Getting rid of implicitly shared containers should be a rather obvious move > > when "performance" is part of any "final picture", coherent or not. > > +1 from me, hidden detaches

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Иван Комиссаров
+1 from me, hidden detaches are evil =) > 15 мая 2019 г., в 19:50, André Pönitz написал(а): > > Getting rid of implicitly shared containers should be a rather obvious move > when "performance" is part of any "final picture", coherent or not. > > Andre' >

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread André Pönitz
On Wed, May 15, 2019 at 11:38:25AM +0200, Oswald Buddenhagen wrote: > [...] > jake had started that "qt-free qbs" project (he got as far as > eliminating (most) use of qt containers), but it was snuffed out because > it was unrealistic and counterproductive at that time. even now, no > patches in

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Иван Комиссаров
Interesting. Any idea why Qbs is so slow with ccache? Иван Комиссаров > 15 мая 2019 г., в 17:29, Orgad Shaneh написал(а): > > du -shc build-qtc-qbs > 15G build-qtc-qbs > 15G total > du -shc build-qtc-cmake > 4.0Gbuild-qtc-cmake > 4.0Gtotal > > The number of jobs is default.

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Orgad Shaneh
du -shc build-qtc-qbs 15G build-qtc-qbs 15G total du -shc build-qtc-cmake 4.0Gbuild-qtc-cmake 4.0Gtotal The number of jobs is default. For qbs it's 40, ninja uses 42. I tried again without autotests, as Christian suggested: time qbs -f ../qt-creator/qtcreator.qbs

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Vincent Hui
How many number of threads were used? Is the number of threads used by Qbs equal to the number of threads used by CMake? On Wed, 15 May 2019 at 22:11, Christian Kandeler wrote: > On Thu, 16 May 2019 02:01:21 +1200 > Christian Gagneraud wrote: > > > As well, please note that the current CMake

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Christian Kandeler
On Thu, 16 May 2019 02:01:21 +1200 Christian Gagneraud wrote: > As well, please note that the current CMake doesn't build as much > stuff as the qbs one. Not sure the difference is huge, but you need to > compare "equal jobs". For instance, all autotests are missing from the cmake build, so

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Christian Gagneraud
On Thu, 16 May 2019 at 01:45, Orgad Shaneh wrote: > > I compared qbs and cmake/ninja, and got these results (Debug build, no QbsPM > and no Clang): > > Notice that qbs builds unit tests, which cmake doesn't. > > time qbs -f ../qt-creator/qtcreator.qbs profile:qt-5-11-1 >

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Orgad Shaneh
I compared qbs and cmake/ninja, and got these results (Debug build, no QbsPM and no Clang): Notice that qbs builds unit tests, which cmake doesn't. time qbs -f ../qt-creator/qtcreator.qbs profile:qt-5-11-1 modules.cpp.compilerWrapper:ccache cold ccache: real5m26.149s user125m3.443s sys

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Epting, Thomas
> I would like to see qbs as a supported build system in Creator for as long > as it does not > cause too much hassle to do so. That is no different to any of the other > plugins Creator > has. Side note: I plan to take care of the qbsprojectmanager plugin (not Qbs itself) in the future.

Re: [Qbs] Donation to QBS developers/maintainers/contributes

2019-05-15 Thread Oswald Buddenhagen
On Tue, May 14, 2019 at 04:17:41PM +0200, Иван Комиссаров wrote: > Qbs itself has a huge dependency on a QtCore, but some stuff is > present in standard library and can be easily changed to that (we > still have enourmous amount of places where qlist is used instead of a > qvector/std::vector and

Re: [Qbs] Who compared build times of Qt Creator with CMake and qbs?

2019-05-15 Thread Tobias Hunger
Hi Richard, I can only provide an opinion, it is not my place to make decisions. On Tue, 2019-05-14 at 20:42 +0200, Richard Weickelt wrote: > Tobias, > > I think it is of utmost importance for the survival of Qbs that it is fully > supported by an IDE like QtCreator. I would like to see qbs as