On 09/13/2017 12:03 PM, Eric Blake wrote:
> Previously, the alloc command required that input parameters be
> sector-aligned and clamped to 32 bits, because the underlying
> bdrv_is_allocated used a 32-bit parameter and asserted aligned
> inputs. But now that we have fixed block status to report
On 09/13/2017 12:03 PM, Eric Blake wrote:
> Now that bdrv_is_allocated accepts non-aligned inputs, we can
> remove the TODO added in commit d6a644bb.
>
> Signed-off-by: Eric Blake
Reviewed-by: John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote:
> Any device that has request_alignment greater than 512 should be
> unable to report status at a finer granularity; it may also be
> simpler for such devices to be guaranteed that the block layer
> has rounded things out to the granularity boundary (the
On Tue, Sep 26, 2017 at 04:31:22PM +0200, Nicolas Ecarnot wrote:
> Le 21/09/2017 à 16:31, Stefan Hajnoczi a écrit :
> > On Tue, Sep 19, 2017 at 12:09:06PM +0200, Nicolas Ecarnot wrote:
> > > Hello,
> > >
> > > First post here, so maybe I should introduce myself :
> > > - I'm a sysadmin for decades
On Sat, Sep 30, 2017 at 02:53:43PM -0500, Eric Blake wrote:
> Make it possible to inject errors on writes performed during a
> read operation due to copy-on-read semantics.
>
> Signed-off-by: Eric Blake
> ---
> qapi/block-core.json | 5 -
> block/io.c | 1 +
> 2 files changed, 5 in
On Sat, Sep 30, 2017 at 02:53:42PM -0500, Eric Blake wrote:
> Make it easier to enable copy-on-read during iotests, by
> exposing a new bool option to main and open.
>
> Signed-off-by: Eric Blake
> ---
> qemu-io.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Reviewed
On 09/30/2017 03:53 PM, Eric Blake wrote:
> Make it possible to inject errors on writes performed during a
> read operation due to copy-on-read semantics.
>
> Signed-off-by: Eric Blake
I suppose our docs DO say "ehh, see block-core.json" so I suppose no
update is necessary :)
Reviewed-by: Joh
On 09/30/2017 03:53 PM, Eric Blake wrote:
> Make it easier to enable copy-on-read during iotests, by
> exposing a new bool option to main and open.
>
> Signed-off-by: Eric Blake
Reviewed-by: John Snow
Am 25.09.2017 um 16:55 hat Eric Blake geschrieben:
> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
> but NBD wants to report status on byte granularity (even if the
> reporting will probably be naturally aligned to sectors or even
> much higher levels). I've therefore started the
02.10.2017 18:38, Eric Blake wrote:
On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all. Here is a continuation of my "new backup architecture" series,
The very first part, but it is meaningful itself.
01: was previously sent in other my series, but here is more correct
vers
02.10.2017 18:43, Eric Blake wrote:
On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
The function searches for next zero bit.
Also add interface for BdrvDirtyBitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 1 +
include/qemu/hbitmap.h
Am 25.09.2017 um 17:46 hat Eric Blake geschrieben:
> On 09/25/2017 10:23 AM, Vladimir Sementsov-Ogievskiy wrote:
> > 25.09.2017 17:55, Eric Blake wrote:
> >> We've previously fixed several places where we failed to account
> >> for possible errors from bdrv_nb_sectors(). Fix another one by
> >> ma
On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
> The function searches for next zero bit.
> Also add interface for BdrvDirtyBitmap.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/dirty-bitmap.h | 1 +
> include/qemu/hbitmap.h | 8
> block/dirt
On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all. Here is a continuation of my "new backup architecture" series,
> The very first part, but it is meaningful itself.
>
> 01: was previously sent in other my series, but here is more correct
> version, one mistake is fixed.
> 0
Am 02.10.2017 um 17:01 hat Kashyap Chamarthy geschrieben:
> On Tue, Sep 26, 2017 at 07:59:42PM +0200, Kevin Wolf wrote:
>
> [...]
>
> > In comparison with the old command, the important changes are:
> >
> > * top/base are node names instead of file names.
> >
> > * You don't need to specify
On 10/02/2017 09:03 AM, Markus Armbruster wrote:
> -iscsi ended up under the "Device URL Syntax" heading by a sequence of
> errors, as explained in the previous commit. Move it under the "Block
> device options" heading. Nothing left under "Device URL Syntax";
> drop the heading.
>
> Cc: Ronnie
On 10/02/2017 09:03 AM, Markus Armbruster wrote:
> Commit 0f5314a (v1.0) added section "Device URL Syntax" to
> qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
> qemu-options.texi, not --help. It appears as a subsection under
> section "Invocation". Similarly, qemu.1 has it as
On 10/02/2017 09:03 AM, Markus Armbruster wrote:
> Cc: Ronnie Sahlberg
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: qemu-bl...@nongnu.org
> Signed-off-by: Markus Armbruster
> ---
> qemu-options.hx | 6 ++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Eric Blake
> diff --git a/qemu-options
On 10/02/2017 09:50 AM, Kevin Wolf wrote:
>> The warning is a false negative (the error message is actually pointing
>> to a line in bdrv_co_do_copy_on_readv - but the compiler must have
>> inlined it into bdrv_aligned_preadv) - the function is only ever called
>> with non-zero bytes, and therefor
On Tue, Sep 26, 2017 at 07:59:42PM +0200, Kevin Wolf wrote:
[...]
> In comparison with the old command, the important changes are:
>
> * top/base are node names instead of file names.
>
> * You don't need to specify the active layer any more (not the least
> because there could very wel
Am 30.09.2017 um 21:53 hat Eric Blake geschrieben:
> Make it easier to enable copy-on-read during iotests, by
> exposing a new bool option to main and open.
>
> Signed-off-by: Eric Blake
Reviewed-by: Kevin Wolf
Am 30.09.2017 um 21:53 hat Eric Blake geschrieben:
> Make it possible to inject errors on writes performed during a
> read operation due to copy-on-read semantics.
>
> Signed-off-by: Eric Blake
Reviewed-by: Kevin Wolf
Am 01.10.2017 um 00:05 hat Eric Blake geschrieben:
> On 09/30/2017 04:19 PM, no-re...@patchew.org wrote:
> > Hi,
> >
> > This series failed build test on s390x host. Please find the details below.
> >
>
> > /var/tmp/patchew-tester-tmp-a2p2tpcc/src/block/io.c: In function
> > ‘bdrv_aligned_pread
We can use copy_bitmap instead of sync_bitmap. copy_bitmap is
initialized from sync_bitmap and it is more informative: we will not try
to process data, that is already in progress (by write notifier).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Stefan Hajnoczi
---
block/backup.c |
Hi all. Here is a continuation of my "new backup architecture" series,
The very first part, but it is meaningful itself.
01: was previously sent in other my series, but here is more correct
version, one mistake is fixed.
02: only rebased to new byte-based interfaces (by Eric), r-bs saved
03: c
Use HBitmap copy_bitmap instead of done_bitmap. This is needed to
improve incremental backup in following patches and to unify backup
loop for full/incremental modes in future patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
---
block/bac
We should not copy non-dirty clusters in write notifiers. So,
initialize copy_bitmap from sync_bitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 45 -
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/block/backup.c b
Set fake progress for non-dirty clusters in copy_bitmap initialization,
to. It simplifies code and allows further refactoring.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Motivation (some of these paragraphs may be needed in commit message...)
1. Current behavior is not good: setting fake p
The function searches for next zero bit.
Also add interface for BdrvDirtyBitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 1 +
include/qemu/hbitmap.h | 8
block/dirty-bitmap.c | 5 +
util/hbitmap.c | 29 +++
On Fri, Sep 29, 2017 at 05:14:58PM -0700, Alistair Francis wrote:
> Replace all occurs of __FUNCTION__ except for the check in checkpatch
> with the non GCC specific __func__.
>
> One line in hcd-musb.c was manually tweaked to pass checkpatch.
>
> Signed-off-by: Alistair Francis
> Cc: Gerd Hoffm
On Mon, Oct 02, 2017 at 08:55:50AM -0500, Eric Blake wrote:
> On 09/30/2017 10:03 PM, Jeff Cody wrote:
> > On Sat, Sep 30, 2017 at 03:11:21PM -0500, Eric Blake wrote:
> >> Add a test for qcow2 copy-on-read behavior, including exposure
> >> for the just-fixed bugs.
> >>
> >> The copy-on-read behavio
Commit 0f5314a (v1.0) added section "Device URL Syntax" to
qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
qemu-options.texi, not --help. It appears as a subsection under
section "Invocation". Similarly, qemu.1 has it as a subsection under
"OPTIONS".
Commit f9dadc9 (v1.1.0) dr
-iscsi ended up under the "Device URL Syntax" heading by a sequence of
errors, as explained in the previous commit. Move it under the "Block
device options" heading. Nothing left under "Device URL Syntax";
drop the heading.
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongn
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
---
qemu-options.hx | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index c647fdde62..8568ee388c 100644
--- a/qemu-options.hx
+++ b/qemu-optio
On 09/30/2017 10:03 PM, Jeff Cody wrote:
> On Sat, Sep 30, 2017 at 03:11:21PM -0500, Eric Blake wrote:
>> Add a test for qcow2 copy-on-read behavior, including exposure
>> for the just-fixed bugs.
>>
>> The copy-on-read behavior is always to a qcow2 image, but the
>> test is careful to allow runnin
Max Reitz writes:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> Signed-off-by: Max Reitz
> ---
> tests/Makefile.include | 4 +-
> tests/check-qobject.c | 315
> +
25.09.2017 18:49, Vladimir Sementsov-Ogievskiy wrote:
I have a patch on list, which adds hbitmap_next_zero function, it may
help
https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00809.html
there is a mistake in this hbitmap_next_zero, I'll send today corrected
version as part of sm
Max Reitz writes:
> This generic function (along with its implementations for different
> types) determines whether two QObjects are equal.
>
> Signed-off-by: Max Reitz
Reviewed-by: Markus Armbruster
Max Reitz writes:
> Signed-off-by: Max Reitz
Reviewed-by: Markus Armbruster
Max Reitz writes:
> Signed-off-by: Max Reitz
Reviewed-by: Markus Armbruster
Am 15.08.2017 um 10:18 hat Manos Pitsidianakis geschrieben:
> With runtime insertion and removal of filters, write-threshold.c can
> provide more flexible deliveries of BLOCK_WRITE_THRESHOLD events. After
> the event trigger, the filter nodes are no longer useful and must be
> removed.
> The existi
Am 15.08.2017 um 10:18 hat Manos Pitsidianakis geschrieben:
> block/backup.c currently uses before write notifiers on the targeted
> node. We can create a filter node instead to intercept write requests
> for the backup job on the BDS level, instead of the BlockBackend level.
>
> This is part of d
On 12/09/2017 16:44, Paolo Bonzini wrote:
> The purpose of this series is to separate the "check" sources from
> the tests. After these patches, common.config is reduced to simple
> shell initialization, and common.rc is only included by the tests.
>
> Along the way, a lot of dead code is removed
43 matches
Mail list logo