Re: [Qemu-block] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename

2017-09-29 Thread John Snow
On 09/28/2017 08:03 AM, Vladimir Sementsov-Ogievskiy wrote: > Backing may be zero after failed bdrv_attach_child in > bdrv_set_backing_hd, which leads to SIGSEGV. > I guess in this case we trust bdrv_set_backing_hd to carry the errp parameter back to the caller indicating that not only did we

Re: [Qemu-block] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename

2017-09-29 Thread Max Reitz
On 2017-09-28 14:03, Vladimir Sementsov-Ogievskiy wrote: > Backing may be zero after failed bdrv_attach_child in > bdrv_set_backing_hd, which leads to SIGSEGV. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Thanks, applied to my block branch: