Re: [Qemu-block] [Qemu-devel] [RFC 02/10] fdc: add default drive type option

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: We want to change the current default drive type, but to be kind, we need to allow users to specify the old drive type somehow. Uh, what is *this* commit about? as far as I can tell, it adds drive type properties (not a default drive type option), but

Re: [Qemu-block] [Qemu-devel] [PATCH] opts: produce valid command line in qemu_opts_print

2015-07-03 Thread Kővágó Zoltán
2015-07-03 15:01 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list,

Re: [Qemu-block] [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: This one is the crazy one. I'm afraid I don't have the mental capacity to properly review this one right now. From what I've understood of your series so far, it's a strict decrease of fdc craziness. Thanks!

Re: [Qemu-block] [Qemu-devel] [PATCH] opts: produce valid command line in qemu_opts_print

2015-07-03 Thread Markus Armbruster
Kővágó, Zoltán dirty.ice...@gmail.com writes: This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list, or quoting values unnecessarily. This patch provides

Re: [Qemu-block] [PATCH COLO-BLOCK v7 16/17] quorum: implement block driver interfaces for block replication

2015-07-03 Thread Alberto Garcia
On Tue 30 Jun 2015 05:34:44 AM CEST, Wen Congyang wrote: +static void quorum_start_replication(BlockDriverState *bs, ReplicationMode mode, + Error **errp) +{ +BDRVQuorumState *s = bs-opaque; +int count = 0, i, index; +Error *local_err =

Re: [Qemu-block] [Qemu-devel] [RFC 02/10] fdc: add default drive type option

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: We want to change the current default drive type, but to be kind, we need to allow users to specify the old drive type somehow. Signed-off-by: John Snow js...@redhat.com --- hw/block/fdc.c | 13 + hw/core/qdev-properties.c|

Re: [Qemu-block] [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: Lessen the number of parameters it takes. Signed-off-by: John Snow js...@redhat.com Haven't reviewed in detail, but: YES, please!

Re: [Qemu-block] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-03 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here:

Re: [Qemu-block] [Qemu-devel] [RFC 03/10] fdc: respect default drive type

2015-07-03 Thread John Snow
On 07/03/2015 09:34 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: Respect the default drive type as proffered via the CLI. This patch overloads the drive out parameter of pick_geometry to be used as a default hint which is offered by fd_revalidate. Signed-off-by: John

Re: [Qemu-block] [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry

2015-07-03 Thread John Snow
On 07/03/2015 09:45 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: This one is the crazy one. I'm afraid I don't have the mental capacity to properly review this one right now. From what I've understood of your series so far, it's a strict decrease of fdc craziness.

Re: [Qemu-block] NVMe volatile write cache fixes

2015-07-03 Thread Christoph Hellwig
On Wed, Jun 17, 2015 at 02:24:06PM +0200, Kevin Wolf wrote: Am 17.06.2015 um 13:59 hat Christoph Hellwig geschrieben: Thank Eric. Kevin, do you want me to resend the series with these cover letter/cc fixes or is it okay this time? It's not worth a respin. I'm just waiting for an