On 13/07/2015 21:41, John Snow wrote:
s-ports should never exceed 32, but coverity doesn't know that.
ncq_tfs-sector_count should also never exceed 64K.
Personally I tend to mark that kind of thing as a false
positive in the coverity UI and move on...
-- PMM
Either way; Paolo
On Fri, Jul 10, 2015 at 05:42:48AM +0200, Alexandre DERUMIER wrote:
By the way, why did you choose 10 milliseconds? That is quite long.
If this function is called once per 10 ms disk I/O operations then we
lose 50% utilization. 1 ms or less would be reasonable.
From my tests, 1ms is not
On Thu, Jul 09, 2015 at 11:47:58AM +0800, Fam Zheng wrote:
Limiting to sectors_per_chunk for each bdrv_is_allocated_above is slow,
because the underlying protocol driver would issue much more queries
than necessary. We should coalesce the query.
Signed-off-by: Fam Zheng f...@redhat.com
---
Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote:
Ping
On 06/10/2015 08:28 PM, Josh Durgin wrote:
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
cache options and ceph settings. The cache option
It is the same as bdrv_open_image(), except that it doesn't only return
success or failure, but the newly created BdrvChild object for the new
child node.
As the BdrvChild object already contains a BlockDriverState pointer (and
this is supposed to become the only pointer so that bdrv_append() and
Block drivers may still want to access their child nodes in their
.bdrv_close handler. If they unref and/or detach a child by themselves,
this should not result in a double free.
There is additional code for backing files, which are just a special
case of child nodes. The same applies for them.
This patch moves bdrv_attach_child() from the individual places that add
a backing file to a BDS to bdrv_set_backing_hd(), which is called by all
of them. It also adds bdrv_detach_child() there.
For normal operation (starting with one backing file chain and not
changing it until the topmost image
From: Christoph Hellwig h...@lst.de
Implement a real flush instead of faking it. This is especially important
as Qemu assume Write back cashing by default and thus requires a working
cache flush operation for data integrity.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Keith Busch
From: Josh Durgin jdur...@redhat.com
Apply the ceph settings from a config file before any ceph settings
from the command line. Since the ceph config file location may be
specified on the command line, parse it once to read the config file,
and do a second pass to apply the rest of the command
Let the callers of bdrv_open_inherit() call bdrv_attach_child(). It
needs to be called in all cases where bdrv_open_inherit() succeeds (i.e.
returns 0) and a child_role is given.
bdrv_attach_child() is moved upwards to avoid a forward declaration.
Signed-off-by: Kevin Wolf kw...@redhat.com
From: Josh Durgin jdur...@redhat.com
The old one still works for now, but will not work indefinitely.
Signed-off-by: Josh Durgin jdur...@redhat.com
Reviewed-by: Jeff Cody jc...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1
From: Christoph Hellwig h...@lst.de
Implement support in Identify and Get/Set Features to properly report
and allow to change the Volatile Write Cache status reported by the
virtual NVMe device.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Keith Busch keith.bu...@intel.com
On 07/14/2015 04:30 AM, Paolo Bonzini wrote:
On 13/07/2015 21:41, John Snow wrote:
s-ports should never exceed 32, but coverity doesn't know that.
ncq_tfs-sector_count should also never exceed 64K.
Personally I tend to mark that kind of thing as a false
positive in the coverity UI and
From: Josh Durgin jdur...@redhat.com
RBDAIOCB.status was only used for cancel, which was removed in
7691e24dbebb46658e89b3f950fda6ec78bbb823.
RBDAIOCB.sector_num was never used.
RADOSCB.done and rcbid were never used.
RBD_FD* are obsolete since the pipe was removed in
On 07/14/2015 07:20 AM, Kevin Wolf wrote:
Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote:
Ping
On 06/10/2015 08:28 PM, Josh Durgin wrote:
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
cache options and
From: Stefan Hajnoczi stefa...@redhat.com
Reclaim the dirty bitmap if an incremental backup block job is
cancelled. The ret variable may be 0 when the job is cancelled so it's
not enough to check ret 0.
Reviewed-by: John Snow js...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
From: Fam Zheng f...@redhat.com
Before, we only yield after initializing dirty bitmap, where the QMP
command would return. That may take very long, and guest IO will be
blocked.
Add sleep points like the later mirror iterations.
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: Wen Congyang
From: Paolo Bonzini pbonz...@redhat.com
Draining is not necessary, I/O can happen as soon as the
commit coroutine yields. Draining can be necessary before
reopening the file for read/write, or while modifying the
backing file chain, but that is done separately in
bdrv_reopen_multiple or
From: Richard W.M. Jones rjo...@redhat.com
Currently if qemu is connected to a curl source (eg. web server), and
the web server fails / times out / dies, you always see a bogus EIO
Input/output error.
For example, choose a large file located on any local webserver which
you control:
$
From: Wen Congyang we...@cn.fujitsu.com
If bus_size is less than 0, the command fails.
If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE.
If buf_size % granularity is not 0, mirror_free_init() will
do dangerous things.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Reviewed-by: Fam Zheng
Disable scsi passthrough by default since it was incompatible with
virtio 1.0. For legacy machine types, keep this on by default.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
---
Scsi passthrough was no longer supported in 1.0, so fail the
initialization when user want both features.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
---
hw/block/virtio-blk.c | 4
1 file
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
---
hw/block/virtio-blk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index
On 14 July 2015 at 16:39, Kevin Wolf kw...@redhat.com wrote:
The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2015-07-13 13:35:51 +0100)
are available in the git repository at:
24 matches
Mail list logo
