Re: [Qemu-block] [PATCH] ahci: Force ICC bits in PxCMD to zero

2015-07-17 Thread Kevin Wolf
Am 16.07.2015 um 21:54 hat Stefan Fritsch geschrieben: The AHCI spec requires that the HBA sets the ICC bits to zero after the ICC change is done. Since we don't do any ICC change, force the bits to zero all the time. This fixes delays with some OSs (e.g. OpenBSD) waiting for the ICC bits

[Qemu-block] [PATCH v2 2/2] blockdev: always compile in -drive aio= parsing

2015-07-17 Thread Stefan Hajnoczi
CONFIG_LINUX_AIO is an implementation detail of raw-posix.c. Don't mention CONFIG_LINUX_AIO in blockdev.c. Let raw-posix.c decide what to do with BDRV_O_NATIVE_AIO if CONFIG_LINUX_AIO is not defined. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- blockdev.c | 2 -- 1 file changed, 2

[Qemu-block] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable

2015-07-17 Thread Stefan Hajnoczi
v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't

Re: [Qemu-block] [PATCH] blockdev: warn about aio=native if libaio is unavailable

2015-07-17 Thread Stefan Hajnoczi
On Fri, Jul 17, 2015 at 12:56:15PM +0200, Kevin Wolf wrote: Am 17.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: QEMU silently ignores aio=native if libaio is unavailable. It is confusing when aio=native performance is identical to aio=threads because the binary was accidentally built

[Qemu-block] [PATCH] blockdev: warn about aio=native if libaio is unavailable

2015-07-17 Thread Stefan Hajnoczi
QEMU silently ignores aio=native if libaio is unavailable. It is confusing when aio=native performance is identical to aio=threads because the binary was accidentally built without libaio. Use error_report() because failing would break backward compatibility. There are probably users using

Re: [Qemu-block] [PATCH] blockdev: warn about aio=native if libaio is unavailable

2015-07-17 Thread Kevin Wolf
Am 17.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: QEMU silently ignores aio=native if libaio is unavailable. It is confusing when aio=native performance is identical to aio=threads because the binary was accidentally built without libaio. Use error_report() because failing would break

Re: [Qemu-block] [PATCH for-2.4] crypto: Fix aes_decrypt_wrapper()

2015-07-17 Thread Daniel P. Berrange
On Fri, Jul 17, 2015 at 07:48:20PM +0200, Kevin Wolf wrote: Commit d3462e3 broke qcow2's encryption functionality by using encrypt instead of decrypt in the wrapper function it introduces. This was found by qemu-iotests case 134. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-block] [PATCH for-2.4] crypto: Fix aes_decrypt_wrapper()

2015-07-17 Thread Kevin Wolf
Commit d3462e3 broke qcow2's encryption functionality by using encrypt instead of decrypt in the wrapper function it introduces. This was found by qemu-iotests case 134. Signed-off-by: Kevin Wolf kw...@redhat.com --- crypto/cipher-nettle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-17 Thread Programmingkid
On Jul 17, 2015, at 9:41 AM, Stefan Hajnoczi wrote: On Thu, Jul 16, 2015 at 04:46:07PM -0400, Programmingkid wrote: @@ -2014,7 +2015,9 @@ kern_return_t GetBSDPath( io_iterator_t mediaIterator, char *bsdPath, CFIndex ma if ( bsdPathAsCFString ) { size_t devPathLength;

[Qemu-block] [PATCH v3] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-17 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle programmingk...@gmail.com ---