Re: [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-09-21 Thread Peter Lieven
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi: On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven --- block/nfs.c | 4 1 file chang

[Qemu-block] [PATCH v5 36/46] qapi: Avoid use of 'data' member of qapi unions

2015-09-21 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eri

[Qemu-block] [PATCH v5 31/46] qapi: use 'type' in generated C code to match QMP union wire form

2015-09-21 Thread Eric Blake
When dealing with simple qapi unions, the code was generating a discriminator field of 'kind' even though the discriminator is sent as 'type' over QMP. Renaming things to match gets us one step closer to reusing common generator code for both simple and flat unions, without having to special case

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] ide: avoid main-loop hang on CDROM/NFS failure

2015-09-21 Thread Peter Lieven
> Am 21.09.2015 um 22:58 schrieb John Snow : > > > >> On 09/21/2015 08:25 AM, Peter Lieven wrote: >> This series aims at avoiding a hanging main-loop if a vserver has a >> CDROM image mounted from a NFS share and that NFS share goes down. >> Typical situation is that users mount an CDROM ISO t

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] ide: avoid main-loop hang on CDROM/NFS failure

2015-09-21 Thread John Snow
On 09/21/2015 08:25 AM, Peter Lieven wrote: > This series aims at avoiding a hanging main-loop if a vserver has a > CDROM image mounted from a NFS share and that NFS share goes down. > Typical situation is that users mount an CDROM ISO to install something > and then forget to eject that CDROM af

Re: [Qemu-block] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats

2015-09-21 Thread Eric Blake
On 09/21/2015 01:57 AM, Kevin Wolf wrote: >>> +- "wr_highest_offset": The offset after the greatest byte written to >>> the >>> + BlockDriverState since it has been opened >>> (json-int) >> >> ...someday, I'd really like to have this stat show as non-zero even when

[Qemu-block] [PATCH 5/5] block/nfs: cache allocated filesize for read-only files

2015-09-21 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter Lieven

[Qemu-block] [PATCH 3/5] ide: add support for cancelable read requests

2015-09-21 Thread Peter Lieven
this patch adds a new aio readv compatible function which copies all data through a bounce buffer. The benefit is that these requests can be flagged as canceled to avoid guest memory corruption when a canceled request is completed by the backend at a later stage. If an IDE protocol wants to use th

[Qemu-block] [PATCH 4/5] ide/atapi: enable cancelable requests

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 ++-- hw/ide/core.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index b209ed9..ab45495 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -141,7 +141,7 @@ static int cd_read_sector(IDESt

[Qemu-block] [PATCH 2/5] ide/atapi: blk_aio_readv may return NULL

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 9257e1c..b209ed9 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -371,6 +371,10 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret) s-

[Qemu-block] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-09-21 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Signed-off-by: Peter

[Qemu-block] [PATCH 0/5] ide: avoid main-loop hang on CDROM/NFS failure

2015-09-21 Thread Peter Lieven
This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users mount an CDROM ISO to install something and then forget to eject that CDROM afterwards. As a consequence this mounted CD is able to

Re: [Qemu-block] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats

2015-09-21 Thread Kevin Wolf
Am 18.09.2015 um 18:59 hat Eric Blake geschrieben: > On 09/18/2015 09:22 AM, Max Reitz wrote: > > BlockAcctStats contains statistics about the data transferred from and > > to the device; wr_highest_sector does not fit in with the rest. > > > > Furthermore, those statistics are supposed to be spec

Re: [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration

2015-09-21 Thread Alberto Garcia
On Fri 18 Sep 2015 05:54:36 PM CEST, Max Reitz wrote: >> create mode 100644 tests/qemu-iotests/096 >> create mode 100644 tests/qemu-iotests/096.out > > Looks good, I'd just like to throw in that 096 is in use by my > looks-dead-but-actually-is-not and > only-waiting-for-the-blockbackend-and-med