Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5?] qcow2: always initialize specific image info

Am 07.12.2015 um 20:44 hat Max Reitz geschrieben: > I'd be completely fine with adding an "else { abort(); }" branch to > qcow2_get_specific_info(). This is actually what I was going to suggest, too. Of course, it's not supposed to fix anything now, but defensive coding has never hurt. Kevin

Re: [Qemu-block] [Qemu-devel] [PATCH] virtio-blk: Drop x-data-plane option

On Tue, 8 Dec 2015 09:56:14 +0800 Fam Zheng wrote: > On Mon, 12/07 21:02, Fam Zheng wrote: > > On Mon, 12/07 12:29, Cornelia Huck wrote: > > > No general objection to removing x-data-plane; but this probably wants > > > a mention on the changelog as x-data-plane has been

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

Hi Markus, I have to say, you really did a amazing review for this "trivial "patch, thanks a lot & really appreciate it:) On 12/07/2015 05:59 PM, Markus Armbruster wrote: Cao jin writes: msi_init() is a supporting function in PCI device initialization, in

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

Cao jin writes: > Hi Markus, > I have to say, you really did a amazing review for this "trivial > "patch, thanks a lot & really appreciate it:) Thanks! I'm afraid the problem you picked isn't trivial, but I hope it's still simple enough to be a useful exercise to

Re: [Qemu-block] [PATCH v9 00/10] qcow2: Support refcount order amendment

Am 27.07.2015 um 17:51 hat Max Reitz geschrieben: > (v1..v7 were named "qcow2: Support refcount orders != 4") > > This series contains the final 10 patches of my qcow2 refcount order > series, which add refcount order amendment functionality to qemu-img. Thanks, applied to block-next (after some

Re: [Qemu-block] QEMU being able to use audio cdroms

On 11/25/2015 03:44 PM, Programmingkid wrote: > Is there any platform where a guest in QEMU can play an audio cd? If not, is > this a feature that you would allow into QEMU? > I haven't tested it, nobody has ever asked. I wouldn't reject patches for such a feature, but I likely wouldn't make

Re: [Qemu-block] QEMU being able to use audio cdroms

On Dec 8, 2015, at 1:49 PM, John Snow wrote: > > > On 11/25/2015 03:44 PM, Programmingkid wrote: >> Is there any platform where a guest in QEMU can play an audio cd? If not, is >> this a feature that you would allow into QEMU? >> > > I haven't tested it, nobody has ever asked. I wouldn't

Re: [Qemu-block] [PATCH] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

08.12.2015 00:23, Boris Schrijver wrote: [] > It's is therefore better to use only the GET request method, and discard the > body at the first call. Nooo! Please N! Fetching a large file once might be too long already. Fetching it twice is twice as long. Oh well!.. Thanks, /mjt

Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

On Mon, Dec 07, 2015 at 05:10:26PM +, Peter Maydell wrote: > On 7 December 2015 at 15:19, Paolo Bonzini wrote: > > > > > > On 07/12/2015 14:02, Fam Zheng wrote: > >> On Mon, 12/07 12:29, Cornelia Huck wrote: > >>> On Mon, 7 Dec 2015 18:59:27 +0800 > >>> Fam Zheng