Re: [Qemu-block] [PATCH v3] qemu-img: check block status of backing file when converting.

2016-04-20 Thread Ren Kimura
ping

Re: [Qemu-block] [Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-20 Thread Fam Zheng
On Wed, 04/20 22:03, Max Reitz wrote: > On 20.04.2016 20:09, Max Reitz wrote: > > On 20.04.2016 02:03, Matthew Schumacher wrote: > >> Max, > >> > >> Qemu still crashes for me, but the debug is again very different. When > >> I attach to the qemu process from gdb, it is unable to provide a > >>

Re: [Qemu-block] [PATCH for-2.6 v2 0/3] Bug fixes for gluster

2016-04-20 Thread Rik van Riel
On Wed, 2016-04-20 at 13:46 +0200, Kevin Wolf wrote: > Am 20.04.2016 um 12:40 hat Ric Wheeler geschrieben: > > > > On 04/20/2016 05:24 AM, Kevin Wolf wrote: > > > > > > Am 20.04.2016 um 03:56 hat Ric Wheeler geschrieben: > > > > > > > > On 04/19/2016 10:09 AM, Jeff Cody wrote: > > > > > > > >

Re: [Qemu-block] [Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-20 Thread Max Reitz
On 20.04.2016 20:09, Max Reitz wrote: > On 20.04.2016 02:03, Matthew Schumacher wrote: >> Max, >> >> Qemu still crashes for me, but the debug is again very different. When >> I attach to the qemu process from gdb, it is unable to provide a >> backtrace when it crashes. The log file is different

Re: [Qemu-block] [PULL 0/5] Mirror block job fixes for 2.6.0-rc3

2016-04-20 Thread Peter Maydell
On 20 April 2016 at 16:03, Kevin Wolf wrote: > The following changes since commit 4113b0532da6c448f8e458b413ebde035234d0ea: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-04-19-tag' > into staging (2016-04-20 15:05:19 +0100) > > are available in the git

[Qemu-block] [PULL 0/5] Mirror block job fixes for 2.6.0-rc3

2016-04-20 Thread Kevin Wolf
The following changes since commit 4113b0532da6c448f8e458b413ebde035234d0ea: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-04-19-tag' into staging (2016-04-20 15:05:19 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[Qemu-block] [PULL 4/5] iotests: Add iotests.image_size

2016-04-20 Thread Kevin Wolf
From: Fam Zheng This retrieves the virtual size of the image out of qemu-img info. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Signed-off-by: Kevin Wolf ---

[Qemu-block] [PULL 3/5] mirror: Don't extend the last sub-chunk

2016-04-20 Thread Kevin Wolf
From: Fam Zheng The last sub-chunk is rounded up to the copy granularity in the target image, resulting in a larger size than the source. Add a function to clip the copied sectors to the end. This undoes the "wrong" changes to tests/qemu-iotests/109.out in e5b43573e28. The

[Qemu-block] [PULL 2/5] block/mirror: Refresh stale bitmap iterator cache

2016-04-20 Thread Kevin Wolf
From: Max Reitz If the drive's dirty bitmap is dirtied while the mirror operation is running, the cache of the iterator used by the mirror code may become stale and not contain all dirty bits. This only becomes an issue if we are looking for contiguously dirty chunks on the

[Qemu-block] [PULL 1/5] block/mirror: Revive dead yielding code

2016-04-20 Thread Kevin Wolf
From: Max Reitz mirror_iteration() is supposed to wait if the current chunk is subject to a still in-flight mirroring operation. However, it mixed checking this conflict situation with checking the dirty status of a chunk. A simplification for the latter condition (the first

Re: [Qemu-block] [PATCH for-2.6 v3 0/3] block: Fix drive-mirror with image size unaligned with granularity

2016-04-20 Thread Jeff Cody
On Wed, Apr 20, 2016 at 04:32:43PM +0200, Kevin Wolf wrote: > Taking over Fam's series as we're late for -rc3. Original cover letter: > > This fixes the bug introduced in e5b43573e28 and lately noticed by Kevin. > > v2: Move the mirror_clip_sectors() to mirror_iteration. [Max] > v3: Fix

Re: [Qemu-block] [PATCH for-2.6 v3 3/3] iotests: Test case for drive-mirror with unaligned image size

2016-04-20 Thread Jeff Cody
On Wed, Apr 20, 2016 at 04:32:46PM +0200, Kevin Wolf wrote: > From: Fam Zheng > > This is the regression test for the virtual size mismatch issue between > target and source images. > > [ kwolf: Added test_unaligned_with_update ] > > Signed-off-by: Fam Zheng

Re: [Qemu-block] [PATCH for-2.6 v3 0/3] block: Fix drive-mirror with image size unaligned with granularity

2016-04-20 Thread Jeff Cody
On Wed, Apr 20, 2016 at 10:51:04AM -0400, Jeff Cody wrote: > On Wed, Apr 20, 2016 at 04:32:43PM +0200, Kevin Wolf wrote: > > Taking over Fam's series as we're late for -rc3. Original cover letter: > > > > This fixes the bug introduced in e5b43573e28 and lately noticed by > > Kevin. > > > >

Re: [Qemu-block] [PATCH for-2.6 v3 3/3] iotests: Test case for drive-mirror with unaligned image size

2016-04-20 Thread Max Reitz
On 20.04.2016 16:32, Kevin Wolf wrote: > From: Fam Zheng > > This is the regression test for the virtual size mismatch issue between > target and source images. > > [ kwolf: Added test_unaligned_with_update ] > > Signed-off-by: Fam Zheng > Signed-off-by:

Re: [Qemu-block] [PATCH for-2.6 v3 1/3] mirror: Don't extend the last sub-chunk

2016-04-20 Thread Jeff Cody
On Wed, Apr 20, 2016 at 04:32:44PM +0200, Kevin Wolf wrote: > From: Fam Zheng > > The last sub-chunk is rounded up to the copy granularity in the target > image, resulting in a larger size than the source. > > Add a function to clip the copied sectors to the end. > > This

Re: [Qemu-block] [PATCH for-2.6 v3 2/3] iotests: Add iotests.image_size

2016-04-20 Thread Jeff Cody
On Wed, Apr 20, 2016 at 04:32:45PM +0200, Kevin Wolf wrote: > From: Fam Zheng > > This retrieves the virtual size of the image out of qemu-img info. > > Reviewed-by: Max Reitz > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf

Re: [Qemu-block] [Qemu-devel] I/O errors reported to guest for raw-image-file backed /dev/vda - but host sees no I/O errors

2016-04-20 Thread Lutz Vieweg
On 04/20/2016 01:50 PM, Kevin Wolf wrote: To catch all possible write failures, I think pwrite, pwritev and possibly fdatasync need to be considered. I've now a strace -f -p 10727 -e trace=pwrite,pwritev,fdatasync,file -t 2>&1 | gzip -1 -c >trace.gz attached to the qemu-process. If the

Re: [Qemu-block] [PATCH for-2.6 v3 1/3] mirror: Don't extend the last sub-chunk

2016-04-20 Thread Max Reitz
On 20.04.2016 16:32, Kevin Wolf wrote: > From: Fam Zheng > > The last sub-chunk is rounded up to the copy granularity in the target > image, resulting in a larger size than the source. > > Add a function to clip the copied sectors to the end. > > This undoes the "wrong"

[Qemu-block] [PATCH for-2.6 v3 1/3] mirror: Don't extend the last sub-chunk

2016-04-20 Thread Kevin Wolf
From: Fam Zheng The last sub-chunk is rounded up to the copy granularity in the target image, resulting in a larger size than the source. Add a function to clip the copied sectors to the end. This undoes the "wrong" changes to tests/qemu-iotests/109.out in e5b43573e28. The

[Qemu-block] [PATCH for-2.6 v3 2/3] iotests: Add iotests.image_size

2016-04-20 Thread Kevin Wolf
From: Fam Zheng This retrieves the virtual size of the image out of qemu-img info. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6

[Qemu-block] [PATCH for-2.6 v3 3/3] iotests: Test case for drive-mirror with unaligned image size

2016-04-20 Thread Kevin Wolf
From: Fam Zheng This is the regression test for the virtual size mismatch issue between target and source images. [ kwolf: Added test_unaligned_with_update ] Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/152

[Qemu-block] [PATCH for-2.6 v3 0/3] block: Fix drive-mirror with image size unaligned with granularity

2016-04-20 Thread Kevin Wolf
Taking over Fam's series as we're late for -rc3. Original cover letter: This fixes the bug introduced in e5b43573e28 and lately noticed by Kevin. v2: Move the mirror_clip_sectors() to mirror_iteration. [Max] v3: Fix nb_clusters calculation and add a test case for it [Kevin] Fam Zheng (3):

Re: [Qemu-block] [PULL 0/3] Block patches for 2.6

2016-04-20 Thread Peter Maydell
On 19 April 2016 at 17:28, Jeff Cody wrote: > The following changes since commit d4dffa4a3f51b10cc0b7e6e34431919cac7a318e: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-fw_cfg-2016-04-19' > into staging (2016-04-19 15:25:20 +0100) > > are available in the git

Re: [Qemu-block] [PATCH for-2.6 v2 1/3] mirror: Don't extend the last sub-chunk

2016-04-20 Thread Kevin Wolf
Am 20.04.2016 um 04:48 hat Fam Zheng geschrieben: > The last sub-chunk is rounded up to the copy granularity in the target > image, resulting in a larger size than the source. > > Add a function to clip the copied sectors to the end. > > This undoes the "wrong" changes to

Re: [Qemu-block] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-20 Thread Michael S. Tsirkin
On Tue, Apr 19, 2016 at 02:07:01PM -0700, Andy Lutomirski wrote: > On Tue, Apr 19, 2016 at 1:54 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 19, 2016 at 01:27:29PM -0700, Andy Lutomirski wrote: > >> On Tue, Apr 19, 2016 at 1:16 PM, Michael S. Tsirkin > >>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-20 Thread Sascha Silbe
Dear Markus, Markus Armbruster writes: > 'Please run this test via the "check" script' isn't an error message, > it's advice. Advice is appreciated, but an error message must come > first. I reiterate my proposal to use something like > > : TEST_DIR and

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-20 Thread Kevin Wolf
Am 19.04.2016 um 18:49 hat Sascha Silbe geschrieben: > Dear Markus, > > Markus Armbruster writes: > > > Say you had an accurate way to find out whether we're running under > > "check". You could then reject any attempt to run the test directly. > > I'd oppose that. > > > >

Re: [Qemu-block] [PATCH for-2.6 2/2] block/mirror: Refresh stale bitmap iterator cache

2016-04-20 Thread Fam Zheng
On Wed, 04/20 00:59, Max Reitz wrote: > If the drive's dirty bitmap is dirtied while the mirror operation is > running, the cache of the iterator used by the mirror code may become > stale and not contain all dirty bits. > > This only becomes an issue if we are looking for contiguously dirty >

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-20 Thread Markus Armbruster
Max Reitz writes: > On 19.04.2016 14:22, Sascha Silbe wrote: >> Dear Max, >> >> Max Reitz writes: >> >>> On 14.04.2016 13:32, Sascha Silbe wrote: >> [tests/qemu-iotests/iotests.py] >> [...] def main(supported_fmts=[], supported_oses=['linux']):