Re: [Qemu-block] [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This will permit its use in parse_option_size(). Progress! (not that it matters - off_t is a signed value, so you are STILL limited to 2^63, not 2^64, as the maximum theoretical size storage that you can target - and it's not like we have that

Re: [Qemu-block] [Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This makes qemu_strtosz(), qemu_strtosz_mebi() and > qemu_strtosz_metric() similar to qemu_strtoi64(), except negative > values are rejected. Yay. It also opens the door to allowing them to return an unsigned 64 bit value ;) > > Cc: Dr. David

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 03:42:52PM -0600, Eric Blake wrote: > On 02/17/2017 03:37 PM, Jeff Cody wrote: > > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > >> if the passed qiov contains exactly one iov we can > >> pass the buffer directly. > >> > >> Signed-off-by: Peter Lieven

Re: [Qemu-block] [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange > > Signed-off-by: Kevin Wolf

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On 02/17/2017 03:37 PM, Jeff Cody wrote: > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: >> if the passed qiov contains exactly one iov we can >> pass the buffer directly. >> >> Signed-off-by: Peter Lieven >> --- >> block/nfs.c | 23 --- >> 1

Re: [Qemu-block] [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

On 01/25/2017 11:42 AM, Jeff Cody wrote: > From: Kevin Wolf > > This adds blockdev-add support for iscsi devices. > > Reviewed-by: Daniel P. Berrange > Signed-off-by: Kevin Wolf > Signed-off-by: Jeff Cody > --- >

Re: [Qemu-block] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > if the passed qiov contains exactly one iov we can > pass the buffer directly. > > Signed-off-by: Peter Lieven > --- > block/nfs.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > >

Re: [Qemu-block] [PATCH 1/2] block/nfs: convert to preadv / pwritev

On Fri, Feb 17, 2017 at 05:39:00PM +0100, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/nfs.c | 33 +++-- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/block/nfs.c b/block/nfs.c > index 689eaa7..ab5dcc2 100644 >

Re: [Qemu-block] [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Change the qemu_strtosz() & friends to return -EINVAL when @endptr is > null and the conversion doesn't consume the string completely. > Matches how qemu_strtol() & friends work. > > Only test_qemu_strtosz_simple() passes a null @endptr. No

Re: [Qemu-block] [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz()

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-block@nongnu.org > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 58 +++--- > 1 file

Re: [Qemu-block] [PATCH v2 0/7] iscsi: Add blockdev-add support

On Wed, Jan 25, 2017 at 12:42:01PM -0500, Jeff Cody wrote: > This adds blockdev-add support to the iscsi block driver. > > Picked this series up from Kevin. I've tested it on my local iscsi setup. > > There are only a few minor changes: > > * In patch 2, fixed the segfault pointed out by

[Qemu-block] [PULL 02/23] virtio: Report real progress in VQ aio poll handler

From: Fam Zheng In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" cases are making true progress. Currently the offending one is virtio-scsi event queue, whose handler does nothing if no event is pending. As a result aio_poll() will spin on the "non-empty"

Re: [Qemu-block] [Qemu-devel] [PATCH 15/17] iotests: add default node-name

* Fam Zheng (f...@redhat.com) wrote: > On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: > > 17.02.2017 15:21, Fam Zheng wrote: > > > On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > > > > 16.02.2017 16:48, Fam Zheng wrote: > > > > > On Mon, 02/13 12:54, Vladimir

[Qemu-block] [PATCH 1/3] curl: do not use aio_context_acquire/release

Now that all bottom halves and callbacks take care of taking the AioContext lock, we can migrate some users away from it and to a specific QemuMutex or CoMutex. Protect BDRVCURLState access with a QemuMutex. Signed-off-by: Paolo Bonzini --- block/curl.c | 24

[Qemu-block] [PATCH 3/3] iscsi: do not use aio_context_acquire/release

Now that all bottom halves and callbacks take care of taking the AioContext lock, we can migrate some users away from it and to a specific QemuMutex or CoMutex. Protect libiscsi calls with a QemuMutex. Callbacks are invoked using bottom halves, so we don't even have to drop it around callback

[Qemu-block] [PATCH 0/3] do not use aio_context_acquire/release in AIO-based drivers

aio_context_acquire/release are only going away as soon as the block layer becomes thread-safe, but we can already move away to other finer-grained mutex whenever possible. These three drivers don't use coroutines, hence a QemuMutex is a fine primitive to use for protecting any per-BDS data in

[Qemu-block] [PATCH 2/3] nfs: do not use aio_context_acquire/release

Now that all bottom halves and callbacks take care of taking the AioContext lock, we can migrate some users away from it and to a specific QemuMutex or CoMutex. Protect libnfs calls with a QemuMutex. Callbacks are invoked using bottom halves, so we don't even have to drop it around callback

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

On 02/17/2017 04:34 PM, Kevin Wolf wrote: > Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: >> On 02/17/2017 03:48 PM, Kevin Wolf wrote: >>> Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: 17.02.2017 15:09, Kevin Wolf wrote: > Am 17.02.2017 um 12:46 hat

[Qemu-block] [PATCH 0/2] block/nfs optimizations

Peter Lieven (2): block/nfs: convert to preadv / pwritev block/nfs: try to avoid the bounce buffer in pwritev block/nfs.c | 50 -- 1 file changed, 28 insertions(+), 22 deletions(-) -- 1.9.1

[Qemu-block] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

if the passed qiov contains exactly one iov we can pass the buffer directly. Signed-off-by: Peter Lieven --- block/nfs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index ab5dcc2..bb4b75f 100644 ---

[Qemu-block] [PATCH 1/2] block/nfs: convert to preadv / pwritev

Signed-off-by: Peter Lieven --- block/nfs.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 689eaa7..ab5dcc2 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -256,9 +256,9 @@ nfs_co_generic_cb(int

[Qemu-block] [RFC PATCH V4] qemu-img: make convert async

this is something I have been thinking about for almost 2 years now. we heavily have the following two use cases when using qemu-img convert. a) reading from NFS and writing to iSCSI for deploying templates b) reading from iSCSI and writing to NFS for backups In both processes we use libiscsi

Re: [Qemu-block] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

On 02/17/2017 04:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 17:21, Kevin Wolf wrote: >> Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Add detailed error messages. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Why not merge

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

17.02.2017 17:24, Kevin Wolf wrote: Am 17.02.2017 um 14:48 hat Denis V. Lunev geschrieben: On 02/17/2017 04:34 PM, Kevin Wolf wrote: Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: But for sure this is bad from the downtime point of view. On migrate you will have to write to the image

Re: [Qemu-block] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben: > On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: > >> Add tests for creating raw image with and without the preallocation > >> option. > >> > >> Signed-off-by: Nir

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

Am 17.02.2017 um 14:48 hat Denis V. Lunev geschrieben: > On 02/17/2017 04:34 PM, Kevin Wolf wrote: > > Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: > >> But for sure this is bad from the downtime point of view. > >> On migrate you will have to write to the image and re-read > >> it again

Re: [Qemu-block] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: >> Add tests for creating raw image with and without the preallocation >> option. >> >> Signed-off-by: Nir Soffer > > Looks good, but 175 is already

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

On Wed, 01/25 12:42, Jeff Cody wrote: > From: Kevin Wolf > > This splits the logic in the old parse_chap() function into a part that > parses the -iscsi options into the new driver-specific options, and > another part that actually applies those options (called apply_chap() >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

On Fri, 02/17 14:26, Kevin Wolf wrote: > It is the one that it put into the QDict by iscsi_parse_iscsi_option(), > which is supposed to be the value from -iscsi. OK! This is what I was missing. :) Fam

Re: [Qemu-block] [Qemu-devel] [PATCH 15/17] iotests: add default node-name

On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: > 17.02.2017 15:21, Fam Zheng wrote: > > On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > > > 16.02.2017 16:48, Fam Zheng wrote: > > > > On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > > > > > When testing migration,

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

On 02/17/2017 03:48 PM, Kevin Wolf wrote: > Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 17.02.2017 15:09, Kevin Wolf wrote: >>> Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 14:49, Kevin Wolf wrote: > Am 16.02.2017 um 12:25 hat

Re: [Qemu-block] [Qemu-devel] [PATCH 15/17] iotests: add default node-name

17.02.2017 15:21, Fam Zheng wrote: On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: 16.02.2017 16:48, Fam Zheng wrote: On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: When testing migration, auto-generated by qemu node-names differs in source and destination qemu and

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

Am 17.02.2017 um 14:22 hat Denis V. Lunev geschrieben: > On 02/17/2017 03:48 PM, Kevin Wolf wrote: > > Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 17.02.2017 15:09, Kevin Wolf wrote: > >>> Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

Am 07.02.2017 um 11:13 hat Fam Zheng geschrieben: > On Wed, 01/25 12:42, Jeff Cody wrote: > > From: Kevin Wolf > > > > This splits the logic in the old parse_chap() function into a part that > > parses the -iscsi options into the new driver-specific options, and > > another

Re: [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

Am 17.02.2017 um 13:55 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.02.2017 15:21, Kevin Wolf wrote: > > Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 16.02.2017 15:47, Kevin Wolf wrote: > > Sorry, this was sent too early. Next attempt...

Re: [Qemu-block] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

Am 17.02.2017 um 13:24 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 17:08, Kevin Wolf wrote: > >Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>Realize block bitmap storing interface, to allow qcow2 images store > >>persistent bitmaps. > >> > >>Signed-off-by:

Re: [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

17.02.2017 15:21, Kevin Wolf wrote: Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 15:47, Kevin Wolf wrote: Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir

Re: [Qemu-block] [Qemu-devel] [PATCH] block, migration: Use qemu_madvise inplace of madvise

On Fri 17 Feb 2017 01:30:09 PM CET, Pankaj Gupta wrote: > I think 'posix_madvise' was added for systems which didnot have > 'madvise' [...] For the systems which don't have madvise call > 'posix_madvise' is called which as per discussion is not right thing > for 'DONTNEED' option. It will not give

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

Am 17.02.2017 um 13:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.02.2017 15:09, Kevin Wolf wrote: > >Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>16.02.2017 14:49, Kevin Wolf wrote: > >>>Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > Am 15.02.2017 um

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

17.02.2017 15:09, Kevin Wolf wrote: Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 16.02.2017 14:49, Kevin Wolf wrote: Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Auto loading bitmaps are

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

On Fri 17 Feb 2017 12:30:28 PM CET, Pankaj Gupta wrote: >> > To maintain consistency at all the places use qemu_madvise wrapper >> > inplace of madvise call. >> >> > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); >> > +qemu_madvise((uint8_t *) t + offset, length,

Re: [Qemu-block] [Qemu-devel] [PATCH] block, migration: Use qemu_madvise inplace of madvise

> > * Pankaj Gupta (pagu...@redhat.com) wrote: > > > > Thanks for your comments. I have below query. > > > > > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > > > To maintain consistency at all the places use qemu_madvise wrapper > > > > inplace of madvise call. > > > > > > >

Re: [Qemu-block] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

16.02.2017 17:08, Kevin Wolf wrote: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz

Re: [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

Am 17.02.2017 um 13:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 15:47, Kevin Wolf wrote: > >Sorry, this was sent too early. Next attempt... > > > >Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: > >>Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>>Auto

Re: [Qemu-block] [Qemu-devel] [PATCH 15/17] iotests: add default node-name

On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 16:48, Fam Zheng wrote: > > On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > > > When testing migration, auto-generated by qemu node-names differs in > > > source and destination qemu and migration fails. After this

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

Am 17.02.2017 um 12:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.02.2017 14:49, Kevin Wolf wrote: > >Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > >>Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>>Auto loading bitmaps are bitmaps stored in the disk image,

Re: [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

16.02.2017 15:47, Kevin Wolf wrote: Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when

Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps

16.02.2017 14:49, Kevin Wolf wrote: Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Auto loading bitmaps are bitmaps stored in the disk image, which should be loaded when the image is opened and become BdrvDirtyBitmaps for

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

* Pankaj Gupta (pagu...@redhat.com) wrote: > > Thanks for your comments. I have below query. > > > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > > To maintain consistency at all the places use qemu_madvise wrapper > > > inplace of madvise call. > > > > > if (length > 0) {

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

Thanks for your comments. I have below query. > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > if (length > 0) { > > -madvise((uint8_t *) t + offset, length,

Re: [Qemu-block] [Qemu-devel] [PATCH 15/17] iotests: add default node-name

16.02.2017 16:48, Fam Zheng wrote: On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: When testing migration, auto-generated by qemu node-names differs in source and destination qemu and migration fails. After this patch, auto-generated by iotest nodenames will be the same. What should

Re: [Qemu-block] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

16.02.2017 17:21, Kevin Wolf wrote: Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: Add detailed error messages. Signed-off-by: Vladimir Sementsov-Ogievskiy Why not merge this patch into the one that originally introduced the function? Just to

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > To maintain consistency at all the places use qemu_madvise wrapper > inplace of madvise call. > if (length > 0) { > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); > +qemu_madvise((uint8_t *) t + offset,

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

* Kevin Wolf (kw...@redhat.com) wrote: > Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > > Signed-off-by: Pankaj Gupta > > Reviewed-by: Kevin Wolf

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben: > To maintain consistency at all the places use qemu_madvise wrapper > inplace of madvise call. > > Signed-off-by: Pankaj Gupta Reviewed-by: Kevin Wolf Juan/Dave, if one of you can give an Acked-by, I

[Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

To maintain consistency at all the places use qemu_madvise wrapper inplace of madvise call. Signed-off-by: Pankaj Gupta --- block/qcow2-cache.c | 2 +- migration/postcopy-ram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cache.c