Re: [Qemu-block] [PATCH 4/4] block/rbd: Add blockdev-add support

2017-02-26 Thread Jeff Cody
On Mon, Feb 27, 2017 at 02:30:41AM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qapi/block-core.json | 47 --- > 1 file changed, 44 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json

[Qemu-block] [PATCH 2/4] block/rbd: code movement

2017-02-26 Thread Jeff Cody
Signed-off-by: Jeff Cody --- block/rbd.c | 64 +++-- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 3f1a9de..c8d4eb1 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -357,6

[Qemu-block] [PATCH 3/4] block/rbd: parse all options via bdrv_parse_filename

2017-02-26 Thread Jeff Cody
Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename. This simplifies a lot of the parsing as well, as we can treat everything a bit simpler since nonexistent options are simply NULL pointers instead of empy strings. An important item to note: Ceph has many extra option values that can

[Qemu-block] [PATCH 1/4] block/rbd: don't copy strings in qemu_rbd_next_tok()

2017-02-26 Thread Jeff Cody
This patch is prep work for parsing options for .bdrv_parse_filename, and using QDict options. The function qemu_rbd_next_tok() searched for various key/value pairs, and copied them into buffers. This will soon be an unnecessary extra step, so we will now return found strings by reference only,

[Qemu-block] [PATCH 0/4] RBD: blockdev-add

2017-02-26 Thread Jeff Cody
This series adds blockdev-add for rbd. However, there is an area that will likely need to change. In the RBD driver, all options for Ceph are supported, but the qemu driver is not explicitly aware of all the options. There are a few options that the QEMU driver cares about and handles, while

[Qemu-block] [PATCH 4/4] block/rbd: Add blockdev-add support

2017-02-26 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qapi/block-core.json | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 5f82d35..08a1419 100644 --- a/qapi/block-core.json +++

[Qemu-block] [PATCH] blk: Add discard=sparse mode

2017-02-26 Thread Samuel Thibault
By default, on discard requests, the posix block backend punches holes but re-fallocates them to keep the allocated size intact. In some situations it is however convenient, when using sparse disk images, to see disk image sizes shrink on discard requests. This commit adds a discard=sparse mode

Re: [Qemu-block] [PULL 0/3] Block patches

2017-02-26 Thread Peter Maydell
On 24 February 2017 at 17:46, Jeff Cody wrote: > The following changes since commit fe8ee082db5038a05dbd8872e946049e9a9c550e: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-22' > into staging (2017-02-24 15:00:51 +) > > are available in the git