On 04/12/2017 10:05 PM, zhanghailiang wrote:
We use these two options to identify which disk is
shared
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v4:
- Add proper comment for primary_disk (Stefan)
v2:
- Move g_free(s->shared_disk_id) to the common
Am 18.04.2017 um 03:33 schrieb Eric Blake:
Rework the debug define so that we always get -Wformat checking,
even when debugging is disabled.
Signed-off-by: Eric Blake
---
Reviewed-by: Stefan Weil
block/vdi.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a
So he can get CC'ed on future patches and bugs for this feature
Signed-off-by: Changlong Xie
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c60235e..5638992 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1817,7 +1817,7 @@ S: Su
On 04/18/2017 09:36 AM, Hailiang Zhang wrote:
On 2017/4/18 9:23, Eric Blake wrote:
On 03/17/2017 08:15 AM, Kevin Wolf wrote:
From: Changlong Xie
Even if hidden_disk, secondary_disk are backing files, they all need
write permissions in replication scenario. Otherwise we will encouter
below e
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vvfat driver accordingly.
Signed-off-by: Eric Blake
---
block/vvfat.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index bef2056..825fe72 1
On 04/17/2017 08:33 PM, Eric Blake wrote:
> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
> but NBD wants to report status on byte granularity (even if the
> reporting will probably be naturally aligned to sectors or even
> much higher levels). I've therefore started the task of
>
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vpc driver accordingly.
Signed-off-by: Eric Blake
---
block/vpc.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index ecfee
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vmdk driver accordingly.
Signed-off-by: Eric Blake
---
block/vmdk.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index c61b9cc.
Rework the debug define so that we always get -Wformat checking,
even when debugging is disabled.
Signed-off-by: Eric Blake
---
block/vdi.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index d12d9cd..a70b969 100644
--- a/block/vdi.c
+
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the raw driver accordingly.
Signed-off-by: Eric Blake
---
block/raw-format.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/block/raw-format.c b/block/raw-format.c
index 3
On 2017/4/18 9:23, Eric Blake wrote:
On 03/17/2017 08:15 AM, Kevin Wolf wrote:
From: Changlong Xie
Even if hidden_disk, secondary_disk are backing files, they all need
write permissions in replication scenario. Otherwise we will encouter
below exceptions on secondary side during adding nbd ser
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the parallels driver accordingly. Note that
the internal function block_status() is still sector-based, because
it is still in use by other sector-based functions; but that's okay
because request_alignment is 51
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the sheepdog driver accordingly.
Signed-off-by: Eric Blake
---
block/sheepdog.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the qed driver accordingly.
Signed-off-by: Eric Blake
---
block/qed.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index fd76817..336da
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the qcow2 driver accordingly.
Signed-off-by: Eric Blake
---
block/qcow2.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4272cca..0de7
We are gradually moving away from sector-based interfaces, towards
byte-based. Now that the block layer exposes byte-based allocation,
it's time to tackle the drivers. Add a new callback that operates
on as small as byte boundaries, and update the block layer to ensure
that the callback is only us
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the qcow driver accordingly.
Signed-off-by: Eric Blake
---
block/qcow.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 5d147b9..d
We are gradually moving away from sector-based interfaces, towards
byte-based. Now that all drivers have been updated to provide the
byte-based .bdrv_co_block_status(), we can delete the sector-based
interface.
Signed-off-by: Eric Blake
---
include/block/block_int.h | 3 ---
block/io.c
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the gluster driver accordingly.
Signed-off-by: Eric Blake
---
block/gluster.c | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/block/gluster
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vdi driver accordingly. Note that the
TODO is already covered (the block layer guarantees bounds of its
requests), and that we can remove the now-unused s->block_sectors.
Signed-off-by: Eric Blake
---
blo
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the mirror driver accordingly.
Signed-off-by: Eric Blake
---
block/mirror.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 750be1f..ebd0adf
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert all uses of
the allocmap (no semantic change). Callers that already had bytes
available are simpler, and callers that now scale to bytes will be
easier to switch to byte-based in th
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the null driver accordingly.
Signed-off-by: Eric Blake
---
block/null.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/block/null.c b/block/null.c
index b300390..2d
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the iscsi driver accordingly. In this case,
it is handy to teach iscsi_co_block_status() to handle a NULL file
parameter, even though the block layer passes a non-NULL value,
because we also call the function di
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert all uses of
the cluster size in sectors, along with adding assertions that we
are not dividing by zero.
Signed-off-by: Eric Blake
---
block/iscsi.c | 56 ++
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
---
block/io.c | 42
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the file protocol driver accordingly.
Signed-off-by: Eric Blake
---
block/file-posix.c | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/bloc
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the commit driver accordingly.
Signed-off-by: Eric Blake
---
block/commit.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 989de7d..1cc7a00
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Change the internal
loop iteration of zeroing a device to track by bytes instead of
sectors (although we are still guaranteed that we iterate by steps
that are sector-aligned).
Signed-off-b
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
---
block/io.c | 30 +---
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change), and as with its public counterpart,
rename to bdrv_co_block_status() to make the compiler enforce that
we catch all uses. For now, we
Now that the last user [mirror_iteration()] has converted to using
bytes, we no longer need a function to round sectors to clusters.
Signed-off-by: Eric Blake
---
include/block/block.h | 4
block/io.c| 21 -
2 files changed, 25 deletions(-)
diff --git a/inc
There are patches floating around to add NBD_CMD_BLOCK_STATUS,
but NBD wants to report status on byte granularity (even if the
reporting will probably be naturally aligned to sectors or even
much higher levels). I've therefore started the task of
converting our block status code to report at a byt
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change), and rename it to is_zero_above() in
the process.
Signed-off-by: Eric Blake
---
block/qcow2.c | 32 ++--
In the process of converting sector-based interfaces to bytes,
I'm finding it easier to represent a byte count as a 64-bit
integer at the block layer (even if we are internally capped
by SIZE_MAX or even INT_MAX for individual transactions, it's
still nicer to not have to worry about truncation/ove
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Continue by converting
an internal function (no semantic change), and simplifying its
caller accordingly.
Signed-off-by: Eric Blake
---
qemu-img.c | 24 +++-
1 file ch
On 03/17/2017 08:15 AM, Kevin Wolf wrote:
> From: Changlong Xie
>
> Even if hidden_disk, secondary_disk are backing files, they all need
> write permissions in replication scenario. Otherwise we will encouter
> below exceptions on secondary side during adding nbd server:
>
> {'execute': 'nbd-ser
On 04/17/2017 06:42 PM, John Snow wrote:
>
>
> On 04/11/2017 06:29 PM, Eric Blake wrote:
>> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
>> but NBD wants to report status on byte granularity (even if the
>> reporting will probably be naturally aligned to sectors or even
>> much
On 04/17/2017 06:24 PM, John Snow wrote:
>
>
> On 04/11/2017 06:29 PM, Eric Blake wrote:
>> We are gradually converting to byte-based interfaces, as they are
>> easier to reason about than sector-based. Continue by converting
>> the public interface to backup jobs (no semantic change), including
On 04/11/2017 06:29 PM, Eric Blake wrote:
> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
> but NBD wants to report status on byte granularity (even if the
> reporting will probably be naturally aligned to sectors or even
> much higher levels). I've therefore started the task of
On 04/11/2017 06:29 PM, Eric Blake wrote:
> We are gradually converting to byte-based interfaces, as they are
> easier to reason about than sector-based. Continue by converting
> the public interface to backup jobs (no semantic change), including
> a change to CowRequest to track by bytes instea
On 04/17/2017 02:18 PM, John Snow wrote:
>> @@ -346,13 +349,15 @@ static uint64_t coroutine_fn
>> mirror_iteration(MirrorBlockJob *s)
>> if (sector_num < 0) {
>> bdrv_set_dirty_iter(s->dbi, 0);
>> sector_num = bdrv_dirty_iter_next(s->dbi);
>> -trace_mirror_restart_i
On 04/17/2017 02:18 PM, John Snow wrote:
>
>
> On 04/11/2017 06:29 PM, Eric Blake wrote:
>> The user interface specifies job rate limits in bytes/second.
>> It's pointless to have our internal representation track things
>> in sectors/second, particularly since we want to move away from
>> sector
On 04/11/2017 06:29 PM, Eric Blake wrote:
> The user interface specifies job rate limits in bytes/second.
> It's pointless to have our internal representation track things
> in sectors/second, particularly since we want to move away from
> sector-based interfaces.
>
> Fix up a doc typo found whi
On 04/11/2017 06:29 PM, Eric Blake wrote:
> Upcoming patches are going to switch to byte-based interfaces
> instead of sector-based. Even worse, trace_backup_do_cow_enter()
> had a weird mix of cluster and sector indices. Make the tracing
> uniformly use bytes.
>
> Signed-off-by: Eric Blake
>
Hi Max,
On 04/13/2017 01:06 PM, Max Reitz wrote:
Reproducer:
$ ./qemu-img info ''
qemu-img: ./block.c:1008: bdrv_open_driver: Assertion
`!drv->bdrv_needs_filename || bs->filename[0]' failed.
[1]26105 abort (core dumped) ./qemu-img info ''
This patch fixes this to be:
On 04/03/2017 01:09 PM, Max Reitz wrote:
We will need very similar functionality for full/falloc preallocation in
qcow2_truncate(). Although we will not be able to reuse much of the
actual code, it still makes sense to keep all of this in one place.
Signed-off-by: Max Reitz
Reviewed-by: Stefan
On Mon, Apr 17, 2017 at 04:27:19PM +0800, Fam Zheng wrote:
> On Fri, 04/14 09:51, Stefan Hajnoczi wrote:
> > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote:
> > > @@ -398,11 +399,15 @@ void bdrv_drain_all(void);
> > > */\
> > > a
On Fri, 04/14 09:51, Stefan Hajnoczi wrote:
> On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote:
> > @@ -398,11 +399,15 @@ void bdrv_drain_all(void);
> > */\
> > assert(!bs_->wakeup); \
> > bs_-
On Thu, 04/13 18:06, Max Reitz wrote:
> See patch 1 for what is happening when you try "qemu-img info ''" and
> for the fix.
>
> (Patch 2 just adds a simple test.)
Reviewed-by: Fam Zheng
52 matches
Mail list logo
