Re: [Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

CC'ing Andreas Färber. Could you please give a quick look below at the way the iothread object is instantiate and destroyed? I am no object model expert and would appreaciate a second opinion. On Wed, 21 Jun 2017, Paul Durrant wrote: > This patch allocates an IOThread object for each xen_disk

Re: [Qemu-block] [PATCH v2 1/4] qemu-img: add --shrink flag for resize

On 22.06.2017 17:49, Kevin Wolf wrote: Am 22.06.2017 um 15:54 hat Pavel Butsykin geschrieben: On 22.06.2017 01:17, Max Reitz wrote: On 2017-06-13 14:16, Pavel Butsykin wrote: The flag as additional precaution of data loss. Perhaps in the future the operation shrink without this flag will be

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/4] block: qobject_is_equal() in bdrv_reopen_prepare()

Max Reitz writes: > On 2017-06-21 18:06, Markus Armbruster wrote: >> Max Reitz writes: >> >>> Currently, bdrv_reopen_prepare() assumes that all BDS options are >>> strings. However, this is not the case if the BDS has been created >>> through the json:

Re: [Qemu-block] [PATCH v2 1/4] qemu-img: add --shrink flag for resize

Am 22.06.2017 um 15:54 hat Pavel Butsykin geschrieben: > On 22.06.2017 01:17, Max Reitz wrote: > >On 2017-06-13 14:16, Pavel Butsykin wrote: > >>The flag as additional precaution of data loss. Perhaps in the future the > >>operation shrink without this flag will be banned, but while we need to >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/4] qapi/qnull: Add own header

Max Reitz writes: > On 2017-06-21 18:24, Markus Armbruster wrote: >> Max Reitz writes: >> >>> Reviewed-by: Kevin Wolf >>> Signed-off-by: Max Reitz >>> --- >>> include/qapi/qmp/qnull.h | 26

Re: [Qemu-block] [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it

On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote: > On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote: > > [...] > >>> * TODO (after feedback from John Snow): >>>- Eric Blake suggested to consider documenting incremental backup >>> policies as part of the section: "Live disk

Re: [Qemu-block] [PATCH v2 2/4] qcow2: add qcow2_cache_discard

On 22.06.2017 01:29, Max Reitz wrote: On 2017-06-13 14:16, Pavel Butsykin wrote: Whenever l2/refcount table clusters are discarded from the file we can automatically drop unnecessary content of the cache tables. This reduces the chance of eviction useful cache data and eliminates inconsistent

Re: [Qemu-block] [Qemu-devel] [Question] How can we confirm hot-plug disk succesfully?

Kevin Wolf writes: > Am 19.06.2017 um 12:27 hat Xie Changlong geschrieben: >> 在 6/19/2017 3:27 PM, Kevin Wolf 写道: >> >Am 18.06.2017 um 09:21 hat Xie Changlong geschrieben: >> >>In device hot-remove scenario, if we don't probe acpiphp module on >> >>the guest, 'device_del' will

Re: [Qemu-block] [PATCH v2 1/4] qemu-img: add --shrink flag for resize

On 22.06.2017 01:17, Max Reitz wrote: On 2017-06-13 14:16, Pavel Butsykin wrote: The flag as additional precaution of data loss. Perhaps in the future the operation shrink without this flag will be banned, but while we need to maintain compatibility. Signed-off-by: Pavel Butsykin

[Qemu-block] [PATCH 08/31] qcow2: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-block] [PATCH 10/31] vvfat: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vvfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-block] [PATCH 09/31] vpc: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index

[Qemu-block] [PATCH 07/31] dmg: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/dmg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/dmg.c b/block/dmg.c index

[Qemu-block] [PATCH 03/31] vhdx: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vhdx-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vhdx-log.c b/block/vhdx-log.c

[Qemu-block] [PATCH] docs: add qemu-block-drivers(7) man page

Block driver documentation is available in qemu-doc.html. It would be convenient to have documentation for formats, protocols, and filter drivers in a man page. Extract the relevant part of qemu-doc.html into a new file called docs/qemu-block-drivers.texi. This file can also be built as a

Re: [Qemu-block] [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it

On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote: [...] > > * TODO (after feedback from John Snow): > >- Eric Blake suggested to consider documenting incremental backup > > policies as part of the section: "Live disk backup --- > > `drive-backup` and `blockdev-backup`" >