Re: [Qemu-block] [Qemu-devel] [PATCH] ide: check BlockBackend object in ide_cancel_dma_sync

On 07/14/2017 06:00 AM, P J P wrote: > From: Prasad J Pandit > > When cancelling pending DMA requests in ide_cancel_dma_sync, > the s->blk object could be null, leading to a null dereference. > Add check to avoid it. > > Reported-by: Chensongnian

Re: [Qemu-block] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

19.07.2017 20:12, Eric Blake wrote: On 07/19/2017 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: 07.07.2017 23:30, Eric Blake wrote: [..] +/* Returns -1 if NBD_OPT_GO proves the export @wantname cannot be + * used, 0 if NBD_OPT_GO is unsupported (fall back to NBD_OPT_LIST and + *

Re: [Qemu-block] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

On 07/19/2017 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.07.2017 23:30, Eric Blake wrote: > > [..] > >> >> +/* Returns -1 if NBD_OPT_GO proves the export @wantname cannot be >> + * used, 0 if NBD_OPT_GO is unsupported (fall back to NBD_OPT_LIST and >> + * NBD_OPT_EXPORT_NAME in that

Re: [Qemu-block] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

07.07.2017 23:30, Eric Blake wrote: [..] +/* Returns -1 if NBD_OPT_GO proves the export @wantname cannot be + * used, 0 if NBD_OPT_GO is unsupported (fall back to NBD_OPT_LIST and + * NBD_OPT_EXPORT_NAME in that case), and > 0 if the export is good to + * go (with @info populated). */ +static

Re: [Qemu-block] [PATCH for-2.10 v2] block: Skip implicit nodes in query-block/blockstats

On Wed, Jul 19, 2017 at 09:55:51 -0500, Eric Blake wrote: > On 07/19/2017 08:58 AM, Kevin Wolf wrote: > > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > > nodes above the top layer of mirror and commit block jobs. The > > assumption made there was that since libvirt

Re: [Qemu-block] [PATCH v2] docs: add qemu-block-drivers(7) man page

On Mon, Jul 17, 2017 at 02:37:49PM -0400, John Snow wrote: > On 06/27/2017 11:41 AM, Stefan Hajnoczi wrote: > > Block driver documentation is available in qemu-doc.html. It would be > > convenient to have documentation for formats, protocols, and filter > > drivers in a man page. > > > > Extract

Re: [Qemu-block] [PATCH for-2.10 v2] block: Skip implicit nodes in query-block/blockstats

On Wed, Jul 19, 2017 at 15:58:05 +0200, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer

Re: [Qemu-block] [PATCH for-2.10 v2] block: Skip implicit nodes in query-block/blockstats

On 07/19/2017 08:58 AM, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer yet, it

[Qemu-block] [PATCH for-2.10 v2] block: Skip implicit nodes in query-block/blockstats

Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet, it shouldn't be affected by added nodes. This is true as

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

Am 19.07.2017 um 15:05 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > > nodes above the top layer of mirror and commit block jobs. The > > assumption made there was that since libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

On Wed, Jul 19, 2017 at 4:05 PM Markus Armbruster wrote: > Kevin Wolf writes: > > > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > > nodes above the top layer of mirror and commit block jobs. The > > assumption made there was that

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

Kevin Wolf writes: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer yet, it shouldn't

Re: [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

On 07/19/2017 03:44 AM, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer yet, it

Re: [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

Am 19.07.2017 um 13:15 hat Peter Krempa geschrieben: > On Wed, Jul 19, 2017 at 10:44:47 +0200, Kevin Wolf wrote: > > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > > nodes above the top layer of mirror and commit block jobs. The > > assumption made there was that since

Re: [Qemu-block] [PULL 00/21] Block layer patches

On 18 July 2017 at 15:17, Kevin Wolf wrote: > The following changes since commit 718d7f4f9cf772e5784093d8e6085680a235acdb: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-07-18 13:09:51 +0100) > > are available in the git

Re: [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

On Wed, Jul 19, 2017 at 10:44:47 +0200, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer

Re: [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

[ Cc: qemu-stable ] Am 19.07.2017 um 11:21 hat Manos Pitsidianakis geschrieben: > On Wed, Jul 19, 2017 at 10:44:47AM +0200, Kevin Wolf wrote: > >Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > >nodes above the top layer of mirror and commit block jobs. The > >assumption

Re: [Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

On Wed, Jul 19, 2017 at 10:44:47AM +0200, Kevin Wolf wrote: Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer

[Qemu-block] [PATCH for-2.10] block: Skip implicit nodes in query-block/blockstats

Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet, it shouldn't be affected by added nodes. This is true as

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default

On Tue, Jul 18, 2017 at 09:24:08PM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> migrate-set-parameters sets migration parameters according to is > >> arguments like this: > >> > >> * Present

Re: [Qemu-block] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws

Am 18.07.2017 um 18:08 hat Daniel P. Berrange geschrieben: > On Tue, Jul 18, 2017 at 03:41:16PM +0200, Markus Armbruster wrote: > > blockdev-add and migrate-set-parameters overload empty strings to mean > > something entirely different. See my memo "qapi: Stop abusing > > "special" values for

Re: [Qemu-block] [Qemu-devel] [PULL 00/21] Block layer patches

Am 18.07.2017 um 20:57 hat no-re...@patchew.org geschrieben: > ** > ERROR:/tmp/qemu-test/src/tests/test-qga.c:78:fixture_setup: assertion failed > (fixture->fd != -1): (-1 != -1) > GTester: last random seed: R02S1e410abb69660daf8fd594a35e52f43b > make: *** [check-tests/test-qga] Error 1 > make: